From: Dave Hansen <dave.hansen@intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
alexander.h.duyck@intel.com, pavel.tatashin@microsoft.com,
akpm@linux-foundation.org, mingo@kernel.org,
kirill.shutemov@linux.intel.com
Subject: Re: [PATCH v2 1/2] mm: Move page struct poisoning to CONFIG_DEBUG_VM_PAGE_INIT_POISON
Date: Thu, 6 Sep 2018 09:09:46 -0700 [thread overview]
Message-ID: <33f39b37-9567-88a8-097d-a63df04c7732@intel.com> (raw)
In-Reply-To: <20180906151336.GD14951@dhcp22.suse.cz>
On 09/06/2018 08:13 AM, Michal Hocko wrote:
>> CONFIG_DEBUG_VM_SLOW_AS_HECK
>>
>> under which we can put this an other really slow VM debugging. Or, we
>> need some kind of boot-time parameter to trigger the extra checking
>> instead of a new CONFIG option.
> I strongly suspect nobody will ever enable such a scary looking config
> TBH. Besides I am not sure what should go under that config option.
OK, so call it CONFIG_DEBUG_VM2, or CONFIG_DEBUG_VM_MORE. :)
What do we put under it? The things that folks complain about that get
turned on with DEBUG_VM, like this.
> Is this worth a separate config option almost nobody is going to
> enable?
Yes. We get basically *zero* debug checking from this option. We want
it available to developers mucking with boot and hotplug, but it's
honestly not worth it for normal users.
Has anyone ever seen a single in-the-wild report from this mechanism?
next prev parent reply other threads:[~2018-09-06 16:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 21:13 [PATCH v2 0/2] Address issues slowing memory init Alexander Duyck
2018-09-05 21:13 ` [PATCH v2 1/2] mm: Move page struct poisoning to CONFIG_DEBUG_VM_PAGE_INIT_POISON Alexander Duyck
2018-09-05 21:22 ` Pasha Tatashin
2018-09-05 21:29 ` Alexander Duyck
2018-09-05 21:38 ` Pasha Tatashin
2018-09-05 21:54 ` Alexander Duyck
2018-09-05 21:34 ` Dave Hansen
2018-09-06 5:47 ` Michal Hocko
2018-09-06 14:59 ` Dave Hansen
2018-09-06 15:13 ` Michal Hocko
2018-09-06 15:41 ` Alexander Duyck
2018-09-06 16:12 ` Pasha Tatashin
2018-09-06 17:07 ` Dave Hansen
2018-09-06 18:08 ` Michal Hocko
2018-09-06 17:03 ` Michal Hocko
2018-09-06 17:23 ` Pasha Tatashin
2018-09-06 16:09 ` Dave Hansen [this message]
2018-09-06 17:08 ` Michal Hocko
2018-09-05 21:13 ` [PATCH v2 2/2] mm: Create non-atomic version of SetPageReserved for init use Alexander Duyck
2018-09-06 5:49 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33f39b37-9567-88a8-097d-a63df04c7732@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=pavel.tatashin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).