From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD06BC5AE59 for ; Thu, 5 Jun 2025 13:27:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56A696B00A0; Thu, 5 Jun 2025 09:27:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 519F46B00A1; Thu, 5 Jun 2025 09:27:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 457B66B00A2; Thu, 5 Jun 2025 09:27:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2A1326B00A0 for ; Thu, 5 Jun 2025 09:27:12 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 187F7809BB for ; Thu, 5 Jun 2025 13:27:10 +0000 (UTC) X-FDA: 83521423020.25.197BC6A Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by imf25.hostedemail.com (Postfix) with ESMTP id 1C32DA000A for ; Thu, 5 Jun 2025 13:27:07 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LwpgdDWp; spf=pass (imf25.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749130028; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dc0t8LJWwMsH8u7lCLoZZlP0jO1SucXJeyDx8z9BxhY=; b=KRJ2X+MsyagAQQKpc+jkwX+qkOr+ai2qQA95TDJXUmaPHlNzIFN6dpZeyHd1YxwIgoRPxz v5te3tUIF/kEkRxcDoi/fGNKCq0OzP7/ffw6Kx2hyBKM4DdUBl1Xn85yH40gpBdk4UPAx1 pA1dLu2G1hp9wJZ2B76Cls7qWvROsOY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LwpgdDWp; spf=pass (imf25.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749130028; a=rsa-sha256; cv=none; b=xxL1i85FIjROdiCzj6QcX4Fe3qniq/eWv8ySPg5Mpnix8a9xrFtiR86JdR2ZMudmtTsims Gr22dpdYzYqhl8jcn8shyNDFD7Gdh6dIpqAXfvRVqqR8yNLpmYbwv3nMENTe7MR7I94qY+ KGi7e239mWbZv0+1BrZON6TFHLa9T+Y= Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-450d37d4699so5913595e9.0 for ; Thu, 05 Jun 2025 06:27:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749130026; x=1749734826; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Dc0t8LJWwMsH8u7lCLoZZlP0jO1SucXJeyDx8z9BxhY=; b=LwpgdDWph2faVOtnyU9lAV3JMmMA/5IRrdU00JmiRliAZJnV0BOdabD4VLMV3+XV5P XCpmcaYdLlmuVjSQV1EjdO4dt3lUrC/Ez/Rx+PuahfbjnRuO8e3Bl2sb0PiUgNTGhWjL 62m4mzlH3yaVP9mIN4wUTF7zTSBQtLRHV6EiXuhDu0MM9DWxN+d2G66/ETlKUj0IEbyu GOw7fpCGBNslnX1sx2sk6EAJtL4mXxZML0KpfvZaFmEEfYYxQz6XFAoT3DW43TaZlYhc Mm8zLVyuLO7DMgU8re6TFdTuRFgo/pa8Ypo/eRti2kJOCM33YWYyQTPZeGRc/XyBQJXU JmLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749130026; x=1749734826; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dc0t8LJWwMsH8u7lCLoZZlP0jO1SucXJeyDx8z9BxhY=; b=HDE8n20Qg4+Sh7IGblhrXx7BXtgLEgB0dxmrdeNcz/UHrWhIrr/KpwfFQBAXi9FdAQ ik7eSD5j9pR/BJwXnyD8VLpBRWYmtYsCiZGebBG+d8mv4A0qsVIcsdd1bhcrjQjAtZbq Cp51FwwmWX9zKj5Z1lwEnHoTeSXYpeNc4IA2EweqSOc9lHRdgKnaFIAyfFZJz7uXkUEC h9jQDZet+kLdeC/WIj2MFfdw+JVOMu9nBQ6D1GPpQtXAXv1dZzytGoVSASADjcWZ+8fA bMU4AJDXdEo0MHr8Sol3/xPvHU4ayKyckUyamXYr+yOZOHtFHk5GDAADKF8l65kcTcqe 7jCw== X-Forwarded-Encrypted: i=1; AJvYcCUGpW/hYEAyuhHg5zP9OT2qYE0xGQQy6zDBaXGqSU5ZVHdUzqV3YLIGVqDKiKiNm6GLd2y3S8rkXg==@kvack.org X-Gm-Message-State: AOJu0Yxaco/LP6U43hSnCeqCcIB8agh72Dv5NKoXl00qZpISFQlAvfN4 1X9cOKU+P93Cmzka8MgGBQ75qQg8rozAk/Aho/zSbzAYtGKwFjPg0v2x X-Gm-Gg: ASbGnctpzP2FVWABf9uQcUKRUBoHCLUv5HbqBO+9O3QWptvvDrYWYec+8VufA1DBHR1 0pbWanA7SEMeNxJmNdtsHbj5/6DyaL6/zGJptHpYie8GwXF3CSxFyNVh6qbGECFivi9/jxdtybS OaZ9fYeKtjXaem3u/3boDQFgOpsmBzk9JhfYiHzftqmCm5HXema89w5BB0jLZcAwVRdGyTvsXuv oYJAzz4qP5dbKGb9mpRSpl6Fm8cuwemzJlbomJ6ox9uYagBCo5qYgepa9cAr9PElPzNHEWQtH4l 8JYNWJmOvv8RHxkUWdkJc4vdVjDwm+oL/53nIhYIwQ68hUHamq/OWZ/gnKye1g== X-Google-Smtp-Source: AGHT+IFQTEpAwXkhDKcJd2Civ8ezQlDCDxM2AVWY9CCxR7LpFEe6jtx4UHnl03vBjg7BNjYYxNKBdQ== X-Received: by 2002:a05:6000:4021:b0:3a1:fcd9:f2ff with SMTP id ffacd0b85a97d-3a51dbb3391mr5327763f8f.12.1749130026081; Thu, 05 Jun 2025 06:27:06 -0700 (PDT) Received: from [192.168.8.100] ([148.252.145.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-451f8311ae6sm16366935e9.2.2025.06.05.06.27.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 06:27:05 -0700 (PDT) Message-ID: <342e7df1-ea55-416f-9f4a-2712d4087b24@gmail.com> Date: Thu, 5 Jun 2025 14:28:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v4 18/18] page_pool: access ->pp_magic through struct netmem_desc in page_pool_page_is_pp() To: Harry Yoo Cc: Byungchul Park , willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com References: <20250604025246.61616-1-byungchul@sk.com> <20250604025246.61616-19-byungchul@sk.com> <390073b2-cc7f-4d31-a1c8-4149e884ce95@gmail.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1C32DA000A X-Stat-Signature: h7cg3fesxa5q5qm6cq1nmbhft7qybw8w X-Rspam-User: X-HE-Tag: 1749130027-177192 X-HE-Meta: U2FsdGVkX1/MR1S8SNNlAkCeFScuvLdkjk5i+pQs4UVVRtOq6WT5yHeQn9Y3yJNwElK4mOj8gjF0bVxv0tBE3IdpMcIlwrgjNJJAj8lLCVblK9y1/x3yHo0YR4+egbceJjSp5HeS30t019fZgWmhL3m5aZ+10Wvda88Lu7UR0eUdoybtGReNLrlAsVtYp2/gOITTA6rXBRIIe5+bhovph6A1iVJG7sw+mMv3s5jGbomOUvkCIUrhnYlqCvhB+hPkCaXambZA3q8gXKmk8ZBY/rwLvdiwCRDyyI21Q1dp+PQ3FkvfTih8KItQ29uPlO4Y/s/rBSKsF5weZWG1yrDqDp1e92id8e72D4dYnAyaQdn+TWseW6VLDxtrJ2KyBiMX5h2Qv6nnqGoGQaMLAKtq39sZE5Xw+kwCrGgvSheXFhGIwrMeMa25TizoZJMz4JTUK8oRmCcKtAhviMfWe73hEzLmPt0rsS+JgYtMftKGvCoMcRAUUYZMej6EzVLbJGsAABoRGJIrtLwNFcc4K31p/7K3h4fhHDs8nqzNhV4WTXjey1D3S/Zc/ilmuRR10l3RSNCYdea2qzk489SCNq3d1caFlqEyk9QLjlFcEfobGP+11a5QatYVEE9HqwnR2zXJ/pI9xyz671P1pMUKc3aTVnGtnvMmupKYxYw1pB+zSiVp6BejfW87oJsytXcOtP/zXC1CBX+I/W6f3hVa0tAI7Kj6iyc4dzTTzPWWUswXE5IqJxa+UEIVc6CezFBPd6QEUX+VDwywYpZKZYfzazhQg1qBCpzuhUPLjAv+Bm6A1pxnU7niq7klSsoegL16pmNewAp4/NQo9rBhXK6PC2zB1AIvqjhyf0vu2aGbH8FpgVO8JBcyVeWZo8mGTE0zfDEWCPvXoLN57qwdz338Lu5G9UEhOQq9oT7wwKx33k92swV/zx9MV+0PywrK7DSMs6DpZcI7TGAiEmuFtlKOfC+ wtLnYSZj GbxTknr8E5VNk9vNABpHO+5e4CrEfQXhoguysf5O7vHGzm+gQcwZe6DLnJtToJfuQL3dwob8buR6IP51tbOCru+gpU+pvRxeZzlPRA7S3ioc7YekutOIYXJ93p+ALB7NaNwEpv5vlvpM7xaRzzH1wOq/T1PPKN/ywBn4FvSh5PWoNkWPwnAVDuuksbtM+EDH4b5/N9Ci0N4XC85dAPy2HSq++bF7a/AWHpBmGchLci7akDSTa0XDWx+V1W33AxhYv2pTSrkqoZJLgMs7Ctf0lANnBqZ/hwyuxCUH0hpsQWkmTS4IK8yYmBCeTpYPCclOVdHDFOfsb1MLCgTeIJ1njbVl8bs2mkHw+YvIosmtzVXuCndps9OwWQT2W2M3W7gh9fkryKe6/GZ+I1Rhtf/bx7S0Ja2Y2EjIg+MuQwu+Rh/8mHf1LDUu3SlGhRS80/r+PfVsMwrjOlvYtVSTMDAIJ2kKqdY7bmr7SKLdNxtbD/7RUqzC8vdHIVF3/mIq1SMe9FoSZ9Q0va/pmK1FRsnA4vlFn9w2hsqp9FkLeJJsk6fs/OcKyiej+cILZkdO2PE1nJYxBp8+WM4x/OlI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/5/25 13:17, Harry Yoo wrote: > On Thu, Jun 05, 2025 at 08:49:07PM +0900, Harry Yoo wrote: >> On Thu, Jun 05, 2025 at 11:56:14AM +0100, Pavel Begunkov wrote: >>> On 6/4/25 03:52, Byungchul Park wrote: >>>> To simplify struct page, the effort to separate its own descriptor from >>>> struct page is required and the work for page pool is on going. >>>> >>>> To achieve that, all the code should avoid directly accessing page pool >>>> members of struct page. >>> >>> Just to clarify, are we leaving the corresponding struct page fields >>> for now until the final memdesc conversion is done? >> >> Yes, that's correct. > > Oops, looks like misread it. If by "leaving the corresponding struct page > fields" you meant "leaving netmem fields in struct page", no. > It'll be removed. I see, in which case instead we might want to leave a reminder in page_pool_page_is_pp in a form of a build warning, but the patch looks fine either way. -- Pavel Begunkov