From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B4BC5B549 for ; Wed, 4 Jun 2025 11:33:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C286E6B05A8; Wed, 4 Jun 2025 07:33:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB2446B05A9; Wed, 4 Jun 2025 07:33:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2C6D6B05AA; Wed, 4 Jun 2025 07:33:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7F3C76B05A8 for ; Wed, 4 Jun 2025 07:33:36 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EE2CCBEB0C for ; Wed, 4 Jun 2025 11:33:35 +0000 (UTC) X-FDA: 83517507990.21.669DAC7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 928798000F for ; Wed, 4 Jun 2025 11:33:33 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=idg5KZnk; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749036813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MyQt2johQWtxMYuAwwY/HHR2S0j1U3CDI1ooJIdEYRU=; b=gN4FlDCI9CTp6QAGrf60pPgADN9LuzquEzcbVcpbXdVRhE1fWuicytR52VtIvthldI1MxW F9rh0EGKmdvvuagpkeTjcvVKnPEW+Fp0zfNV1wOWo/0WC64ZIwYQwcQzBc8U+ZcmKGNUPH 1A5tRTw8U+vW4cfwnqewlE5x4Ht/ck8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=idg5KZnk; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749036813; a=rsa-sha256; cv=none; b=f/CH+NxXyoe9ksVjJ/L4EllpO77ZrVxanPvd2iESBa7ia+GxSaU+P31tX87E0j2i1AcQxV 8R1ddRIqd4f3UJFySYZHNd4kPu0Q9Rmhkx1LDA3uN9e0ibI4ohgQF0D1+c3MypAea3jLsA IDzo7OaOj80ZFLMsdy8fkpYFjZ7ohHA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749036812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MyQt2johQWtxMYuAwwY/HHR2S0j1U3CDI1ooJIdEYRU=; b=idg5KZnkbJ2UvgbOL0ZUPKLZPK4GOscdsuGcTM9scVpP1pnRdnHBj+Jbg/SLX1/yzrbrHU b9/Duy0N4BRr4JZk42UTIudlXdP+xis7AFRV4F1nTqNG6VSiN/ZzerWOlQfGMTDPRQMyyR F6GkwFX2kVUyQnI4L70auTL3++xLkTQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-547--D6t1UcsOjWN5neNNIF77A-1; Wed, 04 Jun 2025 07:33:31 -0400 X-MC-Unique: -D6t1UcsOjWN5neNNIF77A-1 X-Mimecast-MFC-AGG-ID: -D6t1UcsOjWN5neNNIF77A_1749036810 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-451ecc3be97so6752055e9.0 for ; Wed, 04 Jun 2025 04:33:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749036810; x=1749641610; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MyQt2johQWtxMYuAwwY/HHR2S0j1U3CDI1ooJIdEYRU=; b=BVlurg+uCs/+EyEfpI/ELU3BM1RQoTCjwjRypvYPhuQotDhk14b/n5qcmu3h/qTyBr 7uV8A2PEEqp8d9L29YJ06ZfXSSylufYNaBnZK4EWAn10CBtDGED01flSOKJSpmA8GdU5 vGzDVHhnsiA3EvpILJSZODyfxTpU6F5kknkzuCdxK/c1yd2vr0jdlHM54SxKr1wnkLXr uRmdJG0vCrRUnHP/OP+6sAUeMhUaHIzIQwsjijQSEDPaN9Xu/xEgd6E1kcPYT+jiUspD 9smUw91/UOsSU4xlI5cpYlxwjSfDvLds3LHsJ6mmXGijhCx6nS5+8JUNTODvDrNiCmHE DvQw== X-Forwarded-Encrypted: i=1; AJvYcCWcHK3zlTS3DtU3yRBHqGzffvRSE4F4gShB2p0uteizhwSGxCbFSLi6Tn1XPp/mh3QAt1okMdB9Bg==@kvack.org X-Gm-Message-State: AOJu0YxsUFD5QiQL0YQwjWs7/h05l34wm3AWRQH9CpgL3H4hp9NVke3F nirDL2Zp4DPogxelBvbLMPUdaYdD5L+M/9boihLlUjnLGKdKPIEXV0MzbJoij6DRAKwSKAR7OZF e8Q5jxrzlCiLxugnTrfEDApuA+SOqB4qUOKDT3SRNvNrntdQ48E50 X-Gm-Gg: ASbGncuk4g/7Z4c/4FKZoJU9itcExznoRwtW0PB5VCnXyK2stPKnp0WUN3spIPgRLlq fcnwJ17lW2WyFGVH1H55MTFShmxeKHyFc4Yju/dj2SBhvrJvBwhAh9RR61IamrQ7Feqz8g5txVS Vj82pvt0CDXUmnIapbpBn+rJW0PHE/Tx9yPzsVvt9dhNvevPUqkRadaDU0Qq6CC1r33uZzpuLLv rRQDpZw6OpLez1cxjbduOBGTd21Xbhajdi7lbZAeRmwEuSIrtb7l0tZBBi4EBS/rQRwhOcHj7XU UDTTmHnxsgK1h3gdCcV/ZVwSWzSEq9i645q8/JbZCyHOcJ7XKPhCHCHk8+J2FaEN5oTFw0DG7rp +x/hLzMtqxTYl8uJqu8tcLoTfh5KSF4dR+5gNYyE= X-Received: by 2002:a05:600c:c1c8:20b0:442:f4a3:b5f2 with SMTP id 5b1f17b1804b1-451f1680284mr11866485e9.6.1749036810422; Wed, 04 Jun 2025 04:33:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFqoVz0lYNaMYqWzIIYfW1H6uv753TnaSi4WlHH20770u7Q7XE9I797JmIASn0R6pSoBimJHg== X-Received: by 2002:a05:600c:c1c8:20b0:442:f4a3:b5f2 with SMTP id 5b1f17b1804b1-451f1680284mr11866275e9.6.1749036810003; Wed, 04 Jun 2025 04:33:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf? (p200300d82f1bb8006fdb1af24fbd1fdf.dip0.t-ipconnect.de. [2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4efe5b87csm21787067f8f.12.2025.06.04.04.33.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jun 2025 04:33:29 -0700 (PDT) Message-ID: <34584ae6-473d-4cf8-923c-3a8e7f16e8ad@redhat.com> Date: Wed, 4 Jun 2025 13:33:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] mm,slub: Do not special case N_NORMAL nodes for slab_nodes To: Oscar Salvador , Andrew Morton Cc: Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250603110850.192912-1-osalvador@suse.de> <20250603110850.192912-2-osalvador@suse.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250603110850.192912-2-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yz-Nj2XTNyzGChpdszPDrcACSSb1_GeStS8FLhSJBY0_1749036810 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 928798000F X-Stat-Signature: 6t6qom4mfuhzazzmj5a4fk3qnpqpxk93 X-Rspam-User: X-HE-Tag: 1749036813-727192 X-HE-Meta: U2FsdGVkX1/JRItkyMvnr9OTNG+jl/rK+RepQh+KsCYSXdG/24tsdomqxGCveFZtPGV29k76h5xtAsX6wDfj9OBbu78hKWoba5NYfP+1czL/S1VBsn5wa7QB5okOolfeseravr8LjhU5D1jRCm1dRREZICZ+GwtclWVm+C07iWAedtngUp9Jg1yry6OESRmJMn1soep9pyPWDmKezT0iBKlMRzIhEC5cmKb68foblrucU0Dydld0WWWwRqu4KwO2BjYulFGKKMOXoO3bIpQkJiaAOJnsfvhbB7BUCWWkBJtF1UfX2vm4jJQgd7NYTAxEAUEa3CyBocUalA8MklB5VUXe/eumvFKEgqjhRCM+jdxJVOBN3rcBbn983fuRIfj7wG72oN9E07VUAf1RtbrNpjdd+n2xs6Aof/fiqyCWa27AHEh2Y7qHs2Fl+Kjvi0EZqxG3C4RalXp6DGERCKddPTfJBk8hTd+g6ut2vW5TwzgaStvKKQah4d8V+f6/zPWytU6ePYr3mc8wboOOu7APc3szI6xjnmSeu+hcAMCW7MTfrLlsezH6BYzGSw/rjnYMFHhIoi7AIKQtdNryWneEhGa0FsYJkmZEolFogp+OpStzLfX8Ef+ZKXCLrJqEOZ8LXQwr8kms1dkzn1IuDSm6F0qeuB8B+HPLlAFFAElHsuN9scYwZ2/EayDhOV5IsH421ijc15N4VroU15Zs7o0z4Wt3GHR0uWgyvz4rZn1V0Ipyvp5faSHJbZCwyivMg0a+7CTSVFmIzXZG76tfI8wuEKi8PCfBDhswuy1kAc/enQtbB3LJcUsRIGYQQ2GByU/cPsIN2rHQpdQPc5GFsHA6AZCrhKpE3fGcCcliCxKZ5aI7b/3zsVa7mX5qHl1+8BA4rGrWkD5NAoQXuDHisCXuz34YTZfMwMNmd1LByqkS2vJkAA0SB3+B7ri5PD1fXhyKNbq0L+aVXi7v4mAXt9q 2IcHgy/l P7P5wkojc/L0NPf6GRkuAeKDt5sxcgCnMXY2pylhg/eIk7ShgUqRrqK6buYfriISY6uqr4zBeUEnRGp8ZoDpuiFrEfrRXZQKGgQJQr8PvmSeRCrtWnrzpjrT6iz4Nb+zPIyeWerTMmT6e3BMXUEdvOZgX2D2fnUdFC/ySwSXSzqKQNjxQfWTKs8yFcI25TjrN2t+V X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.06.25 13:08, Oscar Salvador wrote: > Currently, slab_mem_going_going_callback() checks whether the node has > N_NORMAL memory in order to be set in slab_nodes. > While it is true that gettind rid of that enforcing would mean > ending up with movables nodes in slab_nodes, the memory waste that comes > with that is negligible. > > So stop checking for status_change_nid_normal and just use status_change_nid > instead which works for both types of memory. > > Also, once we allocate the kmem_cache_node cache for the node in > slab_mem_online_callback(), we never deallocate it in > slab_mem_off_callback() when the node goes memoryless, so we can just > get rid of it. > > The side effects are that we will stop clearing the node from slab_nodes, > and also that newly created kmem caches after node hotremove will now allocate > their kmem_cache_node for the node(s) that was hotremoved, but these > should be negligible. > > Suggested-by: David Hildenbrand > Signed-off-by: Oscar Salvador > Reviewed-by: Vlastimil Babka > --- > Acked-by: David Hildenbrand -- Cheers, David / dhildenb