From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03F49C77B7C for ; Wed, 2 Jul 2025 14:51:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 976286B00CC; Wed, 2 Jul 2025 10:51:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 926466B00CD; Wed, 2 Jul 2025 10:51:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 815C16B00CE; Wed, 2 Jul 2025 10:51:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6F2D36B00CC for ; Wed, 2 Jul 2025 10:51:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0A74158EB0 for ; Wed, 2 Jul 2025 14:51:47 +0000 (UTC) X-FDA: 83619613854.28.984F5EB Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf14.hostedemail.com (Postfix) with ESMTP id 1559A10000C for ; Wed, 2 Jul 2025 14:51:44 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jlFTIYKV; spf=pass (imf14.hostedemail.com: domain of chentt325@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=chentt325@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751467905; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qBca6/tX4UaiNS88cVzn9ejTz7Ui0nOCiCDYDy5kH/4=; b=5wgaQ59FB2XOPqySYsq8jRKisN6tL3fvpFXwyCbYP+NLNHSFzcumlr2FDBv6/tEhjsuc7Z +bNweXVvA18g0ona6E9e2hNTdcUojPyoT/dv08qih2TpNQvWqF0om+2WbsREN8CnARQHrI IhS4NZ5SMR7O8MwJlxlY2ynQO2kbfmo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jlFTIYKV; spf=pass (imf14.hostedemail.com: domain of chentt325@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=chentt325@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751467905; a=rsa-sha256; cv=none; b=KMgnIKGewIPKeu0TtCCVb8iQrpL74EF2JmCQD6A5wFjQk9Vd44mQluenC+pNzfnhJeAHyq n5fbaRZvpVryXlqf5XB7ZSkB8J/tWaEdBpoKtbpVZjimrsbQgKDAsaaeEJ3KWckXOEt8hZ LWDbGVP/GV5gi08Zoy3keJIkE6u3+Ao= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-235f9ea8d08so63894065ad.1 for ; Wed, 02 Jul 2025 07:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751467904; x=1752072704; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=qBca6/tX4UaiNS88cVzn9ejTz7Ui0nOCiCDYDy5kH/4=; b=jlFTIYKVQTXapE1VKmtgXNOSf2tTySqhmeFZvObHAqRte+WPLNLjiRYEhqW/s8YM/Q l3/5bZXj7XBsAMg/FNdzedowQiLgfSWbrocZtZteK4RAlSWt/vNEik1fax/dXMBYnXqM lzpyTGOQvvRnn6Ch135mfoT/3rPr3A0W78qNZf5daBIKrvtXoOfhMC1ExCXp/IyCMY4V ebwzFTN/6lc3v3TXwxJvPP0tTqRfT8F6pumx9JSLGeP4rpBgvnvztPWKuQQr68+JA9p/ 1hBYy4pZTXhDmRIQQbmkuzKlH8u3kVuhx3QUNomVG+SHDfHcSOU6sqRHMBjBLMk0yrXE r46Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751467904; x=1752072704; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=qBca6/tX4UaiNS88cVzn9ejTz7Ui0nOCiCDYDy5kH/4=; b=fHlLJ/Gx1Y4c1Ag2mmsGyInDSrHlkBw6YVIa9aYReHNdspHm7lutyAzZvIP90/b2BQ g6h+MJ0U48+544bYN80i4aW/eypcpVlVs3byWntechlvpKeHv3jzIXewfe9W/4dPONNF WO7O8v6gcQ/YecannpgKT/3ZrRQIJ8GooHZBC5eRdqCOo2GxX0D6kBHw8ZsbOdblh5Zh nqosU7/LXlv2/Zjnl+IFkdoTbnnD4uKoy5yohCCwhPYqus3zxv/iCSJmJ4RLFk2FwF3D bJyhRhlrQiO8TxQu20pGQfGE2gQk9IeMROeHuwRaq9UKmt+lQDOzlTn8OCr0V4YtCZdz MYFw== X-Forwarded-Encrypted: i=1; AJvYcCUTY/AQIsSAZttOyKliMQwEq610oZSxbZGTwPW7F5OF6Qz1SOIujDH7AEMVOS2T31XhW8ypUCPuVg==@kvack.org X-Gm-Message-State: AOJu0YxxewgJvCfvmtGNrp4yI9lyrmGIgk/9iDiPqtH0TMzsVTgShZUK uxDuQS01woL6racQgdlkJ4A6WZD8eInr6cR6DaZsi8onifl74RxVKE8F X-Gm-Gg: ASbGnctHkUlvzM/Mbo+1XalQfCnu/T/n26uUk6w5Oh/WM50raqT3zJVlz+D1653hHn3 HYd27a6uqNhUNYnc/DwMvAQ4fsz4CH9FrzBnkuWYU9pkL7ucKgSjwpXjGxCztiw5E/0RlQEdnQB g/UuqvNJcqOaSf2oYd1MbBqNKcrXuJE0usrLaRejyO/Cycz6ZgRJroY1EZkdFVGKVcnmkKdN+br TA23JLtgfRhiT6qA9hJUMedKE4tSv4Lza1UHxyErZxsGuOCRnnKGlpsoh3CkAPyRjqZEZD9bytN OSS3Qs3QtHfdnHKl24UkifLjrSTYL0WqBjOawiBWCxxXHiQejpa7v0JAkqDvIBSZZiY4NoHJvRt qpHvAW53AaHNaXawxpaEmfSA09nYVWb30RWfRgMw= X-Google-Smtp-Source: AGHT+IHGXFFKwi9KhnB1akNKraPfzeJ2zmSUqQqb7SzFIxYzfjGRA13Y+veDJQIEsP0m/DU4C4O2oA== X-Received: by 2002:a17:902:c94a:b0:232:1daf:6f06 with SMTP id d9443c01a7336-23c6e5d3a53mr39666775ad.47.1751467903710; Wed, 02 Jul 2025 07:51:43 -0700 (PDT) Received: from ?IPV6:240e:305:798e:6800:81a5:8e22:d9f1:ac68? ([240e:305:798e:6800:81a5:8e22:d9f1:ac68]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23acb3afc94sm138573955ad.155.2025.07.02.07.51.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 07:51:43 -0700 (PDT) Message-ID: <34b3f8f1-5adf-4f82-8d06-b906cdf0552d@gmail.com> Date: Wed, 2 Jul 2025 22:51:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] fs: change write_begin/write_end interface to take struct kiocb * To: Matthew Wilcox Cc: "tytso@mit.edu" , "hch@infradead.org" , "adilger.kernel@dilger.ca" , "brauner@kernel.org" , "jani.nikula@linux.intel.com" , "rodrigo.vivi@intel.com" , "tursulin@ursulin.net" , "airlied@gmail.com" , "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-block@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "chentao325@qq.com" , "frank.li@vivo.com" References: <20250627110257.1870826-1-chentaotao@didiglobal.com> <20250627110257.1870826-4-chentaotao@didiglobal.com> From: Taotao Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1559A10000C X-Stat-Signature: nouftngt591xjjstzdtrr9uxb731qfk6 X-Rspam-User: X-HE-Tag: 1751467904-122935 X-HE-Meta: U2FsdGVkX18sM57feZIgzkIdI8YWENt/ujfg9P1576y7zv8/oHQc7bRzxNw0r+G/MccUKqNJhXUK3JhSy9irLv7TOchIy+S2A9Ot8huVaZrwQDZiJaP+aBiY40bXE9ETG+8HjqPxqkVzIyrpEau3UpdIoMFJeyYn9vcXhMQfz8IgEDTDZ6O64KlFO3oJRYhVstjWubeSh1JIQjMwAHqi7k1vwDXGzLbVwR7LSSHVWVNr1RbvdvDY78OLBp1zDtOW/wB+Fwjm5HLUq1kZ4RE52xReU3fr3ckrpSvVkvWa0v7l/6SahoBdiOtyp9npJkH3lJ8FqxuF85kAtXGoqunaqu3ysZGxKi654NmhsVjvzwwPcoeY96keBDt7DONx8aUr7wv3R3uVPTWXJoOPpHsmOb1rOrGhMQ2c73aX72Zo/DMhOqZWt5fEl3LSQMMyBGvHfIab+/gYllBAbTgZrp4pb3OAZuI9lTPrEkl1aCC5kKdNbtdPN3/TepatBxll+o4JsaDR95UHkzQsgldgJfatdc59tq2Zgwkk+PE6kDqBiAnep3zt7KVkcQPOlCjEvY1MYsZeh94VF85LJAizicCj8HU29HkqAY9aQDwgsVm1Or7X4XS/bpN6dQ7yh2MMe4a48N71bJFWxqjvzJx+d1Ee7/c+AYDC1fN0+Pejsz7rQOL+ROJKyx1wzhVthEYiL4jZPSw3M3UkIUjlRKpoxjvWBBem4QOtUoyHzAII7kKwUx29LDh0rCBdSuEynv48ixB3u4UZBwXNafO0oSKjfpHcquTjc6KkWwchzzEc+Xa88mQGOjhEFmlKM810muS6IKWj/SNzltghlBN4mTgifrOZY35Cwl2Fj970niiNE0cLTMDxTkDQDm8K1/DMhrM9IYXEeHKhM6+qJ15Jm0aCoyFVj8Dcpz3egrc/7KnrBhpwqekFb5NX7ZLOtDy5U/a/PAu+VgOC4PU9dVskmwuJ68n ig/ZeneF JVhjuoPtqRUnHv1CaiGlu7bs6zA0Ios87fdgsxBJat8PwS7z/YU2umPLU8khSqGNfRcYyd0M3ApGlOcMuwnv9n8DkEXxNgVMPYRInclZQ08UAOtDLOYp9C+33Wxo3Z3AR0yD07eiWUfmqVarf49gFnVsly74iAemkKeyWTLF8ZYfP0svkiMl8F1qeZTYf2lDVVmvGIEjchSlSFMZSDKJdG7RN8+/3SAAdO1hCbW5ZdPSGv5vL1MZqVmGOBPcJIa89yMB/UP18MmMtQmLsbVuh1UWvxbtG6/rwFrFxAMyv+Wiqd8YMoCKrI8wpfQMxOU7Ef5XWLVF66KzkozmEyR2YjmkvHchtSa8vBzgqOvlqeL+pwK9cTVRa9cBxaBaI7fERLHgVxBg5qQfNFpZ8h7+eXgsrqdJIpft6NQt2Ck2fT8FhpY0aAfWzq/jA6ttHVNrcUUiTPwiKjtyBN2TgZy/69IeLw/N1qSBfNC0aE1BfBTWr/MFEI958pq75za9rfoPQkkCiFN6VHxgGma/zqTHTYVUzW0RNAJSh3YbR27fe4wiiMyjLaJ1skgzSrPh5sC72NdrTtzjvMqrCfQ2wUxVST3ESsFxVCvBMI8/H15HEBQRUCef4cxUWrjK4YLlzXdsTMdQ1NXd1plWXoTs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/6/27 23:52, Matthew Wilcox 写道: > On Fri, Jun 27, 2025 at 11:03:11AM +0000, 陈涛涛 Taotao Chen wrote: >> @@ -1399,13 +1400,10 @@ static int write_end_fn(handle_t *handle, struct inode *inode, >> } >> >> /* >> - * We need to pick up the new inode size which generic_commit_write gave us >> - * `file' can be NULL - eg, when called from page_symlink(). >> - * > Why delete this? It seems still true to me, other than s/file/iocb/ Sorry, that was my mistake...