From: Pavel Tatashin <pasha.tatashin@oracle.com>
To: Oscar Salvador <osalvador@techadventures.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
kirill.shutemov@linux.intel.com, iamjoonsoo.kim@lge.com,
Mel Gorman <mgorman@suse.de>,
Souptick Joarder <jrdr.linux@gmail.com>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
osalvador@suse.de
Subject: Re: [PATCH] mm: make __paginginit based on CONFIG_MEMORY_HOTPLUG
Date: Tue, 31 Jul 2018 17:33:27 -0400 [thread overview]
Message-ID: <34d9fff4-cc29-8c6e-42c9-48c4467b6a74@oracle.com> (raw)
In-Reply-To: <20180731205003.GA3277@techadventures.net>
On 07/31/2018 04:50 PM, Oscar Salvador wrote:
> On Tue, Jul 31, 2018 at 11:23:33AM -0400, Pavel Tatashin wrote:
>> Yes we free meminit when no CONFIG_MEMORY_HOTPLUG
>> See here:
>> http://src.illumos.org/source/xref/linux-master/include/asm-generic/vmlinux.lds.h#107
>
> Oh, I got the point now.
> Somehow I missed that we were freeing up the memory when CONFIG_MEMORY_HOTPLUG
> was not in place.
>
> So your patch makes sense to me now, sorry.
>
> Since my patchset [1] + cleanup patch [2] remove almost all __paginginit,
> leaving only pgdat_init_internals() and zone_init_internals(), I think
> it would be great if you base your patch on top of that.
> Or since the patchset has some cleanups already, I could add your patch
> into it (as we did for the zone_to/set_nid() patch) and send a v6 with it.
>
> What do you think?
Sure, please go ahead include it in v6. Let me know if you need any help. Thank you for this work, I really like how this improves hotplug/memory-init code.
Pavel
>
> [1] https://patchwork.kernel.org/patch/10548861/
> [2] <20180731101752.GA473@techadventures.net>
>
> Thanks
>
prev parent reply other threads:[~2018-07-31 21:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 12:45 [PATCH] mm: make __paginginit based on CONFIG_MEMORY_HOTPLUG osalvador
2018-07-31 12:49 ` Pavel Tatashin
2018-07-31 13:04 ` Michal Hocko
2018-07-31 13:17 ` Oscar Salvador
2018-07-31 14:41 ` Oscar Salvador
2018-07-31 14:43 ` Pavel Tatashin
2018-07-31 14:43 ` Pavel Tatashin
2018-07-31 14:45 ` Pavel Tatashin
2018-07-31 14:51 ` Oscar Salvador
2018-07-31 14:53 ` Pavel Tatashin
2018-07-31 15:01 ` Oscar Salvador
2018-07-31 15:06 ` Pavel Tatashin
2018-07-31 15:23 ` Pavel Tatashin
2018-07-31 20:50 ` Oscar Salvador
2018-07-31 21:33 ` Pavel Tatashin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34d9fff4-cc29-8c6e-42c9-48c4467b6a74@oracle.com \
--to=pasha.tatashin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=jrdr.linux@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=osalvador@techadventures.net \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).