From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04A2AC433E0 for ; Thu, 21 May 2020 00:57:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AFD2220756 for ; Thu, 21 May 2020 00:57:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFD2220756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 454B680008; Wed, 20 May 2020 20:57:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 404DB80007; Wed, 20 May 2020 20:57:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A6B780008; Wed, 20 May 2020 20:57:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0018.hostedemail.com [216.40.44.18]) by kanga.kvack.org (Postfix) with ESMTP id 0EA6B80007 for ; Wed, 20 May 2020 20:57:49 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BBAD64FF4 for ; Thu, 21 May 2020 00:57:48 +0000 (UTC) X-FDA: 76838913816.24.suit29_61279c40b5015 X-HE-Tag: suit29_61279c40b5015 X-Filterd-Recvd-Size: 5891 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 May 2020 00:57:47 +0000 (UTC) IronPort-SDR: hqB6arWlFBK5QgUs9VTmAC+A530HP32J6mMificRbdU5gH28ail92pbIlA/AXX05Gl/GmIyGye tkO0s1gjJ6aw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2020 17:57:46 -0700 IronPort-SDR: bldxTWCgWAoyH8oiLNLw6lj3s5+MshcHGXkRtmJJFQW+eR8h1fc52+CKeMFGbb+LNmp3wfGzny NZ9XoMZdDAnQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,416,1583222400"; d="scan'208";a="440249878" Received: from shao2-debian.sh.intel.com (HELO [10.239.13.3]) ([10.239.13.3]) by orsmga005.jf.intel.com with ESMTP; 20 May 2020 17:57:42 -0700 Subject: Re: [hnaz-linux-mm:master 380/523] arch/riscv/kernel/kgdb.c:47:5: warning: no previous prototype for 'decode_register_index' To: Vincent Chen , Andrew Morton Cc: kbuild test robot , kbuild-all@lists.01.org, Linux Memory Management List , Johannes Weiner , Palmer Dabbelt References: <202005191618.9XxheOor%lkp@intel.com> <20200519190521.d19192c75279e5ca95209bc9@linux-foundation.org> From: Rong Chen Message-ID: <34dc406f-e7f5-53b5-3b18-d3b34fe5fd68@intel.com> Date: Thu, 21 May 2020 08:57:22 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/20/20 5:00 PM, Vincent Chen wrote: > On Wed, May 20, 2020 at 10:05 AM Andrew Morton > wrote: >> On Tue, 19 May 2020 16:44:22 +0800 kbuild test robot wrote: >> >>> Hi Andrew, >>> >>> First bad commit (maybe != root cause): >>> >>> tree: https://github.com/hnaz/linux-mm master >>> head: 2bbf0589bfeb27800c730b76eacf34528eee5418 >>> commit: 91cd0b1b65c463042fdeb4ab5ffcb64ae43179cf [380/523] linux-next-rejects >>> config: riscv-allyesconfig (attached as .config) >>> compiler: riscv64-linux-gcc (GCC) 9.3.0 >>> reproduce: >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> git checkout 91cd0b1b65c463042fdeb4ab5ffcb64ae43179cf >>> # save the attached .config to linux build tree >>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv >>> >>> If you fix the issue, kindly add following tag as appropriate >>> Reported-by: kbuild test robot >>> >>> All warnings (new ones prefixed by >>, old ones prefixed by <<): >>> >>>>> arch/riscv/kernel/kgdb.c:47:5: warning: no previous prototype for 'decode_register_index' [-Wmissing-prototypes] >>> 47 | int decode_register_index(unsigned long opcode, int offset) >>> | ^~~~~~~~~~~~~~~~~~~~~ >>>>> arch/riscv/kernel/kgdb.c:52:5: warning: no previous prototype for 'decode_register_index_short' [-Wmissing-prototypes] >>> 52 | int decode_register_index_short(unsigned long opcode, int offset) >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>>> arch/riscv/kernel/kgdb.c:58:5: warning: no previous prototype for 'get_step_address' [-Wmissing-prototypes] >>> 58 | int get_step_address(struct pt_regs *regs, unsigned long *next_addr) >>> | ^~~~~~~~~~~~~~~~ >>>>> arch/riscv/kernel/kgdb.c:139:5: warning: no previous prototype for 'do_single_step' [-Wmissing-prototypes] >>> 139 | int do_single_step(struct pt_regs *regs) >>> | ^~~~~~~~~~~~~~ >>>>> arch/riscv/kernel/kgdb.c:276:6: warning: no previous prototype for 'kgdb_arch_handle_qxfer_pkt' [-Wmissing-prototypes] >>> 276 | void kgdb_arch_handle_qxfer_pkt(char *remcom_in_buffer, >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~ >>>>> arch/riscv/kernel/kgdb.c:323:5: warning: no previous prototype for 'kgdb_riscv_kgdbbreak' [-Wmissing-prototypes] >>> 323 | int kgdb_riscv_kgdbbreak(unsigned long addr) >>> | ^~~~~~~~~~~~~~~~~~~~ >>> In file included from arch/riscv/include/asm/kgdb.h:109, >>> from include/linux/kgdb.h:20, >>> from arch/riscv/kernel/kgdb.c:9: >>> arch/riscv/include/asm/gdb_xml.h:7:19: warning: 'riscv_gdb_stub_feature' defined but not used [-Wunused-const-variable=] >>> 7 | static const char riscv_gdb_stub_feature[64] = >>> | ^~~~~~~~~~~~~~~~~~~~~~ >> I doubt if linux-next-rejects caused this error - all that patch does >> is fix up a reject between linux-next patches and >> https://ozlabs.org/~akpm/mmotm/broken-out/riscv-support-debug_wx.patch >> >> I'm more suspecting that this error is due Vincent's e4f2aa5808fc9 >> ("riscv: Add KGDB support") or 899dc734805df ("riscv: Use the XML >> target descriptions to report 3 system registers"). >> >> > I tried to use the following commands to reproduce the above warning > messages, but I failed. > 1. git clone https://github.com/hnaz/linux-mm > 2. wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross > -O ~/bin/make.cross > 3. chmod +x ~/bin/make.cross > 4. cd linux-mm > 5. git checkout 91cd0b1b65c463042fdeb4ab5ffcb64ae43179cf > 6. make ARCH=riscv allyesconfig > 7. COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv > > Could you help me correct the reproduce steps? Hi Vincent, Sorry for the inconvenience, it's a W=1 build, please download the new make.cross and it could be reproduce. Best Regards, Rong Chen