From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20BB7C4338F for ; Fri, 30 Jul 2021 09:17:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AE3A46101C for ; Fri, 30 Jul 2021 09:17:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AE3A46101C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 25FD76B0036; Fri, 30 Jul 2021 05:17:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 210506B005D; Fri, 30 Jul 2021 05:17:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1265F6B006C; Fri, 30 Jul 2021 05:17:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id ED6B46B0036 for ; Fri, 30 Jul 2021 05:17:26 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A06C58249980 for ; Fri, 30 Jul 2021 09:17:26 +0000 (UTC) X-FDA: 78418700892.38.EA90ED7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 405757001F7B for ; Fri, 30 Jul 2021 09:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627636645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/zY1bTaUTwe02HOCyGjtvAnuXlFEWzzopPrkJZBvT6Y=; b=RmVj6FnP1sV6VTF7McBdNooZlXos8FhCFwP2qoQO/FseXp8WIgvV7BOIFDRo6zgPho72tO OcMPGO5MoAz9n1Sz0LLTHZYs7t0m+myTszqYHgnwPxKuzAR0QnburEwvz4yd+GCsFjCaOl HvjtbvYt1zL58Eq0vaDHR69TDsFp/E4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-354-RBtbXz_jMQSFVvJ7Gi5dfQ-1; Fri, 30 Jul 2021 05:17:24 -0400 X-MC-Unique: RBtbXz_jMQSFVvJ7Gi5dfQ-1 Received: by mail-wm1-f70.google.com with SMTP id a197-20020a1c98ce0000b029025831695a2eso582672wme.4 for ; Fri, 30 Jul 2021 02:17:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=/zY1bTaUTwe02HOCyGjtvAnuXlFEWzzopPrkJZBvT6Y=; b=AIzo/+/Mv2Fx25rNcbRQtGP3ifFHCdPGyhYPZiHspy4OW8dYTIfcScpzkp3ooiKIyb IlPicu3B1RVZIZTNCUi7jjjfwLqBAFeGi75CV7OVKpaa/oBcdJzOnhbQva2mdZkANnPk y/ML1la/li85Ov1fAHxpCX48jQCzs7p9+JTYRX2OdxGXZu8ajuiJswvEgs1cfHbOoMc7 rIBAXfgwkUp80fy5qvlTKe/zG3BDezFFTX8wnNVoQ+a+bmKzld6Ht2N7DnWauozhDNV8 QIhsNn750+KbKT/Zn+vD38WII4aa88WHUyI5R/y1vJZq+6y/+9YiVve5csNJ1y9qiUCG abhQ== X-Gm-Message-State: AOAM530KNvWVxWbBSw8uZInWWp5rW8R1v+j6HkYgy2KRJt5cs7aunHrm UIiyJgzrjRScQ1DEeDMVKWtXUeZ+Eq5p9FJCQptXNV4LTRyfVKhuLNUl17SLhgd3dgU1YWBBlyZ e8Fi+ZprlJlw= X-Received: by 2002:a5d:6589:: with SMTP id q9mr1987691wru.284.1627636643083; Fri, 30 Jul 2021 02:17:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzou7Qy/seWzmdS2TuqljP6WE6ccibthm/JdTwXmg1TjCHD8m30HO110jianPApwogbYCEUAA== X-Received: by 2002:a5d:6589:: with SMTP id q9mr1987658wru.284.1627636642863; Fri, 30 Jul 2021 02:17:22 -0700 (PDT) Received: from ?IPv6:2003:d8:2f0a:7f00:fad7:3bc9:69d:31f? (p200300d82f0a7f00fad73bc9069d031f.dip0.t-ipconnect.de. [2003:d8:2f0a:7f00:fad7:3bc9:69d:31f]) by smtp.gmail.com with ESMTPSA id e3sm1063745wrw.51.2021.07.30.02.17.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jul 2021 02:17:22 -0700 (PDT) Subject: Re: [PATCH] mm: delete unused get_kernel_page() To: John Hubbard , Andrew Morton Cc: LKML , linux-mm@kvack.org, Mel Gorman , Rik van Riel , Christoph Hellwig , "David S . Miller" , Eric B Munson , Eric Paris , James Morris , Mike Christie , Neil Brown , Peter Zijlstra , Sebastian Andrzej Siewior , Trond Myklebust , Xiaotian Feng , Mark Salter References: <20210729221847.1165665-1-jhubbard@nvidia.com> From: David Hildenbrand Organization: Red Hat Message-ID: <3551cde6-b48f-8cfc-7b64-b3341e717716@redhat.com> Date: Fri, 30 Jul 2021 11:17:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210729221847.1165665-1-jhubbard@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RmVj6FnP; spf=none (imf27.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-Stat-Signature: z4khyis393ofsn7xzf9e6iu71hfi96sk X-Rspamd-Queue-Id: 405757001F7B X-HE-Tag: 1627636646-785194 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30.07.21 00:18, John Hubbard wrote: > get_kernel_page() was added in 2012 by [1]. It was used for a while for > NFS, but then in 2014, a refactoring [2] removed all callers, and it has > apparently not been used since. > > Remove get_kernel_page() because it has no callers. > > [1] commit 18022c5d8627 ("mm: add get_kernel_page[s] for pinning of > kernel addresses for I/O") > [2] commit 91f79c43d1b5 ("new helper: iov_iter_get_pages_alloc()") > > Cc: Mel Gorman > Cc: Rik van Riel > Cc: Christoph Hellwig > Cc: David S. Miller > Cc: Eric B Munson > Cc: Eric Paris > Cc: James Morris > Cc: Mike Christie > Cc: Neil Brown > Cc: Peter Zijlstra > Cc: Sebastian Andrzej Siewior > Cc: Trond Myklebust > Cc: Xiaotian Feng > Cc: Mark Salter > Signed-off-by: John Hubbard > --- > > Hi, > > Just a minor decluttering: I ran across this while looking for something > else entirely, and then noticed that it's been orphaned for quite a long > time. It seems like only the plural form of this function is needed > these days, and probably in the coming days as well. > > thanks, > John Hubbard > NVIDIA Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb