From: Mikulas Patocka <mpatocka@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"Askar Safin" <safinaskar@gmail.com>,
linux-mm@kvack.org, linux-pm@vger.kernel.org,
linux-block@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-lvm@lists.linux.dev, lvm-devel@lists.linux.dev,
linux-raid@vger.kernel.org,
DellClientKernel <Dell.Client.Kernel@dell.com>,
dm-devel@lists.linux.dev, linux-btrfs@vger.kernel.org,
"Nhat Pham" <nphamcs@gmail.com>, "Kairui Song" <ryncsn@gmail.com>,
"Pavel Machek" <pavel@ucw.cz>,
"Rodolfo García Peñas" <kix@kix.es>,
"Eric Biggers" <ebiggers@kernel.org>,
"Lennart Poettering" <mzxreary@0pointer.de>,
"Christian Brauner" <brauner@kernel.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Milan Broz" <milan@mazyland.cz>
Subject: Re: [PATCH] pm-hibernate: flush block device cache when hibernating
Date: Wed, 29 Oct 2025 17:31:13 +0100 (CET) [thread overview]
Message-ID: <355486cd-6c52-df82-7636-a8259995b522@redhat.com> (raw)
In-Reply-To: <aQIm1bfwKlwaak52@infradead.org>
On Wed, 29 Oct 2025, Christoph Hellwig wrote:
> On Wed, Oct 29, 2025 at 02:31:05PM +0100, Rafael J. Wysocki wrote:
> > > This commit fixes the suspend code so that it issues flushes before
> > > writing the header and after writing the header.
> >
> > Hmm, shouldn't it flush every time it does a sync write, and not just
> > in these two cases?
>
> It certainly should not use the PREFLUSH flag that flushes before
> writing, as the cache will be dirty again after that.
>
> I'd expect a single blkdev_issue_flush after all writing is done,
> under the assumption that the swsusp swap writing doesn't have
> transaction integrity for individual writes anyway.
I think that we should use two flushes - one before writing the header and
the other after writing the header. Otherwise, it could be possible that
the header is written and some of the data is not written, if the system
loses power during hibernation.
Mikulas
prev parent reply other threads:[~2025-10-29 16:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 11:29 dm bug: hibernate to swap located on dm-integrity doesn't work (how to get data redundancy for swap?) Askar Safin
2025-10-23 20:42 ` Milan Broz
2025-10-24 16:31 ` Askar Safin
2025-10-24 17:50 ` Milan Broz
2025-10-25 5:26 ` Askar Safin
2025-10-27 8:08 ` Askar Safin
[not found] ` <4cd2d217-f97d-4923-b852-4f8746456704@mazyland.cz>
2025-10-24 10:23 ` [PATCH] pm-hibernate: flush block device cache when hibernating Mikulas Patocka
2025-10-27 8:42 ` Askar Safin
2025-10-31 19:29 ` Mikulas Patocka
2025-10-31 19:33 ` [PATCH 1/2] pm-hibernate: flush disk cache when suspending Mikulas Patocka
2025-11-03 15:53 ` Askar Safin
2025-10-31 19:35 ` [RFC PATCH 2/2] swsusp: make it possible to hibernate to device mapper devices Mikulas Patocka
2025-10-29 13:31 ` [PATCH] pm-hibernate: flush block device cache when hibernating Rafael J. Wysocki
2025-10-29 14:38 ` Christoph Hellwig
2025-10-29 16:31 ` Mikulas Patocka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=355486cd-6c52-df82-7636-a8259995b522@redhat.com \
--to=mpatocka@redhat.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=brauner@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=ebiggers@kernel.org \
--cc=hch@infradead.org \
--cc=kix@kix.es \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-lvm@lists.linux.dev \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=lvm-devel@lists.linux.dev \
--cc=milan@mazyland.cz \
--cc=mzxreary@0pointer.de \
--cc=nphamcs@gmail.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=ryncsn@gmail.com \
--cc=safinaskar@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).