From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22CA7C77B70 for ; Mon, 17 Apr 2023 14:35:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 861C28E0001; Mon, 17 Apr 2023 10:35:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8107E6B0075; Mon, 17 Apr 2023 10:35:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FF288E0001; Mon, 17 Apr 2023 10:35:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5CABE6B0074 for ; Mon, 17 Apr 2023 10:35:13 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F206BC05E0 for ; Mon, 17 Apr 2023 14:35:12 +0000 (UTC) X-FDA: 80691130464.13.E98790F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id C410314000A for ; Mon, 17 Apr 2023 14:35:10 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AGioWYAP; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681742110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nKC9O5ntfTB8FFBQ3U6lqT7ATFuyfdua81IpKIWSC2c=; b=S7hzzAB6w12w/Z0jncy81g5YR9D8cSgh/54SH4yP0aIM1s+DUFdUj68nA9lq3JxE+laMXR iSjiSABMDqI3v3GqiaiiEv7Q/Ed/5Ln/MAf8CVYPeYbmQ8XSxJknla0xePg3kIVux/r3ya zPzVfJ3+iQPOw9xVBkYYDn2PsDobtTE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AGioWYAP; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681742110; a=rsa-sha256; cv=none; b=iZSj2R/EDHD7Mo1O77EeDgMPh4R/iEIDdxzEoYnUTDe8AEIeCkOxI73fEfwKA6Rt7AGTTo ciXHgJH9vAh5/25zT9lw2IabU5plvavYoIojvS5BxvGNxkb/zhVnTqvFCuQO7mh8I47N55 /jZ+ZWqqL+mBb/b6iVCAemjRs36iQ38= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681742109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nKC9O5ntfTB8FFBQ3U6lqT7ATFuyfdua81IpKIWSC2c=; b=AGioWYAPWfcb7Lv9IyinUbzaitNCUWxH4sEAn0XjK8E3JnDPOTK6Fwr2t2TlLZyGrQbsTT ND8dl99fEQ1aUKa+ca54Jx8MUfsokIwN9d/HTPz8rzDEopkiQGTUCalWnHrU/S0itfsiej zNP5AdhzAFJ/YgbGHMvnFWR0fTUYMXQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-671-RXge46ELPey0Z4LVyETuSw-1; Mon, 17 Apr 2023 10:35:06 -0400 X-MC-Unique: RXge46ELPey0Z4LVyETuSw-1 Received: by mail-wm1-f72.google.com with SMTP id m4-20020a05600c3b0400b003f0968719a7so9393186wms.2 for ; Mon, 17 Apr 2023 07:35:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681742105; x=1684334105; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nKC9O5ntfTB8FFBQ3U6lqT7ATFuyfdua81IpKIWSC2c=; b=D3OCvQ1GelwF5tq5xiMd9J4zzat+sB6ViRDgnmbzzBkfBinN0dO7N1xG6VEOfe+NUy 1SMfxc77o6ghUo1v4N49DbqkZMQy0AqeSomc1wdb3UPGdR/LyvZac60w5WO/hJWVyloh pofX3tVhzR9/zsssDuz1RmGGNt6NgaLTvSzGXeQ3P9J6VXWPAqrMj9o4gS+WOOIlqavb MJTAXW0X+xw606KK8psnAMCnlRz/CFjKVWIgjGk8t3C6f2Z43tsgUf39G4T/dmsvP0q8 MvpSPwylIgxrJUgrNLnNw4ZD8g9Qp07ocLMDv+Fz5I01JIn3WfCtVCh/Ew10Yw7jf6wv s4Aw== X-Gm-Message-State: AAQBX9eh+F8WkiwaVZazSGAQAl6ySQD/opbJO3m8DfE/G8W8YUs9hTwP q61Ewqn1fYWBtXgA73E6TdhNOBW05Vkt5SWKoegyFuAr5ZSba3rpPPDStA7RaBSxP6AEdq8HoO5 pzfqtZKo7/Xw= X-Received: by 2002:a05:600c:2195:b0:3f1:7277:eaa with SMTP id e21-20020a05600c219500b003f172770eaamr3123000wme.31.1681742105525; Mon, 17 Apr 2023 07:35:05 -0700 (PDT) X-Google-Smtp-Source: AKy350aOrJE/aPCFeEwGeJSkkFbLEOP6OoqvoOsP3dJ51tp858c+XL14GvgOi/VSa7eA1BIISoC4kw== X-Received: by 2002:a05:600c:2195:b0:3f1:7277:eaa with SMTP id e21-20020a05600c219500b003f172770eaamr3122981wme.31.1681742105222; Mon, 17 Apr 2023 07:35:05 -0700 (PDT) Received: from ?IPV6:2003:cb:c700:fc00:db07:68a9:6af5:ecdf? (p200300cbc700fc00db0768a96af5ecdf.dip0.t-ipconnect.de. [2003:cb:c700:fc00:db07:68a9:6af5:ecdf]) by smtp.gmail.com with ESMTPSA id s6-20020a7bc386000000b003f172ec4022sm4134398wmj.18.2023.04.17.07.35.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 07:35:04 -0700 (PDT) Message-ID: <355f42d1-4354-376d-ab27-7e55d06e64a6@redhat.com> Date: Mon, 17 Apr 2023 16:35:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v8 3/3] selftests/mm: add new selftests for KSM To: Stefan Roesch , kernel-team@fb.com Cc: linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org, hannes@cmpxchg.org, willy@infradead.org, Bagas Sanjaya References: <20230415225913.3206647-1-shr@devkernel.io> <20230415225913.3206647-4-shr@devkernel.io> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230415225913.3206647-4-shr@devkernel.io> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C410314000A X-Rspam-User: X-Stat-Signature: ju91j8jq3znok5ricro1fd66q5qy83rn X-HE-Tag: 1681742110-605469 X-HE-Meta: U2FsdGVkX18nZn5EzJ+anlRo1oLn5/Vc44W4sCHiqu/mcj8epHSHCRQTIpLtwVbO1elPoh3GgbdwlSn2Q2vtG2lnvPLLcNyCefP8O+5eiQwM0bNE1sFJ34m6q3aa1jZVHU5XHJtH99ot9pFvWahZD0kF1GuwxmLA2z6ksY8c1xUNiHLeSUfxXxO+PMaIeAsXQaSyeRfQzra53tntjdoAvvVUa4TBud15I2ohiKTufznaUqtWNV7BAA+6vwuiEuRSvMhqYdG5S60maSFz8j8BTgOGhvP78cysO0RpVFyWNfqZYkV7dIOY2Gz4PBiQ4soA5l7mMipDS8jSAhSsa/QuhWIXlKbL56wfJHusMgR1RUfo2+RUlir3l/sEAGisZXgh8l5wQn0A8kGcBktKD0nhsq2HcUMvkGtbo6vTWQl0u3dKGQG6MbLPN0OuyJ2pyr5tIsVqiq+IJ7l7xHQGaR33PtOEwSd940Plj2ftCeoozLvdjRdSGn74rHDS4UWT155YD3/uwDxL89IBSFbrzuYJ79L7nRfKjnbru9YD6uVi7E/KPwzLlMPROKZZrGJtACB97ML5K72M0v1rV9cu9ZhhanC6T1QtGMPC9wCq+T+d4RfAKi4NM1Id4iaJWNQsCOCNkIbulkD0cMqmt5NF3AtB/nj4bJJXgeV+KBToXl3dCjmaVpAJZvrNQDfWAm/lKWJ3V+zHki/AMH6xOTAPO6RmpAjq9sgmcQTntseaGC9vS/hOQz3wMsLpX9mejhr2oNoSeMRlQG62Y8XHTBUFh4VXIDXXegJE8wQvWQWz+jMI+x+Q01VPMLFImI+umr+x53tY3KptQIhx+Q40mnz3fam1hudjwm76sewTtqEas8E6TX/vCjZy0y37FYvqZDgcg5m+bDcWSkPVIl2HWteIQWmpz/vowSfSNaM0rzhL3WiQqWUig61as2sWH7rXNZ/yMxzKlF9+oo5sV4vKJ9ObjZy R+sP21Js V9kVEYWT0DxbT0CbbivEi1TneekCr2AkDO6PTuyj0+QNyL/W5Gq2q2zGKFiXwpZhSX6f/DY8ZcCo3o8kTpwj7+8fApjKTHX5XN3/76Vuk9Znnc5/1CyLKojnvnyyyAlytAzTqrh+KGSLOW09VJM2xGD4SMM+wNtfB4g17m4FZtB0jgpl1j7E+MSmlxkShP4a1fF8k5mlCboZAF25nCYDh3qWAG7JSxjBNvOuJO8Gik/JuNtRW6BZnWfoCJbjQ1Vz+grecC4ofAFscBkV7a5MXcGRXv0oDxAYekn8Ny2LqVCu9mI/q79S2e8aynkQuOrpZgG+QFHJDd+EA5QAko0j0pyTwj3UyGFEAsGrQAhE2g2tXzvZVo1fDa3ovLZdiZr1WFMtOUP8wVr3+d7ipDlZoutN+iHfbG0ZP1Clmi4DZ4QbD2hs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000982, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +/* Verify that KSM can be enabled / queried with prctl. */ > +static void test_prctl(void) > +{ > + int ret; > + > + ksft_print_msg("[RUN] %s\n", __func__); > + > + ret = prctl(PR_SET_MEMORY_MERGE, 1, 0, 0, 0); > + if (ret < 0 && errno == EINVAL) { > + ksft_test_result_skip("PR_SET_MEMORY_MERGE not supported\n"); > + return; > + } else if (ret) { > + ksft_test_result_fail("PR_SET_MEMORY_MERGE=1 failed\n"); > + } Just realized we're missing a "return;" in case of the failure here. -- Thanks, David / dhildenb