From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA375C52D7C for ; Wed, 21 Aug 2024 21:34:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28B5F6B0195; Wed, 21 Aug 2024 17:34:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23BDE6B0196; Wed, 21 Aug 2024 17:34:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B55F6B0199; Wed, 21 Aug 2024 17:34:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E2D7B6B0195 for ; Wed, 21 Aug 2024 17:34:49 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5FA321C48ED for ; Wed, 21 Aug 2024 21:34:49 +0000 (UTC) X-FDA: 82477557498.08.185B80B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 05AF940008 for ; Wed, 21 Aug 2024 21:34:45 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=E8uBUieo; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724276069; a=rsa-sha256; cv=none; b=UFuTAEO8aTiTLrx2jcemSEvr0oan7vH1rdKW4HsGDuD3psGIad63ZYeXmAOPvTKYnKLzym 0jzoPfn1YLAwRJHeKe3uIjEKidlDUIoUg6w/FyYQ2wf81oJfPLe67tkmw8zIH/pYF0IPmo 3jTr8C5H65CF6atEsVkQwdHW2Lf/j5w= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=E8uBUieo; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724276069; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L9SRPOtEYa7Vq9IzjmCle+ZKcbGVaJuocm8tqYqXS/s=; b=2zRN4mFb6jNgjJ+3hASR+kNv30yWoZ+oRbSN3Whr2ii8UUobtyLNGytgTVVHLziUEwFuw5 LoTQyqllLOkXnRMnPR9XkxrsKie9cHdtn2D65tle2s0eKGj5GceUaZM80O/ETHSjOoDdrP EOQGv6JaR41jk+e3DG0YuPaP8+3MOqs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724276085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L9SRPOtEYa7Vq9IzjmCle+ZKcbGVaJuocm8tqYqXS/s=; b=E8uBUieoyEorJ2VkNeDzu0Lkqf4jdY+Z57u3aQfTXpzaaAoSY6B+a8QMGw27TG3JbzESfz ujEn8D/l0xU79N1XqwZ9Rt73m+sIXU2+c4SqpldTszGJeB5l1LcXEmofctIGwITE3d4Ha0 kh4PsweOyHxQnbA+ioSkMXT5k23QpUk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-25-Uro2BzK4NeuqEQ3e5RPz5g-1; Wed, 21 Aug 2024 17:34:41 -0400 X-MC-Unique: Uro2BzK4NeuqEQ3e5RPz5g-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42816aacabcso482785e9.1 for ; Wed, 21 Aug 2024 14:34:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724276080; x=1724880880; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=L9SRPOtEYa7Vq9IzjmCle+ZKcbGVaJuocm8tqYqXS/s=; b=Tya175nm4GxsfB5VHsxfkbN1ahA/3nxtTX6W/F+Db+4Yew1JGSMchGkhxhbVwB+UEY R10DLeuBirvIdaimOTG1wFZukCy8kYT0PKicC+cPo+scj388Z6+jg7p27pox9PIdFQdI P/ej8hfcR11MrjPpqZmCTv8FgNn1Q8Gw8/cP6GIn1f9HuLY5a/9IIPvQ9unr1ebI/emi 3x9XESFzDWts6JNeA/Z0TUWRMIye+tE6VHLDfQ09SnXPyyMSQbDemqnuGay10neZ/yeU UvTrTYNF/44rwwmHRgYv5GQxbFV91cxxrAOXenNNootq6hKIKtAs+2ad1YE17dKM7rqX 4GrQ== X-Forwarded-Encrypted: i=1; AJvYcCUcKFPj8btWOQk/4pPoLMpbJ0ccevpxA9I1MNqPh27SZ8Nc+gbB73qlfah07rxIQy9SxOXsxBR8Xw==@kvack.org X-Gm-Message-State: AOJu0Yw8Oisvl1n35dQnam8YE/6WXMn3bZ2ErkMiyMDNNDe7j+vlC0EI EuWXh8veXcE8TygPaIKXqiPdUDxA5DwzQcTmQlfgF2GwlYs08FZxnPoHc2y8u226d3FB2LY12EV w4kbSp9ybjJOc3C/rgdecyZc74NoHazJ31stGnZ8+2/aYsyq8 X-Received: by 2002:a05:600c:4e91:b0:428:9ba:39f with SMTP id 5b1f17b1804b1-42abf050ac9mr19897865e9.11.1724276080524; Wed, 21 Aug 2024 14:34:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGFdo1tyDR9h9u6Fe4Cg5JrjJXAZ+0S4BhkG3v5X7DVND3RUng/BMfFJTGsVag10PxZdUBhHg== X-Received: by 2002:a05:600c:4e91:b0:428:9ba:39f with SMTP id 5b1f17b1804b1-42abf050ac9mr19897585e9.11.1724276079602; Wed, 21 Aug 2024 14:34:39 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:4300:16d5:c5b:8388:a734? (p200300cbc705430016d50c5b8388a734.dip0.t-ipconnect.de. [2003:cb:c705:4300:16d5:c5b:8388:a734]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42abed8b848sm39449985e9.5.2024.08.21.14.34.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Aug 2024 14:34:39 -0700 (PDT) Message-ID: <3572ae2e-2141-4a70-99da-850b2e7ade41@redhat.com> Date: Wed, 21 Aug 2024 23:34:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: collect the number of anon large folios To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: baolin.wang@linux.alibaba.com, chrisl@kernel.org, hanchuanhua@oppo.com, ioworker0@gmail.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, v-songbaohua@oppo.com, ziy@nvidia.com, yuanshuai@oppo.com References: <20240811224940.39876-1-21cnbao@gmail.com> <20240811224940.39876-2-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240811224940.39876-2-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 05AF940008 X-Rspamd-Server: rspam01 X-Stat-Signature: kikhc6epot1xyq4gkox7q4nogybqj66u X-HE-Tag: 1724276085-898092 X-HE-Meta: U2FsdGVkX1/gYhLG1lgOd3oBm5pz8+qJ4U8eefZC5T5ox2JcMEUhWeDJW9WvnkYnY/fT0KQnq2ylca0hI8VCcSU18nPSvektVeoIUc040o2fk1dB/qsfLQwSKeD3oxzDCrhJSjs8oFH755X0+D0OOHx1LnI02HHvA/Nv1qIMsRzBB0V9w8zL70pxlCo3UkGRu7GbYNZf1hqupxXgrJuNMWn5N09R5F1gaJj5TXgmHvpXzf4LjhVsjx1tTH4kE3/Hr7bgzs6avHmelO2+hhAlmgPkuucH8Z+77uqFhq8Dk5VTiEMSeqh1mIAf7kAvREDvGqRpKuWuQI7+GX865kTlGZ5/2Ht6BWehdp/rqTdUvKiAWN7MsszH381oPeZxsCwf8cMYc1DrGpZa/VaI8vt0sgao8Ey5hf12phy3F0pNhtlWJVHrXoXHArVixtJDcDWxJOdkAcG9JUjiJcrKPKRm0ZFJJXJl8038s/NhYMnkldTlCzeCYP2u+e4T7yl2ucEqUpNA85AcXsVM00CgE7cwNvY3zyAWbVu3ExAF6IKtJRWY1Y/iMBOWdYkI5Ow5oEy8+m1XkKNo3/rtJqbWlvrNju54PWjH3N3xKbcBeXgMzWFCVBStxTAQyLjVW5LL92TEyy6Q6vJpNAaSPvdh5iL00B6w3l055SeOBaDn2sqcw66W/y5Q0fFuUQyh6JIsV5LnRP00De4oFoKM6LKvH9hWgIK/5T75DPIswOlVq2UzzCxYRJOTy+Oh0nDygJUabuoqKhcrJLMVSmWl357iDr1j2w4TDsfNlPHV605j9U9y3TleZ/B83Coz/ID9L/tla6kZVFmVWQ4nbTO+JtCZP79w1Ofh8tpV9aTeUCGb9NCUpFv2ugk9m3bUS9EZsSOz0Wc1EQOHLSWxd1n+6C4wmn9LRtBzmssjgpauYcDjND3FtJUbLA+NRo0ypqKtPa9z5UPXqkliH4t4qiNoRwwSwOT zyNwgTTc SouXx2HFg9MerQebq+99CZa5Dt8e3KyDFjNnid0/kQNoBnHpLHCX81qs9KN+1bHwRHI1PwgEZbkX7nNAFSCGFhFc0szeWXO6vfigyU8cQ45VI24efWqtCE5Cz0tU5Aqydix/olDH8uKbBwu0YDDtjNF12lwoYNuGjYhD/WYR6yyYWqAOzI+kk2gopSNTRFKV3eiV42enLHc1URRJpp5CD9524CYWjsMbR5cOaOatc/foYJpVnKBf78yVztFI4+YTbWJI1reYpbg7AzGhlm9CjXhGlz0pMP/W5A0g/14RPk5RGuqAA8s56ldQXoKxz5+64PD7PT6PhHm5VKMm+XMeAoPw4HNyzHCnv9jOWatlfzx3lD4HHnSE7PTXG9BZXE1QHn6Do/EH4ERrwEBjnaYZLiylV1mN4rnQdEnQrqd6I/6HNYYOJvAS0ozFlvxAGCNxUuUICmhpNxTxUuOQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.08.24 00:49, Barry Song wrote: > From: Barry Song > > Anon large folios come from three places: > 1. new allocated large folios in PF, they will call folio_add_new_anon_rmap() > for rmap; > 2. a large folio is split into multiple lower-order large folios; > 3. a large folio is migrated to a new large folio. > > In all above three counts, we increase nr_anon by 1; > > Anon large folios might go either because of be split or be put > to free, in these cases, we reduce the count by 1. > > Folios that have been added to the swap cache but have not yet received > an anon mapping won't be counted. This is consistent with the AnonPages > statistics in /proc/meminfo. Thinking out loud, I wonder if we want to have something like that for any anon folios (including small ones). Assume we longterm-pinned an anon folio and unmapped/zapped it. It would be quite interesting to see that these are actually anon pages still consuming memory. Same with memory leaks, when an anon folio doesn't get freed for some reason. The whole "AnonPages" counter thingy is just confusing, it only counts what's currently mapped ... so we'd want something different. But it's okay to start with large folios only, there we have a new interface without that legacy stuff :) > > Signed-off-by: Barry Song > --- > Documentation/admin-guide/mm/transhuge.rst | 5 +++++ > include/linux/huge_mm.h | 15 +++++++++++++-- > mm/huge_memory.c | 13 ++++++++++--- > mm/migrate.c | 4 ++++ > mm/page_alloc.c | 5 ++++- > mm/rmap.c | 1 + > 6 files changed, 37 insertions(+), 6 deletions(-) > > diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst > index 058485daf186..9fdfb46e4560 100644 > --- a/Documentation/admin-guide/mm/transhuge.rst > +++ b/Documentation/admin-guide/mm/transhuge.rst > @@ -527,6 +527,11 @@ split_deferred > it would free up some memory. Pages on split queue are going to > be split under memory pressure, if splitting is possible. > > +nr_anon > + the number of anon huge pages we have in the whole system. "transparent ..." otherwise people might confuse it with anon hugetlb "huge pages" ... :) I briefly tried coming up with a better name than "nr_anon" but failed. [...] > @@ -447,6 +449,8 @@ static int __folio_migrate_mapping(struct address_space *mapping, > */ > newfolio->index = folio->index; > newfolio->mapping = folio->mapping; > + if (folio_test_anon(folio) && folio_test_large(folio)) > + mod_mthp_stat(folio_order(folio), MTHP_STAT_NR_ANON, 1); > folio_ref_add(newfolio, nr); /* add cache reference */ > if (folio_test_swapbacked(folio)) { > __folio_set_swapbacked(newfolio); > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 84a7154fde93..382c364d3efa 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1084,8 +1084,11 @@ __always_inline bool free_pages_prepare(struct page *page, > (page + i)->flags &= ~PAGE_FLAGS_CHECK_AT_PREP; > } > } > - if (PageMappingFlags(page)) > + if (PageMappingFlags(page)) { > + if (PageAnon(page) && compound) > + mod_mthp_stat(order, MTHP_STAT_NR_ANON, -1); I wonder if you could even drop the "compound" check. mod_mthp_stat would handle order == 0 just fine. Not that I think it makes much difference. Nothing else jumped at me. Acked-by: David Hildenbrand -- Cheers, David / dhildenb