From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 474D4C54E58 for ; Wed, 13 Mar 2024 02:07:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE7B26B0113; Tue, 12 Mar 2024 22:07:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C97F76B0115; Tue, 12 Mar 2024 22:07:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC3B16B0116; Tue, 12 Mar 2024 22:07:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 94F106B0113 for ; Tue, 12 Mar 2024 22:07:36 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 47BA380F43 for ; Wed, 13 Mar 2024 02:07:36 +0000 (UTC) X-FDA: 81890379312.13.6AEF830 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf03.hostedemail.com (Postfix) with ESMTP id F174E20006 for ; Wed, 13 Mar 2024 02:07:30 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="e/jZV19U"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=A+eEbjKx; dmarc=pass (policy=none) header.from=oracle.com; spf=pass (imf03.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710295651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PWDRy2S3EGLgL1AHx5vnAziZYlKzAaFrnm1e3yNouFA=; b=iA6UY6zgtnChQPfjiUII8/Ax7KB7ScXLXvKddcQLZZu0/5UPqpFhDKEBfWU/bOXnL+EeZe v96ZKEKpJUisUpYpONppk6sTtNHR+1L/fWccXd8b7f2KK4sCbpaTOoK9a6wURnmhXnKdGs xZY2C8IKFqLL66ZzKWO9cP0ApVMNPvg= ARC-Authentication-Results: i=2; imf03.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="e/jZV19U"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=A+eEbjKx; dmarc=pass (policy=none) header.from=oracle.com; spf=pass (imf03.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1710295651; a=rsa-sha256; cv=pass; b=FR7iszmsjH32mcYyIw2I/z3jdGNna7z/T6ufoieDIL3Gna88gok7EHEn1KiDV9QzqRTj0U zELgUa9/tPfY7aR2fQ29sRa/nBas70Rlys/jL283qypsuMbjA0LVbwqUSSwF7g7FVO936W a3OaTe43MJHCRZ8wjSlSrgZYDVfwARs= Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42CKQ3G6007800; Wed, 13 Mar 2024 02:07:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=PWDRy2S3EGLgL1AHx5vnAziZYlKzAaFrnm1e3yNouFA=; b=e/jZV19UYGWEony+SH7ui2wiISqb3tW0mzhyT8BnoWhznlZ15kdokNMgHv/XXc1v3ahU wsTI070nFkLMT4ezvozb4I+3IegcRL2BFV3Kh6EpvmbCSmmBW4pb07Wyi/I6beHN9ySy 5Dx6qoLhV/GuS5pZBcwsvDFx+fyVzAW22SFjG5DUNFSyCxixUgiVQHpzI8FVPXYP89uD 7S7MBVeSRqWvXzgYhXZaopKVyfgqeyM6l0QiVKD+uavWhBZfsCqKjs2koE79mpdafE7p kRpDPvhZGQ9Cd5StNLh2BnZe6Ly7mT4Wypa30HTwqm/FkAF+2Tr24Wr7E2AvlBfY7V/0 Cg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wrej3yq6h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Mar 2024 02:07:18 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 42D0N3B1037352; Wed, 13 Mar 2024 02:07:18 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2169.outbound.protection.outlook.com [104.47.55.169]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3wre783tyv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Mar 2024 02:07:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WtOZEX4tTwL3bKTd0V3TOiN5QcCci6uTGoUeA0nEXFhIHUe56dKI3nyRMMyq5b3hPNLaEDFajFehfWo6yu4g/HqKdTUs4nkeU/V8mS0nEt07autrP/Pyn7kl25mShmOJp7BjFhC4dL8iaCthJX7b/H+qIcgzEHKulsqvz80XMQwCsowWrhh9MP4MkFWd/PJ6J3/mphkqQPFSZI1i7mP0W4irmvfn8MtEceRixl8F3olxyye8JgF7LjvXPnCnMgDG48CQUt6kjkWzonklGC+mUbLBqLTdW1YQsercZO6vLUFy3Vv28ro71wwrVBowjn3iWK5Hq/XS0cuvNlteeNHekw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PWDRy2S3EGLgL1AHx5vnAziZYlKzAaFrnm1e3yNouFA=; b=m0xYhYgv5vdAh4nZ5QblpYmK3/ho9VjtjP9mF3o2SbiOqLuI7xDxCu3ub/Rlcek/fGfA488YPLZuqi0oRxWUHmucAvOIE7z6dDLgykWovolL+T/8rAXGqmx+XFez7+tfShGNTvUEVo2xmIloBGuBxR3WDR+8HS+obHMJUBoqN5yEwmhBVrO81kvrqzRHI3oJqQSFWv25HuWSEJtCsteAHRi8vdPGNbM/gyztsBobzbuK8BeQ/J1GkNpuS1sYmeyw6OK/7DVDZN39njslqwxMlTeQys4lssAMJq3BIj+w5jpiHKb8D4DQ8HrOmA7e7quCO/O8l1B+F201/5f4sAjzpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PWDRy2S3EGLgL1AHx5vnAziZYlKzAaFrnm1e3yNouFA=; b=A+eEbjKxgu43288FuWudc7firtd1Qh30YbNdEnV+Q+Ww4lBgaj+e3rPG+VyQdb5GKAwJrHL2I+fi/N71KDLeGCbkAmFg3edcUb9iE9RiwoTac6Qe8NkutI/yjanGYZIHR9u3az0AVAvMv/bk3Xg6uDOFqtJqkYhit1oEh6z6Eqc= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by CH2PR10MB4120.namprd10.prod.outlook.com (2603:10b6:610:7d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36; Wed, 13 Mar 2024 02:07:15 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::210e:eea7:3142:6088]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::210e:eea7:3142:6088%5]) with mapi id 15.20.7362.035; Wed, 13 Mar 2024 02:07:15 +0000 Message-ID: <35c987d6-e78e-41df-a157-cc764245fa30@oracle.com> Date: Tue, 12 Mar 2024 19:07:10 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] mm/memory-failure: Remove fsdax_pgoff argument from __add_to_kill Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Andrew Morton , ruansy.fnst@fujitsu.com Cc: linux-mm@kvack.org, Miaohe Lin , Naoya Horiguchi , Dan Williams , Jane Chu References: <20240229212036.2160900-1-willy@infradead.org> <20240229212036.2160900-2-willy@infradead.org> From: Jane Chu In-Reply-To: <20240229212036.2160900-2-willy@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BL1PR13CA0442.namprd13.prod.outlook.com (2603:10b6:208:2c3::27) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|CH2PR10MB4120:EE_ X-MS-Office365-Filtering-Correlation-Id: 7af6143e-752f-421b-7c35-08dc43024d71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XlAowqHTSBSl4TJoFoblBQMMlGROkcjjof2BFtU1vvmTmvLrTifz2euLRkffxQE29/jVFXmIhYsV5T7rmg+An+Ep6dkPMH880/fCMO3xEIBNSQvsVj08x9yTIFVz0P5ioUjYxVtDyOrKttCJffbX9ls/0RH0tpa6L7DjlA7TYbJTclNVohh6Q9vQQrgittUYGtXGvwl5cWFZbw0DfwDBZKSZPXmqkLynwXSq5MrbIdqTsP9jnvy8bFYs/1YeQyNhPSXNeRNFw5hQbtpLFCCvRiSAj8afn/vePAuxrWbNRw6YgArI7Q7xHVr0vtir3Bofj0n0Toy2GBt60XGCKLkxOGJHC+cofs6BsxpxvyBrvnCS6MQO9hxF0RxXO9jvh4ftNFVHMPvd31nmJooSkkIDdEAThCvytlZqcUcmGTfZCpdyBCWbz1nu5VGw9IzamhwVWgzm+exs6KhHkPsZB6HKfZdpJfvsmowdKBxQ54PAbjrICa2n58w/h2tGNLHAv/D9w70E0kOxQyxJe3n5k6x/JBsQ+NyGEtckoJjBdhVbL+UV+JORaojE7P+szG2+57Z37rv6AYR+lhPXmwRHAOdzS5bHO8eEcA1VnXdpEqIS61s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmNhd1pxd3pORmhjRVh6WktrUmRlU2RySENQeXlmWHY2VXFkQ0Z4a2pLbE1C?= =?utf-8?B?SjFjc003ODJlWUtiMkt1S1FBR3gzUVZWbFlqcjVmNnpTN1lQMDhrakdhelZj?= =?utf-8?B?WWppSVc2dmNNU3ZPcGJOcktEeG1NMklybmFPbG1jQmtleVhDUTJDMXJXcVdU?= =?utf-8?B?N2cvdzNhaUpMVUtxK2o4ZjcrdjBYMzg2RndaKzVnc3BvdC9vVm9sOERscFVo?= =?utf-8?B?KzIvaWthRlhXZzNhVUxnTThhekltVnU4d0NjZU9XRVV4U2h4SmplSHM0WHln?= =?utf-8?B?aEg4K3c3YmhaTS9jVFAzZWVndXZCWXBRM3hnNUtyNnA5MlVQa0dlTzdqQm50?= =?utf-8?B?YXZYSmlKR3dGWkNvUU1GWDBxV1hoMGZHZUVKbkVYZmtXMkZIazJMeUlyUWx0?= =?utf-8?B?UWs1ZW03UXcybitISGdqZG9wZm96UmdYdE1OdHJqUFFkYlpJK21FZjF0ZUVI?= =?utf-8?B?OWRKek10U3Z2VWpteTV4TE5TQisyOGx3MFArNDNaYUFla1JwK1NXcmhLV3px?= =?utf-8?B?NEhFdHRjVHRtWFJpM0NBVVRkeU85VkJsaUkxUHRjWlFuUjRkT2dGUDZ0ejYw?= =?utf-8?B?WEthQmswMkxKM3VsQXc5MzBQcEVybkpldDI1K211UWg2dk5PRlhBSGl3Tzdj?= =?utf-8?B?TGlxTEpzNnpRZVVzUWxLdGplYmgwMnlLalREQVdINUFsR2tTNEtpei9Jd0NX?= =?utf-8?B?TXkvLzZuR0xEaFpVOStpOGlvTTlsWS9pcmNNV3pJTnhZcjRXNWdzZG9mTG1O?= =?utf-8?B?RTZ6dEEwVWFEVk9YdzVzU1JiN3ZhbW5TdDVsZ281OW5nRGRNYzBsU29EUlRP?= =?utf-8?B?TDZKL2pIeDRZWnoxNmRWMk1TWHFVcXFHSEdCemo4eGZLOUtsemtUS0Q2cTRG?= =?utf-8?B?RVptajhZbkVXS1hRV0p3OGFXOE96K0oxbjQrVG9hZW5VbVVnTVd0elV2ZWYy?= =?utf-8?B?R29CVzZaS0tTVXVmUXcva2ZVc2svbXVsTHlvQkxmeEcwUlAzckVUMU9rUzZD?= =?utf-8?B?MnVSMDFmTFpFaXdRdGV2QWRrTUtINDFyY1BzL3IwaitEM2JLbFNVUE5ldUEv?= =?utf-8?B?dmFFL3A3WWtyV2N6NGVOWjhla1J4a1lKRC9ZMU9rd0xGZURlcVJQSDhRZjRk?= =?utf-8?B?NWxEc0NCamRyK1l2SDFhbkludlV5SW0rMGdpWTJSME5zYjlZbkFzVTBOTHll?= =?utf-8?B?MXh4UFpOcDFBeExqTHNJdmlmbTRabmhrUG0xSGNPdld2VkRtMFpNQzRjUnFw?= =?utf-8?B?SGxBZEJtaGdyZTNjSGdtOUhGbnJoSW45ZlZtUUZhMGk4Q3lzTDd5RTY0elo5?= =?utf-8?B?MUhvcnZCRFN6MXplbXVuczdyOU43cTZVL0xyYVFueEJuSzJSdFVnOU1QT08x?= =?utf-8?B?OXRqMjFRTXlJa1ZVZGNPcWhGRmY4Q3lUTmsyQUZiaGU5cTZ3Mzk2czhWcVVw?= =?utf-8?B?TWVoZHpleGF6dnd1clkzazNjb2xQd3hpRzBUODdIMmZrNjhJcld3R0VFQ3ZK?= =?utf-8?B?Q2MwTlF6d09TMDVwSTBGWGFJSlJhdlh6Uk9SNHRvVGZjNmptd2tDN0hsL0t5?= =?utf-8?B?dWZWS3pOOG9pa1FLeEUwZWQxYlprNktCR2oxOXNWMHl0UlNzT2xEUXRSVkdN?= =?utf-8?B?TDZlellzL0dOTEEra1hnc3VUUkl5eERjVzNwOVQ2Y1puOERGU3NqNURyaHlT?= =?utf-8?B?eDFmakJLLzRBbkgyelIwdDhtVUtvbG0zVXBjcW8zcUZBM1VZZFdvK2YyT1Rx?= =?utf-8?B?aWRWSE9iUURkVjBNOHl3VHZYWjFrNndjM0F1QTVlZndKc1FnV3JMZGU0VmJz?= =?utf-8?B?SnZyTlgrSFJBa256Mk1GdVNCSmhIbWl4ZEdVSDA3UTNOOU5TblBaYUdNZmhL?= =?utf-8?B?RmtZVFhPOVp4Ymk3SnBINVNlR0Zwdy9XU3grU2VCT0ZuTFd5VGltU1Y5VUdB?= =?utf-8?B?bExWYStNSU5KWCs3RWtoQ0hLVHdWRWFTeTBqSkl6TTNqdzFMN2pDMHYwSlZM?= =?utf-8?B?eVFxK00zcW96MlFHWTBCem4vZkRXUGkwQ3RFcEtMVlIzMHZlL2RkeWpqeHUr?= =?utf-8?B?V2dqU3FXNzFjMjZtUUx1MnRzRWRXOC9VcUxKLzhhS05vWC80QnhtbVcyU010?= =?utf-8?Q?LXUolVJAHtYHDuBkHkCaTydsb?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: NcaplRTNIpoakrjNQqEtszpd53sW3pU8Q9Pun3x0YHKFhdbaMN/eAuaPhJxH6EtS+qyVdQUJTp8EgaJLtKbGoKFUCTT3iXxcqgw5D2ckdQHT3EYuer3gmaaxObTiFx2UC45sPLDbmCLDVdaYgy+I+RJKox/BkwlA5teS/s0549bAEnVb4SzPBQcFJM0ESpnBIE0EH5KGzaatYfBziwsXmSu9vaGuK1vLb6ICgoQwasdwhQziH8dt1RDrhbQbPOrPGAfXMAn0mDryVnni4Mgv/bmhqtFNMWHabWOdpRX27pbDwbDd689Dc5DsL9EvOYM6j77kVTeqsPcO/BY+LowOcXlHGP6WaHVfyhWTTTF47BwxxvuCDiLIIqaLwrwqrqpiJyEo92QVApJ639Mi+hEmqZIJ52icPUgAeSLvkQYFWI6fvRGCQPO8vMuzYj8/kcR1rVXNFy6Hjy4c9daEgBw5WCGMKOwqf0rvUo17J3JCzWUIdARAojYXiCht6HLG6rSF/cUmHMTFSav6hvngjfwe0QJMhOpK0Lr7VlbnDWu1qIvW6luTLRGORQzrVHeuAKFfGw+BpbXBZ7BWXvBDVrHgGgDmDmOnlqKrYQZcGzKYfmc= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7af6143e-752f-421b-7c35-08dc43024d71 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 02:07:15.0408 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JQLLwci9e3FLcDX9NHsGx5e5b+W8t0dOfzh9v4sygDY87/8QmlJDug4ae1BMH1YOovMk85w/AQ6CH4pX7bgXbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4120 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-13_02,2024-03-12_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403130014 X-Proofpoint-GUID: SEw7xmaziar47aLaDsM4scOLr9x4nJ7O X-Proofpoint-ORIG-GUID: SEw7xmaziar47aLaDsM4scOLr9x4nJ7O X-Rspamd-Queue-Id: F174E20006 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: a8ip4utykjjmjntjkf93yctqp3m5udjp X-HE-Tag: 1710295650-885065 X-HE-Meta: U2FsdGVkX1+IoP6FvVJa5fhZ845OIChRymZadTfZVbOBxXs12x5nuRXFgAF1W0lyf54UWfuRhKwphC2KSYK0+SVEA2qV9Cx3bceiu0UU+/KLm8T5nkFELoXFLzt9kLPbZJTHsiLApswB/CUPRzrHtdAFm/mlbLbvRAJ7dFKb/xtVfBlh6jiHq6dYCQqdXzMkPjbqB9R5fml+1EcVOl9VbSYxKhbHg6nqWkZcOwjh9cwhjwBmbYm5t/gewb1G9BHwExNBpuDRuXzP9q5kYZUYWBo2WMxPGel/t7GYVznMC376jgrFU6V03WzzfuNJr6oejTtqzzW+8QOy/+ThIm4FjhcEi0IbDCEDWHVMug+Fy9SS+zOPkGfqoDsSDigM3OtLs45sW8P02YdULdysPbJZL9ux8u89gDvuwdutK4D+s/MCPMvhXFBHozd9jS2nZeRZvvyAdIrJRO2eRo4D2Brxs53Ur0iI+pXjZAbtoZ9R3mIybPxpH/+0nFeaEn7Fd1sYDyR7Xyta2mzPjrOP9OE+jOreL68R9bGamxWa9k0L52mvkF5S+Y+pEmoNcp4TMh36Jrj5VdaQXDweM821dAXjNSbkYjjbuQ5aSE+b1J79tpePl0cHSsjeM+DbMrWSnal0uKX9xQqwp4PmkhkVZIi9emD2fagtddPcQojlGz1hpTbyU08rA3D+fRSqWo73v68XRvBAGmWKpm/5LX5G5K6WfxTa94CSBdt4kzCKhSuDLUGMT2KDxFYhYkI44Gf+RBJKl4NQa3Ba5gMBjpJAywDh4J4WjLGcwOsN2bjjXf8+G0TAqegIWnUMPNEILbhaDGXd3XqIj6OeEhUO2e6OyBVWANqikq+G83YKz2PtN13tIGsUsDgMoiEdBuskEXxA7btDMJS32MyDcf3YUtsiogdj/L41LlOsg6ziVNiJj8n3VvZ9F9mIa2Fi4dhxDWY7RjZsGibifaqqlmvO8LPI2sG Z1PedBxH JKbvzEZguZ1Rl0/PJZIvjZ+gkxQaK3Pk7xo+SPKyKCmrxaNmenPEgb6jlK4MtbjtiQPElwngFdMi/iGfg3hP79I0IUW4L5k4FjOahq0q6G0lSZNUHPDhzDF0P5b0969t7Vf0p/wihBAc9LQTkFWN1C+ZI3bmsmRlbQ7OYgUNDfOAEmqsqGAAH8lTtRpmizEpppQYkg5FX53IlPtXdQdLoIRObcBQmSiAglOkZ+idb7gNbB+LRgouArZD0uI6S0+j5tGfqCyXxvKPLvZPzMsZMnsz5mZppJBhTdj2l1y+QRkLOBoNcqEiOlYHwUWUHPa+2AQuG0H5wdvzebHYYvE2WGJqPkhZP9BK4FaNtnVARYhvH+I3Ph9+fPZWHEZaLJzz2exoSTKPngUNj6Ifwv0tp8emM+Pw9yQtnc17Hof2G/4U3JiUwdg9e4anIakQVFJEI6nchJH87ZzfnOyhlgjCd2bevcQLQUDdr2kyE/3newFMP2i2Wt/+vzXGgOoQ03XZ47ojh+lTuQBl5bxYCZgR0Ofxki4l+VL0wyQeemYukObNg/t9foPf3eDRdPVqkK4D4vhAdEJPnVi0xkXjVXsUhH84PRC2dpky6LeSUyD2pZXbsS138WS4ym2hqcEdiPqrJaFlgRKeR4oFj0wiVAW+4sUl+Necl6vtbOTyl+TfSixqfbkMYfFrz3WHue7FZCCv5h4lKV6CxuIvjyYHk5lHKa/axMGeL+gB52uTwInPmE/l2k5E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/29/2024 1:20 PM, Matthew Wilcox (Oracle) wrote: > Unify the KSM and DAX codepaths by calculating the addr in > add_to_kill_fsdax() instead of telling __add_to_kill() to calculate it. > > Signed-off-by: Matthew Wilcox (Oracle) > Cc: Dan Williams > --- > mm/memory-failure.c | 27 +++++++++------------------ > 1 file changed, 9 insertions(+), 18 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 9349948f1abf..9356227a50bb 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -416,21 +416,13 @@ static unsigned long dev_pagemap_mapping_shift(struct vm_area_struct *vma, > * not much we can do. We just print a message and ignore otherwise. > */ > > -#define FSDAX_INVALID_PGOFF ULONG_MAX > - > /* > * Schedule a process for later kill. > * Uses GFP_ATOMIC allocations to avoid potential recursions in the VM. > - * > - * Note: @fsdax_pgoff is used only when @p is a fsdax page and a > - * filesystem with a memory failure handler has claimed the > - * memory_failure event. In all other cases, page->index and > - * page->mapping are sufficient for mapping the page back to its > - * corresponding user virtual address. > */ > static void __add_to_kill(struct task_struct *tsk, struct page *p, > struct vm_area_struct *vma, struct list_head *to_kill, > - unsigned long ksm_addr, pgoff_t fsdax_pgoff) > + unsigned long addr) > { > struct to_kill *tk; > > @@ -440,12 +432,10 @@ static void __add_to_kill(struct task_struct *tsk, struct page *p, > return; > } > > - tk->addr = ksm_addr ? ksm_addr : page_address_in_vma(p, vma); > - if (is_zone_device_page(p)) { > - if (fsdax_pgoff != FSDAX_INVALID_PGOFF) > - tk->addr = vma_pgoff_address(fsdax_pgoff, 1, vma); > + tk->addr = addr ? addr : page_address_in_vma(p, vma); > + if (is_zone_device_page(p)) > tk->size_shift = dev_pagemap_mapping_shift(vma, tk->addr); Not sure about the simplification.  The fsdax special calculation was added by commit c36e2024957120566efd99395b5c8cc95b5175c1 Author: Shiyang Ruan Date:   Fri Jun 3 13:37:29 2022 +0800     mm: introduce mf_dax_kill_procs() for fsdax case     This new function is a variant of mf_generic_kill_procs that accepts a     file, offset pair instead of a struct to support multiple files sharing a     DAX mapping.  It is intended to be called by the file systems as part of     the memory_failure handler after the file system performed a reverse     mapping from the storage address to the file and file offset.     Link: https://lkml.kernel.org/r/20220603053738.1218681-6-ruansy.fnst@fujitsu.co m [..] @@ -354,9 +357,15 @@ static void add_to_kill(struct task_struct *tsk, struct page *p,         }         tk->addr = page_address_in_vma(p, vma); -       if (is_zone_device_page(p)) -               tk->size_shift = dev_pagemap_mapping_shift(p, vma); -       else +       if (is_zone_device_page(p)) { +               /* +                * Since page->mapping is not used for fsdax, we need +                * calculate the address based on the vma. +                */ +               if (p->pgmap->type == MEMORY_DEVICE_FS_DAX) +                       tk->addr = vma_pgoff_address(fsdax_pgoff, 1, vma); +               tk->size_shift = dev_pagemap_mapping_shift(vma, tk->addr); +       } else                 tk->size_shift = page_shift(compound_head(p)); Looks like it was to deal away with this check unsignedlongpage_address_in_vma (structpage *page ,structvm_area_struct *vma ) { [..] }elseif(vma ->vm_file ->f_mapping !=folio ->mapping ){ return-EFAULT ; } But, by providing nr=1 in vma_pgoff_address(fsdax_pgoff, 1, vma), it also avoided dealing with wrap around, which perhaps doesn't matter? perhaps noone runs fsdax on 32-bit machine? Add Shiyang Ruan for comment. thanks, -jane > - } else > + else > tk->size_shift = page_shift(compound_head(p)); > > /* > @@ -475,7 +465,7 @@ static void add_to_kill_anon_file(struct task_struct *tsk, struct page *p, > struct vm_area_struct *vma, > struct list_head *to_kill) > { > - __add_to_kill(tsk, p, vma, to_kill, 0, FSDAX_INVALID_PGOFF); > + __add_to_kill(tsk, p, vma, to_kill, 0); > } > > #ifdef CONFIG_KSM > @@ -493,10 +483,10 @@ static bool task_in_to_kill_list(struct list_head *to_kill, > } > void add_to_kill_ksm(struct task_struct *tsk, struct page *p, > struct vm_area_struct *vma, struct list_head *to_kill, > - unsigned long ksm_addr) > + unsigned long addr) > { > if (!task_in_to_kill_list(to_kill, tsk)) > - __add_to_kill(tsk, p, vma, to_kill, ksm_addr, FSDAX_INVALID_PGOFF); > + __add_to_kill(tsk, p, vma, to_kill, addr); > } > #endif > /* > @@ -670,7 +660,8 @@ static void add_to_kill_fsdax(struct task_struct *tsk, struct page *p, > struct vm_area_struct *vma, > struct list_head *to_kill, pgoff_t pgoff) > { > - __add_to_kill(tsk, p, vma, to_kill, 0, pgoff); > + unsigned long addr = vma_pgoff_address(pgoff, 1, vma); > + __add_to_kill(tsk, p, vma, to_kill, addr); > } > > /*