Re: [PATCH 5/8] mm: Make dump_page() take a const argument

[David Hildenbrand <david@redhat.com>]

On 27.02.24 20:23, Matthew Wilcox (Oracle) wrote:
> Now that __dump_page() takes a const argument, we can make dump_page()
> take a const struct page too.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
>   include/linux/mmdebug.h | 2 +-
>   mm/debug.c              | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
> index 7c3e7b0b0e8f..39a7714605a7 100644
> --- a/include/linux/mmdebug.h
> +++ b/include/linux/mmdebug.h
> @@ -10,7 +10,7 @@ struct vm_area_struct;
>   struct mm_struct;
>   struct vma_iterator;
>   
> -void dump_page(struct page *page, const char *reason);
> +void dump_page(const struct page *page, const char *reason);
>   void dump_vma(const struct vm_area_struct *vma);
>   void dump_mm(const struct mm_struct *mm);
>   void vma_iter_dump_tree(const struct vma_iterator *vmi);
> diff --git a/mm/debug.c b/mm/debug.c
> index 96555fc78f1a..6149944016a7 100644
> --- a/mm/debug.c
> +++ b/mm/debug.c
> @@ -143,7 +143,7 @@ static void __dump_page(const struct page *page)
>   	__dump_folio(foliop, &precise, pfn, idx);
>   }
>   
> -void dump_page(struct page *page, const char *reason)
> +void dump_page(const struct page *page, const char *reason)
>   {
>   	if (PagePoisoned(page))
>   		pr_warn("page:%p is uninitialized and poisoned", page);

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb