From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 116B0C5478C for ; Fri, 1 Mar 2024 11:26:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B98F6B0085; Fri, 1 Mar 2024 06:26:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 969B46B0087; Fri, 1 Mar 2024 06:26:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8319F6B0088; Fri, 1 Mar 2024 06:26:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7238F6B0085 for ; Fri, 1 Mar 2024 06:26:18 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 51333140499 for ; Fri, 1 Mar 2024 11:26:18 +0000 (UTC) X-FDA: 81848241636.03.C1CD249 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 2E5B120005 for ; Fri, 1 Mar 2024 11:26:16 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Kr6m+2s5; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709292376; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LPU8/Ax3sCA2MS0ovB0CWJoFbkzPo22D0ikZEgIjV1M=; b=yIf7pfl5lb38eor+WzmSGB3r911V6OvH6YxjeAKVT/+G8IzrgkAOfRushJP9CY1YZj1CUQ 7p8IVTTpyUTAU0fCqIz5y0U1oI7a90rv1cCkG3gCnfcrzzIZK3xMOW6OKET18HR/ldPSqv K+p0EJcjGp4YG+X+jMGQSKSRQBWNmcQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Kr6m+2s5; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709292376; a=rsa-sha256; cv=none; b=vRHdONp8r6wvuIG+ZsKyY0YEf0TY9Y2ai41Flr1IHkoBvPgZEcBKoS5ywDqvJfd+xhVX2z zNaDn9oxLOeUjlzTvXJyL0D8Zti5U6cL7r5uKe0ItMvivP7m1nwXgsKZbYce2V3U2e4Q/O /xPb4jQjWy+CUhiyu/3jdjMxJVlh960= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709292375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LPU8/Ax3sCA2MS0ovB0CWJoFbkzPo22D0ikZEgIjV1M=; b=Kr6m+2s5yfzQiMu+zJo/XWTwibKXAo3tyZXPlhgen+D+wTKjJp0xyga+axXORnWKYc7Kht uhJGCKCbgTQMJnHS75fH0LBZXNTLd2eIL1b9UhXIrGyUH7EaS8J0fW2RJ9v6A5wRcCiHkz V5kxJFJXB/FQFr/Km9HWP2sQGvrgqr8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-204-zqn2dFJbO-yvx-zwY79_XQ-1; Fri, 01 Mar 2024 06:26:14 -0500 X-MC-Unique: zqn2dFJbO-yvx-zwY79_XQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-412bb0a770bso9729035e9.2 for ; Fri, 01 Mar 2024 03:26:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709292373; x=1709897173; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LPU8/Ax3sCA2MS0ovB0CWJoFbkzPo22D0ikZEgIjV1M=; b=Mm48VWwUJZEjUJv+XhsG7wzYxMrykaz7yHEjbvVbzpW56XyhEmNYEhC/eldur2fEMc vyoTUcnJbkfqPlwoc8XWPi9Tr2IEqAyXPsri3H+y3EhKYh9cAYTiAHcYL9QKkP+s4kek 8vh93YgluxjtzxbTi6VocQzHLQXDArCXJK01bX/ky3LQw05EK9E7esRUYuuBM5JegZM3 Fix+uK6shZYRDAXkBdUEDQzAs7+dc+Y4dM4p7K9bl4mUss9zy/VQFLVw1L5lBPOX7gbl FUhVNxIhtY/eXsI0nm2bav3XNSe9B5UVIA2zBqdw1G4OK29vlOkwP7CUTjP7Ne+tY1YN WCDA== X-Gm-Message-State: AOJu0YwqMh4dh2xa360tlr9n8yRTfZMgiNKxt5Ra46acFOkw71HFUqBl wSC3cReXqLeZbP7I6ehyaJwy1N4bbp6rt/iYndWK8CDv5tRIHRdT/LBLqa3vLDr3FwRkz68UpSR a751cFaFF0Vi9LRCgyvL9KQC9Q0CZc8+mCAB9yhHk3yMOwVzImcWGRVFn X-Received: by 2002:a05:600c:3b98:b0:412:b6cc:4e5e with SMTP id n24-20020a05600c3b9800b00412b6cc4e5emr1112324wms.32.1709292372956; Fri, 01 Mar 2024 03:26:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IHpuAcznkLyhqj+vWDMR7mO9lavQEQgPA2ITOR3NuW0aBL8gBrq1wSmGOaEOQYUSMZN50BaQA== X-Received: by 2002:a05:600c:3b98:b0:412:b6cc:4e5e with SMTP id n24-20020a05600c3b9800b00412b6cc4e5emr1112310wms.32.1709292372583; Fri, 01 Mar 2024 03:26:12 -0800 (PST) Received: from ?IPV6:2003:cb:c713:3200:77d:8652:169f:b5f7? (p200300cbc7133200077d8652169fb5f7.dip0.t-ipconnect.de. [2003:cb:c713:3200:77d:8652:169f:b5f7]) by smtp.gmail.com with ESMTPSA id bx5-20020a5d5b05000000b0033e103eaf5bsm4120422wrb.115.2024.03.01.03.26.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Mar 2024 03:26:12 -0800 (PST) Message-ID: <35cbb118-a8d0-499d-a21b-c8e528f8eb40@redhat.com> Date: Fri, 1 Mar 2024 12:26:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] mm: Make dump_page() take a const argument To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20240227192337.757313-1-willy@infradead.org> <20240227192337.757313-6-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240227192337.757313-6-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2E5B120005 X-Rspam-User: X-Stat-Signature: eqstgk9jdr345t94t3ry5bfd98axtngo X-Rspamd-Server: rspam01 X-HE-Tag: 1709292376-411889 X-HE-Meta: U2FsdGVkX1909xu+Dhy9oiTsN1YY5URDDIzuaeGGalQxiTigv5UYp7Y478CaJCvMXHEipTuWzJ0zpBeStb0NYtDFtkjyskEyUCDqF9IQ7gRA3Nw97tcf5QH4zv2/Rqk8XBb3bNeggCT5+tIvus98yumeAbbRC8J9BGR4JZE+d3mQZUXc2k8dLG/m5Sgd7EI+C1WrYHF0SWWQUPyW6I1UOqA1T9wa0WXfaM9WJIzBnHgIQqMpWqu4KuHw5BrSWnRkNHtvqdkGp0GXzIoXX4sCE48xeXqaAd323qyTrmMJsh8mtgoliA5blvz2nKR/FsmgMVu9MV1O7gmNU4TPA0ZEHFag4pZRrzhL54kG2/wb+6t7uQ14MThgAwD81VsqrjiFhKjAnjCbeBjXqbtTuHB0Xm8rYwy16MI6HjSdCtvZtxC6lVfLRIGzQ/oeJICPYB1dAPo1MJ3m5bxu1z5j679YXzzJOYADODA9g7yIOCoWzfXzsj+5hQo3+RGsxMzCE1ZTjNVHFobPHdsd1oIKgFWi5VNxGpswJX8r7CsLWF1phmPrebBrvtP+/Js4Ki1EzQXlFUYgzxWKQQ5/0NIXNcpkhLUGVV7LZK+9wrR0++hABaUjPjfZ/RD6C2tZQsIbJx7XWV8CyAJEPZhtTaqnX6atApLBEItBucI8eaItBImKrvhfUM2iR9w5lO/J5Aitd28QTb9kemvpG6b51w+sos2P9c+dwokNaGXoGsJNeOM1AQJpV2hTCE3JvjDFktKNo3wR5jynkKFKpui8CTiD5xVTGFsPCQAhKusULjsfKj8Za7htMUrBmXjgEMeuqVPBfMlmEXM9/W0b99GB9ExlOkdGWX9og1KfLYot45pPRHgxoPsyIfkthyP++28WHxysGwOBnfVIWHOA9VpQRF9cZqJxmsQvCeAEoGFzSRDIdu3FVLkKW1Aahi5nePp1GBLhFLBkXkh98j4S8wxivZ61LFf Rt8b2epl TPV4QFH2TFRc5qOj+tUcNF4BCEqtjeOyeNhrOlbvcuQHdamWSyShnc5U4hjUJnpJSZG5qPFjTuzZRKmL7N6CnaIBjfvSUnZDyBLaTEI9yysa8jP6pYwPTulv6Lg3w7MgprkHOfE7N0Zgd209wOXI4o8GtR2IP5am8zIXrn/kNX5oPNH0PFvYCKPDwVjIMwmlrEs02+v1HoXYO+hj7ClSMCQy81jYHgKq+q00GH2e1FaFr/ypHxH6G+5xgc+vW/qzEVxOo+kwRzJqvRQkCYhpJStjGY+fvzvLtmiLGZDwNxa6DpCPsFoHsu7AD0NkKZr+uvtZwSU0cdd2FtBzMe1AqNtzoHxVUf/6u8d/UIqhe4Og7tdq7UNy4okLc330W5Jdwfu3j5TCMXghkxLMWDVA5XKnBV9GmGowQvb8B5dgZpbVMhNb5MVbAQttxDvlYtpREO8pirYmnlJ3gKlDNOD6OrgaTkDewVfgCsVHVK4FfSCJuFAI7dycj1gnUdf7BmjzSaHmAhqXls+y2fHGmHgnS5A9r+t5ausb5OUTHhQnjl+mpvHs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.02.24 20:23, Matthew Wilcox (Oracle) wrote: > Now that __dump_page() takes a const argument, we can make dump_page() > take a const struct page too. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/mmdebug.h | 2 +- > mm/debug.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h > index 7c3e7b0b0e8f..39a7714605a7 100644 > --- a/include/linux/mmdebug.h > +++ b/include/linux/mmdebug.h > @@ -10,7 +10,7 @@ struct vm_area_struct; > struct mm_struct; > struct vma_iterator; > > -void dump_page(struct page *page, const char *reason); > +void dump_page(const struct page *page, const char *reason); > void dump_vma(const struct vm_area_struct *vma); > void dump_mm(const struct mm_struct *mm); > void vma_iter_dump_tree(const struct vma_iterator *vmi); > diff --git a/mm/debug.c b/mm/debug.c > index 96555fc78f1a..6149944016a7 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -143,7 +143,7 @@ static void __dump_page(const struct page *page) > __dump_folio(foliop, &precise, pfn, idx); > } > > -void dump_page(struct page *page, const char *reason) > +void dump_page(const struct page *page, const char *reason) > { > if (PagePoisoned(page)) > pr_warn("page:%p is uninitialized and poisoned", page); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb