From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBFC1C83F1B for ; Mon, 14 Jul 2025 15:27:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AF1D8D0010; Mon, 14 Jul 2025 11:27:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55CF68D0001; Mon, 14 Jul 2025 11:27:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 424DB8D0010; Mon, 14 Jul 2025 11:27:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2C3A98D0001 for ; Mon, 14 Jul 2025 11:27:02 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CE4C31A01F3 for ; Mon, 14 Jul 2025 15:27:01 +0000 (UTC) X-FDA: 83663248242.03.77B4F06 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id 9AAC2140006 for ; Mon, 14 Jul 2025 15:26:59 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=SE3SddxO; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=u4d0yk6R; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UMphqWFs; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="4wOlm/q1"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf26.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752506819; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4r6WQrf9B06ZXx01gkGQoiXd/J1IoGxJsRrJoLtPvLM=; b=NIyrITo3yEIXZn703kCmhO7ZCj1I0dsAX11WvWDyVqj1U6WqlfeMI3jVXgTwg5QrAQ1Aup OOQnZ2ao4+bdPmeMFu9MUv65NoXzY+ZVzQMY0KcagrRvGUfAQaWQ2+DFiU2kZF607MtL6J FQcxLQgXloZ5kBM7jm59q59PCS5j0Dg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752506819; a=rsa-sha256; cv=none; b=VJEI+ytQ/p/Yg8OqidGXkTYcvMSTGSeMZ8wjBjIaVq2l3snJoQV8RlvQxp+GqDXq08bgVe WfwVcHBPMmcEpP/a4vBJoZzXnrjPBbcitdPWot/oIvleLaJ3iMz3WFdCYzH/A7Uj1nI0I8 tLouDuWAaAGlBmZh5lG9NSIM3iIscNY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=SE3SddxO; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=u4d0yk6R; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UMphqWFs; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="4wOlm/q1"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf26.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DB17A2125D; Mon, 14 Jul 2025 15:26:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752506818; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4r6WQrf9B06ZXx01gkGQoiXd/J1IoGxJsRrJoLtPvLM=; b=SE3SddxOCTwN1L/MmCMb7LwPLOViMLfWaxLUIdzbh4U6qWYjky0OIdDg48ZQEIAdTO/+kq XAXFCvlnIuXI5AuOziuxrkbwJFU7f7JgNk1Db1nHZRCRywSwS0N7iDYSwjdwlQVzyPNJ9G 3MgvfX6pA40Rpzklqg6px5/xwlmNOEM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752506818; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4r6WQrf9B06ZXx01gkGQoiXd/J1IoGxJsRrJoLtPvLM=; b=u4d0yk6R6ldBuBEAZ2Sl/CwCLcUmO4YQqCmc2c1Z4XfRikEScj81BvLv4HUsNPOh3jMWIY Pp4N1VXwYKF+fTCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752506817; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4r6WQrf9B06ZXx01gkGQoiXd/J1IoGxJsRrJoLtPvLM=; b=UMphqWFsu4UhqLwUOLBxsvdGH9BY0EaXQse0B4fg/8I5iPWnVI9g3GyDHTLI2qSjMg5Xtd CCiJtXdgiJo9XRRXLiXv7/QdbGpS9VebtQEtQIrnoFPAdKyJn/v1AYia2vOsSe02sofu4T tRVhrWCOVWG1biNWSVAafp7F+WaeaIY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752506817; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4r6WQrf9B06ZXx01gkGQoiXd/J1IoGxJsRrJoLtPvLM=; b=4wOlm/q1lR3EwH0TVqNlwc1ll8I34amY4R+Yy6Q316IyOqFb/qsS2RzwSHZ+so2nccLIhD qEz4izHjOMk0OiBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 25E62138A1; Mon, 14 Jul 2025 15:26:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CDM7BcEhdWh6NQAAD6G6ig (envelope-from ); Mon, 14 Jul 2025 15:26:57 +0000 Date: Mon, 14 Jul 2025 16:26:55 +0100 From: Pedro Falcato To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , David Hildenbrand , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jeff Xu Subject: Re: [PATCH 5/5] mm/mseal: rework mseal apply logic Message-ID: <363qa5eh6npsayupoovhetjco25mrslwzxai5nh4pkm2ept2ej@okwehntdckfr> References: <7ff13c42220bc3fc19610e93d5b73637146aa7ae.1752497324.git.lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ff13c42220bc3fc19610e93d5b73637146aa7ae.1752497324.git.lorenzo.stoakes@oracle.com> X-Rspamd-Action: no action X-Rspamd-Queue-Id: 9AAC2140006 X-Stat-Signature: ukbcpxyzwr34oggce15sgoaqmchrwbuz X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1752506819-502992 X-HE-Meta: U2FsdGVkX1+/dwDgBTO5JuowVRPPPqgY7NUaCpGPIr6pZCjmLH4LGI9AA6fXWr7LZ1TnSxkAE2MX7USSEAWfS5oT8nPLckCQGiJypneDxB+dvScQwGy2t3E8gUEbNYICetl7dDrMz7cNpaUNGMF7fZIi4B1pLKVBCHALO7U8WmPGChnAqMo0pVze7cx8futOaxplftOsXai5GTH6UkWjyV/tyvKBZnctVrrXrrISVQRvgmP7vGhKRC8eUXafc2221cE3m0650NNo3ZGqOUTaM3SYeLHC8StX3QGJs5QZQKsoWxXUOjd6JcWfPgNjpVTRoaKu1qSr2MG4ZCTc5Yv0u6u5vnYP8mxgHzTW0b4C5uZ+6FgovI9bEsK6r4u1IWSE456t9UYwgpsDHXKmIBIwwDPeSAoYdWuEOGeRSQbschq+6GInjUJsT+53OWJlryLvinVcC9srm8Tl8APJlEvhIFdOlwHb29DIwHqqb/dJ9n5p5DojaMWRHubrluij2dVd1xobjBxy795JhdHSMrbUbbwvBx0HAM4eE10Itj9HbMErrrEzTDKXlytDrzz9Ow1tFWXoDYf8G44xiwbsftQP05FFakQMwbd62jUtAoypwAYmL3UHuMjAn0dPq9O7Jw8VRjlDLSLefXTbKsAFCuaLWnYT3Kb79irF53v+FAOzeNkBxCB5AMn6UyC51FMTxUjTxeEOxA12gQCvqDJOW9Ul3aINmLGmkuyUbZtV5sfqNR8X+Yn3UH8t8aVBT+sqaRNZQEuA4/AFhD7osNuI+exgSiZFmgNHwiAqykPZnd7P7SCuZ3T2oYczCb+FcZiBtTCmy52mh/LDP2dhONeb8lrl/hO4uhp93YhgOaOLZ4ZeR1Lw0XtQfCRDvskOQ3fNYEZVNtPR2nbA4cyYhHqnb//h67svmKrZGTS0RorBcjy7hbNbbe5w2k+eyq57T7xj6DOD8U3jL+CrvOeID75JzUF uUolEtbx KwuHCAhLwaMub1y/fVlf5lskPOMTqWApDZNMazdEVyx25K4QvYUb3eukZetzz9Si76rJq5AfqXtcjb4LOT1pg4Zxpj0QVRltkvEL8Zjt7zWd0UYtQ5hH+Lo0NXGVcAD+AqCT9cSU5EKFTpnSyIzOUCMEIJRjl3R7CGjI3oPyaJONY0LUymh8dAZXhTym7mcFQdC2HltxWlGqqac75Grj7STysWqAQDGOFGX3t59Ex5Ga1VmIIK03zQoz5dlv70l+feZjrTEND86VeP7Txm/sQfd5DJ6hFN5z32La0VMR9mAyxT9rVXd/56zH1SFHyXlHNk3h9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 14, 2025 at 02:00:40PM +0100, Lorenzo Stoakes wrote: > The logic can be simplified - firstly by renaming the inconsistently named > apply_mm_seal() to mseal_apply(). > > We then wrap mseal_fixup() into the main loop as the logic is simple enough > to not require it, equally it isn't a hugely pleasant pattern in mprotect() > etc. so it's not something we want to perpetuate. > > We remove some redundant comments, and then avoid the entirely unnecessary > and slightly bizarre invocation of vma_iter_end() on each loop - really > what we want, given we have asserted there are no gaps in the range - is to > handle start, end being offset into a VMAs. This is easily handled with > MIN()/MAX(). > > There's no need to have an 'out' label block since on vma_modify_flags() > error we abort anyway. > > And by refactoring like this we avoid the rather horrid 'pass pointer to > prev around' pattern used in mprotect() et al. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Pedro Falcato Thanks for the cleanup all around :) -- Pedro