From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D15CC32793 for ; Tue, 23 Aug 2022 08:14:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AAA28D0001; Tue, 23 Aug 2022 04:14:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05BDA6B0074; Tue, 23 Aug 2022 04:14:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E63E68D0001; Tue, 23 Aug 2022 04:14:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D8F396B0073 for ; Tue, 23 Aug 2022 04:14:56 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B5A681A0305 for ; Tue, 23 Aug 2022 08:14:56 +0000 (UTC) X-FDA: 79830146592.21.725EFF0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 49AAD1C0018 for ; Tue, 23 Aug 2022 08:14:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661242495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q4OFDEuwYbQDCKzuYI2RJrZUWdrjR+wzBeiq9XfU9DY=; b=NJGRx78AZ5BXjmo3t17rnE0xdewSB1AWVgiaRABGTg+ayknv8IZCOto5f3dWUT3Muf0kV8 NPJbMrJ/FlOHRNosmrQErNN2VFbl+liYWULa2/EBRlCckntV9FB4XKsIhuhrFlILkHaVEy aI4CtwL5MNq5B0gqlir2LduwRXBHJpg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-606-IX9hflmpPzm3eFkkmiw-JA-1; Tue, 23 Aug 2022 04:14:53 -0400 X-MC-Unique: IX9hflmpPzm3eFkkmiw-JA-1 Received: by mail-wr1-f72.google.com with SMTP id g11-20020adfa48b000000b002250d091f76so2051657wrb.3 for ; Tue, 23 Aug 2022 01:14:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=Q4OFDEuwYbQDCKzuYI2RJrZUWdrjR+wzBeiq9XfU9DY=; b=71wXNHV24H/7SRKompws+1YJt0vceL76TdN4QJA6/LzkwKS2cprM/X/sF6CDlqc80+ S/f42nUFhNSbezgvS4fsDziZ6EedgagtnrupvEOc+OykFaSjGYhuduiNfXEmXHnaKaKu Uoc3jg3SOzw+4Mdux/WcophsIpD10UEkom0eGoj8Hu+DSLItsLdfuHC/8EATOkRhEv/P V4pIXTW74ATG14/sZuiWhVMdafXjHBAWko1QpJPMlXoPwtq3BJiuI9qvIIp41jIo3+np WtvQfKk4Z3y03WlHeqpyf1AVAtZhO2BzLJwBNzoabPNQcDIPtuTMgIjz3CP3e4rZtyBM VWDA== X-Gm-Message-State: ACgBeo2KFSVczM4LSDiQTLQ4zi2EYdj69z47BgiFFxU62AasW5uSbiQ4 TMdWGQQ1RyE/u+u/HyM6+RMKvarCQvwbeniZi/YmBF0MbEAfSQY+3xtkEv5Rd2ECu/08Jt8YK+w 410OMvAkto+w= X-Received: by 2002:a05:600c:19c8:b0:3a5:ec6a:8d16 with SMTP id u8-20020a05600c19c800b003a5ec6a8d16mr1326390wmq.182.1661242492180; Tue, 23 Aug 2022 01:14:52 -0700 (PDT) X-Google-Smtp-Source: AA6agR56NJF8GDn308rkUs+Zfpk4q4pHfO+tAGT0u5/7P6jaJlCgKT5AD40J8/IGy1sBaecI3jlPaA== X-Received: by 2002:a05:600c:19c8:b0:3a5:ec6a:8d16 with SMTP id u8-20020a05600c19c800b003a5ec6a8d16mr1326371wmq.182.1661242491858; Tue, 23 Aug 2022 01:14:51 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:1600:c48b:1fab:a330:5182? (p200300cbc70b1600c48b1faba3305182.dip0.t-ipconnect.de. [2003:cb:c70b:1600:c48b:1fab:a330:5182]) by smtp.gmail.com with ESMTPSA id bg2-20020a05600c3c8200b003a5e9337967sm17314448wmb.13.2022.08.23.01.14.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 01:14:51 -0700 (PDT) Message-ID: <3661415c-6069-24ed-b647-6fe6993bddae@redhat.com> Date: Tue, 23 Aug 2022 10:14:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 4/5] mm/hugetlb: use PMD page lock to protect CONT-PTE entries To: Baolin Wang , akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <88c8a8c68d87429f0fc48e81100f19b71f6e664f.1661240170.git.baolin.wang@linux.alibaba.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <88c8a8c68d87429f0fc48e81100f19b71f6e664f.1661240170.git.baolin.wang@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NJGRx78A; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661242496; a=rsa-sha256; cv=none; b=fJDM2nG9L9O0VWHbtPq9D9yfAifVCR7tpl7uqMyBkjsowBjdOvQ6YY6wkRPkf2G459EORz g/1XiC4kM5M3YLmQosuMGi4R75DY6pnModgerGjW6/9xsOMU6CdAJbUzpXyKELZLoUEOYL Qhs/rZ6Rxd9jzfrxJu/OSGPonXCw5FE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661242496; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q4OFDEuwYbQDCKzuYI2RJrZUWdrjR+wzBeiq9XfU9DY=; b=Kl6+kjdvkvfiTiClT8cfYQOt4UwJfSXfeHTRe0FKRGZ+QjP2UfVxfTOD/NXkhJFxu+Bt9h PHscUbtIIbSm52yW8abigu3q2NYJqJtk6xJRXKZCaCBJXvo1Q8ZhhL4MVtLjPveTZQSot6 QpOnPO2zEJDXMq5t5Y60GPWL1j2sOj0= Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NJGRx78A; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 49AAD1C0018 X-Stat-Signature: 6rbnbxatakg4mi1erdeoh3z7f9ttntgq X-HE-Tag: 1661242496-308615 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.08.22 09:50, Baolin Wang wrote: > Considering the pmd entries of a CONT-PMD hugetlb can not span on > multiple PMDs, we can change to use the PMD page lock, which can > be much finer grain that lock in the mm. > > Signed-off-by: Baolin Wang > --- > include/linux/hugetlb.h | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 3a96f67..d4803a89 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -892,9 +892,17 @@ static inline gfp_t htlb_modify_alloc_mask(struct hstate *h, gfp_t gfp_mask) > static inline spinlock_t *huge_pte_lockptr(struct hstate *h, > struct mm_struct *mm, pte_t *pte) > { > - VM_BUG_ON(huge_page_size(h) == PAGE_SIZE); > + unsigned long hp_size = huge_page_size(h); > > - if (huge_page_size(h) == PMD_SIZE) { > + VM_BUG_ON(hp_size == PAGE_SIZE); > + > + /* > + * Considering CONT-PMD size hugetlb, since the CONT-PMD entry > + * can not span multiple PMDs, then we can use the fine grained > + * PMD page lock. > + */ > + if (hp_size == PMD_SIZE || > + (hp_size > PMD_SIZE && hp_size < PUD_SIZE)) { > return pmd_lockptr(mm, (pmd_t *) pte); > } else if (huge_page_size(h) < PMD_SIZE) { > unsigned long mask = ~(PTRS_PER_PTE * sizeof(pte_t) - 1); Is there a measurable performance gain? IOW, do we really care? -- Thanks, David / dhildenb