Re: [linux-next:master] [mm] 1111d46b5c: stress-ng.pthread.ops_per_sec -84.3% regression

Yin, Fengwei
2024-01-05T14:52:42Z

On 1/5/2024 5:29 PM, Oliver Sang wrote:
> hi, Yang Shi,
>
> On Thu, Jan 04, 2024 at 04:39:50PM +0800, Oliver Sang wrote:
>> hi, Fengwei, hi, Yang Shi,
>>
>> On Thu, Jan 04, 2024 at 04:18:00PM +0800, Yin Fengwei wrote:
>>>
>>> On 2024/1/4 09:32, Yang Shi wrote:
>>
>> ...
>>
>>>> Can you please help test the below patch?
>>> I can't access the testing box now. Oliver will help to test your patch.
>>>
>>
>> since now the commit-id of
>> 'mm: align larger anonymous mappings on THP boundaries'
>> in linux-next/master is efa7df3e3bb5d
>> I applied the patch like below:
>>
>> * d8d7b1dae6f03 fix for 'mm: align larger anonymous mappings on THP boundaries' from Yang Shi
>> * efa7df3e3bb5d mm: align larger anonymous mappings on THP boundaries
>> * 1803d0c5ee1a3 mailmap: add an old address for Naoya Horiguchi
>>
>> our auto-bisect captured new efa7df3e3b as fbc for quite a number of regression
>> so far, I will test d8d7b1dae6f03 for all these tests. Thanks
>>
>
> we got 12 regressions and 1 improvement results for efa7df3e3b so far.
> (4 regressions are just similar to what we reported for 1111d46b5c).
> by your patch, 6 of those regressions are fixed, others are not impacted.
>
> below is a summary:
>
> No. testsuite test status-on-efa7df3e3b fix-by-d8d7b1dae6 ?
> === ========= ==== ==================== ===================
> (1) stress-ng numa regression NO
> (2) pthread regression yes (on a Ice Lake server)
> (3) pthread regression yes (on a Cascade Lake desktop)
> (4) will-it-scale malloc1 regression NO
> (5) page_fault1 improvement no (so still improvement)
> (6) vm-scalability anon-w-seq-mt regression yes
> (7) stream nr_threads=25% regression yes
> (8) nr_threads=50% regression yes
> (9) phoronix osbench.CreateThreads regression yes (on a Cascade Lake server)
> (10) ramspeed.Add.Integer regression NO (and below 3, on a Coffee Lake desktop)
> (11) ramspeed.Average.FloatingPoint regression NO
> (12) ramspeed.Triad.Integer regression NO
> (13) ramspeed.Average.Integer regression NO

Hints on ramspeed just for your reference:
I did standalone ramspeed (not phoronix) testing on a IceLake 48C/96T +
192GB memory and didn't see the regressions on that testing box (The
testing box was retired at the end of last year and can't be accessed
anymore).

Regards
Yin, Fengwei