From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24D30C5AD49 for ; Fri, 6 Jun 2025 07:28:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 917E06B007B; Fri, 6 Jun 2025 03:28:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EDA56B0088; Fri, 6 Jun 2025 03:28:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 803886B0089; Fri, 6 Jun 2025 03:28:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6307C6B007B for ; Fri, 6 Jun 2025 03:28:29 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D8C8D1201D9 for ; Fri, 6 Jun 2025 07:28:28 +0000 (UTC) X-FDA: 83524147896.20.A5BB527 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 4F02DC000B for ; Fri, 6 Jun 2025 07:28:26 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NPscNTN9; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749194906; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MzU6QKfO94usyKULdWmvLb6fqSscWED5D9l6Eb/I+FQ=; b=oZadvUqg8qAHdkX1YdAzDy3upKYe7s+JjFLXipONi/7WQXEj2JTfgDRqniUN7eKBVvii3e oqf0JT6gNBp8clljNlggd/oZCC9C2Ay57pQPxZ6pKsU+Mou0/Ukl4r/l49kHeR13QeWtjo ltYboe+JuhIQ7aq/G6lvtHdQWt1K+uc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749194906; a=rsa-sha256; cv=none; b=0BMmGU7FWowB81/raxsV2tca8H8Ka+KGRF9Z2958Ib4WMm62n4tpp19chQjyJFic2HZmQT ZtsxA9/M4L+8ewnevcmMOeFaZvYSOZBjOOilG4/hmPBE7WVPXJIZ6/LdMtqv5lJI3H3qb+ gQ7fc58WHzksWmVLoqAmOqgFK2019E0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NPscNTN9; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749194905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MzU6QKfO94usyKULdWmvLb6fqSscWED5D9l6Eb/I+FQ=; b=NPscNTN9AJzG4PvHk7gc8obNHfPzcCHZ+6E8Edi499ToYbKBxYFLzjwvOOiTBGnOGaBcAM kjoU0UKotqE4doOWKuWiorQXBjqNJPIJ2oioirZbl9Au+PvXkdTdfEnVtxTkBEs9C3m42b EkniHV52bGYffE3Uge92evzg9+pmK4U= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-380-cwEcyiyFMQOBHQ_1K8AFxA-1; Fri, 06 Jun 2025 03:28:24 -0400 X-MC-Unique: cwEcyiyFMQOBHQ_1K8AFxA-1 X-Mimecast-MFC-AGG-ID: cwEcyiyFMQOBHQ_1K8AFxA_1749194903 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4f6ba526eso1124234f8f.1 for ; Fri, 06 Jun 2025 00:28:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749194903; x=1749799703; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MzU6QKfO94usyKULdWmvLb6fqSscWED5D9l6Eb/I+FQ=; b=EKysBVaENWKjlvtebn36IJ64EgpqLuFshlScYGTOB1oBiGhVI47lFnzr7VNbRxuCxr OoidxQtlFDkc2SPzJgKaLCMfmBVDIbgU6ttfcAzcnbqib5q/8KDQ5NfEK6HzRrPch4iW hCsU8BrOduiZNL8rKd9FdNUMmzrfpVjCvWv7Jtj1ReBZ5urNBRjtNCw+NpGBuOFuMn/Z nZcJqwTgozgEXLqaDcPG4s2wrZG3l4sOa8DvK/5v8kOQLxlY9osZL77xL6tgGtMDKGkA n5tpnmuLgQYkqL6K8j9z35Ci3Uzn9n5QJyFDxYys6Jj9vWxaNioOerjYUv08q5LKCoqY NM+A== X-Gm-Message-State: AOJu0YyslOtOYjjjkzqBszBsxW17SuEebsH3sklwu/WMjsyGtXQugtQT dDEwt4+cwfjw7q5oPFFJqDIMoWTNsd4ji96cXTl20hBwvsl0YOujyCMz/KSnDNU0Uj3jlRqMvB7 AEI9xxRfvzmRpJvn3b+kDFa94MYwoBezBEkvrQZz/kpPCuKNFV3N2Pq0Mg3vj X-Gm-Gg: ASbGncuwadksmM3/8kgmq52sMGNj49YXiJGctu2Y/llXIZXG2puOQFw4J5dWuBe13Ry JbPZKdwRo7N9IGGiPIiUD6cqFiZQ5tAnRs0HqlhoYc31wjI+r0g7dw5LQLudstV1xIlnHQrLG0X oA9PEcdiMxGp6UuKyYxTYsHFjOo56cP/OLSPFMNuZI2TeUad9WK6FqhLzOWoZQ6wyjLfo+efmcl 8gep7QmGPxbdVE/JZW1xZh7p/HvMvqcDNDeQTAtJ+TYMMCO/PY/oshlVgm7Dw8PONGxJTfNzlO2 /21wscm3FHu/vHj1QStJC1uVgGoauOyrIjJ46ERcfjh44uOVa1umFA== X-Received: by 2002:a05:6000:250d:b0:3a4:f912:862b with SMTP id ffacd0b85a97d-3a5318a0627mr2178092f8f.33.1749194902686; Fri, 06 Jun 2025 00:28:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFaLWomZETgDCELZygyLcC/ojJCXhsOZyZJnL/gBwDuRpfKNSX2ofIkG8V68GPZaYh+LOJmwQ== X-Received: by 2002:a05:6000:250d:b0:3a4:f912:862b with SMTP id ffacd0b85a97d-3a5318a0627mr2178057f8f.33.1749194902217; Fri, 06 Jun 2025 00:28:22 -0700 (PDT) Received: from [192.168.3.141] (p57a1a6a5.dip0.t-ipconnect.de. [87.161.166.165]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53244d15asm1098905f8f.66.2025.06.06.00.28.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 00:28:21 -0700 (PDT) Message-ID: <371ac1ce-8f14-4914-94f5-6e6b46a486fb@redhat.com> Date: Fri, 6 Jun 2025 09:28:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/2] mm/huge_memory: don't mark refcounted pages special in vmf_insert_folio_*() To: Dan Williams , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Andrew Morton , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain References: <20250603211634.2925015-1-david@redhat.com> <68422c7a3a2c2_2491100fe@dwillia2-xfh.jf.intel.com.notmuch> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <68422c7a3a2c2_2491100fe@dwillia2-xfh.jf.intel.com.notmuch> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GI3HrRoTzWqauA7FfukmsaMXTKHBJv6_U0eYEAh-Y0w_1749194903 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4F02DC000B X-Stat-Signature: 8nwm95rabjkoxrwkapypa5se916hy8is X-Rspam-User: X-HE-Tag: 1749194906-681911 X-HE-Meta: U2FsdGVkX1+4xDqOme3k44bMX0aPW/4WzVwJzpxO9QehvFAAA8egK9s03w1WOe7cvgFFoZXoWSbEWATBlfDzBQPqZDXLcUi3LnlySjTI5A98Fsm+RaAucDG5r3xLrph1ZtqrIFf9QHZHRXPJHUUQ+oyvN1F/cgE1WyCDO4/srXwGldyBBjNMS5AMcVkpVDugODjBLLnSMZ8/CSErf4tQKUi9xkkaHvrwyxTBTFTeczVIlY9yjcXodpyzZ+aplLXf6ulpiwKG9p37spwsX1Z86rL95jYzTO9S/cOgJeasRMK4jLo+nYh+vGXofuM7846pI5p9c46hkPCGgd8Y4cadPK7f8znGnKM4BuyvQ5QcT4D+vxfxpxJq1Llw/0SjrfPGJy7aWjssSyRoURY0Us63NS7ZfRLzfYNvdyV4zmCQ6Yvxp3FXyBOjwlUNSQZMhIvcpWlA8Wkx4OxnUp1Yy3IKrn5crFEb1M3RGZNbD80/4q702MNLbTnZwiZOHj+j/nqB2nLNQwYad6K96988ntLmUbayKHcgzPRg8QbeuRpLgDvmzd3gnD18eRSn8Sd1/p8LzJvOxisO3E2MLTzDfGvsMgq+AftXvYSHCg6ebPfH7qD2X1wmkakMRySErNeNZb4Wqgwm1Rte7q9KoLvoo4c8lnnjAwMr4kdMd95kdN6Ekbg1yPFQ6endWqra74vTLH5iwN0XA8dxFxGXLx4dmVw7vJ9IwhowQZmlgm7q5MsYGcLdFCRYJXfC4Lgm+W6WbNFeUCSd0Rn1RW2gqLVA50e9AZ8icCVLFSkT1hmpMI16ldsJsPrRSjwyr08aetj+w87PW+zgrOWMvez7QKxUr/qkesUY9/RX8WDXOY8NBN3CZMnwc2hjhtUg+SDNgZddldaP7tpHeJfJTDZXW5RuH0G4i1WUKyJOgAcYu1Obp7BTXW+/X1HBKOTIU0+QxCD8HUOrV67cMyP1usRDMN3kURw UcpB/B7b Fkr5lmt4z1NRkydlMaL7fxfvHCnoKpn43jMUhtMsrFv0AhHM9TEWXtVFBb+3Ibv8SFzsJMhmQ5PjEFhBmd9zJCQPa5e+FvSEn43+6TK/9HchjDH9U4/Qm1TYhc1xTlDHJPdSriREwGHdSuZ0KwqOVodnFBNOdJpuJA1d/I+X3q2EiuLUedQ84PT2OqEmBcgClZKV8oysv8GuKQRC/OxEw9irg7Obzy8UqH7pEL9pn+dEOrewvC8v1/H0F51OohhiT0UchgriSv8rcrJgXrdXi397G71l1hQ+cIi40u/AsBRrN9PpEKvr0FDOw1uetHqL1KVvx5YYj+yNcvchNeWN/7xvIeo+X7XraK0VDg84dwheOIXfP051lLr07L1EgMo1Xm5NWmrg6xIV4b7tIkpQP9JTWjiRRVkQlIj3DGcvOvQetM8ylmhHMeZNfprUrJpXBRdVGXtpSWhRgiZ9vHXYGkwIeC+WtIiki4lxaXBzUOmMIz+v+g2W9kezzEDT9lVhtc/BECsOzvz5hIMo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Dan, On 06.06.25 01:47, Dan Williams wrote: > David Hildenbrand wrote: >> Based on Linus' master. >> >> While working on improving vm_normal_page() and friends, I stumbled >> over this issues: refcounted "normal" pages must not be marked >> using pmd_special() / pud_special(). >> >> Fortunately, so far there doesn't seem to be serious damage. >> >> This is only compile-tested so far. Still looking for an easy way to test >> PMD/PUD mappings with DAX. Any tests I can easily run? > > The way I test this I would not classify as "easy", it is a bit of a pain > to setup, but it is passing here: I guess most of the instructions are in https://github.com/pmem/ndctl ? I would assume that we need to set aside some special dax area using early boot params (memmap=). Might come in handy in the future. > > [root@host ndctl]# meson test -C build --suite ndctl:dax > ninja: Entering directory `/root/git/ndctl/build' > [168/168] Linking target cxl/cxl > 1/13 ndctl:dax / daxdev-errors.sh OK 14.30s > 2/13 ndctl:dax / multi-dax.sh OK 2.89s > 3/13 ndctl:dax / sub-section.sh OK 8.40s > 4/13 ndctl:dax / dax-dev OK 0.06s > 5/13 ndctl:dax / dax-ext4.sh OK 20.53s > 6/13 ndctl:dax / dax-xfs.sh OK 20.34s > 7/13 ndctl:dax / device-dax OK 11.67s > 8/13 ndctl:dax / revoke-devmem OK 0.25s > 9/13 ndctl:dax / device-dax-fio.sh OK 34.02s > 10/13 ndctl:dax / daxctl-devices.sh OK 3.44s > 11/13 ndctl:dax / daxctl-create.sh SKIP 0.32s exit status 77 > 12/13 ndctl:dax / dm.sh OK 1.33s > 13/13 ndctl:dax / mmap.sh OK 85.12s > > ...ignore the SKIP, that seems to be caused by an acpi-einj regression. Thanks for running these tests! > > However, how about not duplicating the internals of insert_pfn_p[mu]d() > with something like the below. Either way you can add: I considered that, but I prefer the current end result where we cleanup the pmd_none() handling and not mess with folios and pfns at the same time. ... just like we do for insert_pfn() vs. insert_page(), I don't think these code paths should be unified. (we should do more sanity checks like validate_page_before_insert() etc., but that's something for another day :) ) > > Tested-by: Dan Williams > Reviewed-by: Dan Williams Thanks! Let me resend with the fixup squashed. -- Cheers, David / dhildenb