From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f199.google.com (mail-wr0-f199.google.com [209.85.128.199]) by kanga.kvack.org (Postfix) with ESMTP id 3850D6B0007 for ; Tue, 24 Apr 2018 15:03:48 -0400 (EDT) Received: by mail-wr0-f199.google.com with SMTP id i11-v6so776148wre.16 for ; Tue, 24 Apr 2018 12:03:48 -0700 (PDT) Received: from lithops.sigma-star.at (lithops.sigma-star.at. [195.201.40.130]) by mx.google.com with ESMTPS id b1si4049560edb.360.2018.04.24.12.03.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 12:03:45 -0700 (PDT) From: Richard Weinberger Subject: Re: vmalloc with GFP_NOFS Date: Tue, 24 Apr 2018 21:03:43 +0200 Message-ID: <3732370.1623zxSvNg@blindfold> In-Reply-To: <20180424162712.GL17484@dhcp22.suse.cz> References: <20180424162712.GL17484@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="nextPart26752059.sMrGihSObH" Content-Transfer-Encoding: 7Bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: LKML , Artem Bityutskiy , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Cyrille Pitchen , Theodore Ts'o , Andreas Dilger , Steven Whitehouse , Bob Peterson , Trond Myklebust , Anna Schumaker , Adrian Hunter , Philippe Ombredanne , Kate Stewart , Mikulas Patocka , linux-mtd@lists.infradead.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mm@kvack.org This is a multi-part message in MIME format. --nextPart26752059.sMrGihSObH Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Dienstag, 24. April 2018, 18:27:12 CEST schrieb Michal Hocko: > fs/ubifs/debug.c This one is just for debugging. So, preallocating + locking would not hurt much. > fs/ubifs/lprops.c Ditto. > fs/ubifs/lpt_commit.c Here we use it also only in debugging mode and in one case for fatal error reporting. No hot paths. > fs/ubifs/orphan.c Also only for debugging. Getting rid of vmalloc with GFP_NOFS in UBIFS is no big problem. I can prepare a patch. Thanks, //richard --nextPart26752059.sMrGihSObH Content-Transfer-Encoding: 7Bit Content-Type: text/html; charset="us-ascii"

Am Dienstag, 24. April 2018, 18:27:12 CEST schrieb Michal Hocko:

> fs/ubifs/debug.c

 

This one is just for debugging.

So, preallocating + locking would not hurt much.

 

> fs/ubifs/lprops.c

 

Ditto.

 

> fs/ubifs/lpt_commit.c

 

Here we use it also only in debugging mode and in one case for

fatal error reporting.

No hot paths.

 

> fs/ubifs/orphan.c

 

Also only for debugging.

Getting rid of vmalloc with GFP_NOFS in UBIFS is no big problem.

I can prepare a patch.

 

Thanks,

//richard

--nextPart26752059.sMrGihSObH--