public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: "Lorenzo Stoakes (Oracle)" <ljs@kernel.org>
Cc: Lance Yang <lance.yang@linux.dev>,
	syzbot <syzbot+8961cb270ae74b4129fb@syzkaller.appspotmail.com>,
	willy@infradead.org, baolin.wang@linux.alibaba.com,
	npache@redhat.com, linux-mm@kvack.org, baohua@kernel.org,
	ryan.roberts@arm.com, syzkaller-bugs@googlegroups.com,
	dev.jain@arm.com, ziy@nvidia.com, linux-kernel@vger.kernel.org,
	Liam.Howlett@oracle.com, akpm@linux-foundation.org
Subject: Re: [syzbot] [mm?] kernel BUG in collapse_scan_file
Date: Thu, 19 Mar 2026 11:59:57 +0100	[thread overview]
Message-ID: <37b48d94-9576-4529-8576-d4ed615d4768@kernel.org> (raw)
In-Reply-To: <ecedbb39-2df6-4300-99de-a56c7490c3d9@lucifer.local>

> We shouldn't, really, be just ignoring splatting kernels like that. At least
> that's my personal point of view on it.

Yes, we shouldn't.

> 
> But anyway I really don't have the time or energy to try to track this down or
> push on this further.

The problem I'm having is that reverting the commit might hide a real
problem, and understanding weather there is a real problem requires ...
real work.

Willy said

"It *might* still be safe in this instance; I'll look
at this carefully for a bit and decide how best to fix it."

That likely didn't happen.

Later he said:

"But this is a long and complicated function (over 400 lines!) and I
don't know if fixing this one way or the other would serve to make other
bugs more likely or expose some future problem to the debugging code."

with

"This isn't the kind of thing where you can just jump in with a one line
patch and actually be helpful, sorry."

So I am clueless if there is a real problem there or whether it's just a
false positive. And whether (if it's a real problem) the simple fix
would actually be a good temporary fix ("make other bugs more likely").

I can try finding some time to look into that, but pagecache code is not
particularly the code I'm familiar with ...

-- 
Cheers,

David


  reply	other threads:[~2026-03-19 11:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19  7:20 [syzbot] [mm?] kernel BUG in collapse_scan_file syzbot
2026-03-19  7:22 ` David Hildenbrand (Arm)
2026-03-19  8:05 ` Lance Yang
2026-03-19  8:53   ` Lorenzo Stoakes (Oracle)
2026-03-19  9:00     ` David Hildenbrand (Arm)
2026-03-19  9:14       ` Lance Yang
2026-03-19  9:21         ` David Hildenbrand (Arm)
2026-03-19 10:27           ` Lorenzo Stoakes (Oracle)
2026-03-19 10:59             ` David Hildenbrand (Arm) [this message]
2026-03-19 11:07               ` Lorenzo Stoakes (Oracle)
2026-03-19 11:10                 ` David Hildenbrand (Arm)
2026-03-19 11:12                   ` Lorenzo Stoakes (Oracle)
2026-03-19 10:56   ` Vlastimil Babka
2026-03-19 11:04     ` Lorenzo Stoakes (Oracle)
2026-03-19 12:17     ` Mark Brown
2026-03-20 12:39       ` Mark Brown
2026-03-20 13:17 ` Lorenzo Stoakes (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37b48d94-9576-4529-8576-d4ed615d4768@kernel.org \
    --to=david@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=dev.jain@arm.com \
    --cc=lance.yang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=npache@redhat.com \
    --cc=ryan.roberts@arm.com \
    --cc=syzbot+8961cb270ae74b4129fb@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=willy@infradead.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox