From: Zhouping Liu <zliu@redhat.com>
To: Andrea Arcangeli <aarcange@redhat.com>,
Hugh Dickins <hughd@google.com>, Mel Gorman <mgorman@suse.de>,
David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Amos Kong <akong@redhat.com>
Subject: THP: AnonHugePages in /proc/[pid]/smaps is correct or not?
Date: Mon, 1 Apr 2013 04:00:27 -0400 (EDT) [thread overview]
Message-ID: <383590596.664138.1364803227470.JavaMail.root@redhat.com> (raw)
In-Reply-To: <1207916095.642011.1364800448075.JavaMail.root@redhat.com>
Hi all,
I found THP can't correctly distinguish one anonymous hugepage map.
1. when /sys/kernel/mm/transparent_hugepage/enabled is 'always', the
amount of THP always is one less.
Testing code:
---- snip --------
unsigned long hugepagesize = (1UL << 21);
int main()
{
void *addr;
int i;
printf("pid is %d\n", getpid());
for (i = 0; i < 5; i++) {
addr = mmap(NULL, hugepagesize, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANON, -1, 0);
if (addr == MAP_FAILED) {
perror("mmap");
return -1;
}
memset(addr, i, hugepagesize);
}
sleep(50);
return 0;
}
------ snip ----------
the /proc/[pid]/smaps show that Anonymous is 10240kB but AnonHugePages is 8192Kb, one THP less:
----- snip --------
7f59ccc01000-7f59cd601000 rw-p 00000000 00:00 0
Size: 10240 kB
Rss: 10240 kB
Pss: 10240 kB
Shared_Clean: 0 kB
Shared_Dirty: 0 kB
Private_Clean: 0 kB
Private_Dirty: 10240 kB
Referenced: 10240 kB
Anonymous: 10240 kB
AnonHugePages: 8192 kB
Swap: 0 kB
KernelPageSize: 4 kB
MMUPageSize: 4 kB
Locked: 0 kB
VmFlags: rd wr mr mw me ac hg
------- sinp ---------
2. when /sys/kernel/mm/transparent_hugepage/enabled is 'madvise', THP can't
distinguish any one anonymous hugepage size:
Testing code:
-------- snip --------
unsigned long hugepagesize = (1UL << 21);
int main()
{
void *addr;
int i;
printf("pid is %d\n", getpid());
for (i = 0; i < 5; i++) {
addr = mmap(NULL, hugepagesize, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANON, -1, 0);
if (addr == MAP_FAILED) {
perror("mmap");
return -1;
}
if (madvise(addr, hugepagesize, MADV_HUGEPAGE) == -1) {
perror("madvise");
return -1;
}
memset(addr, i, hugepagesize);
}
sleep(50);
return 0;
}
--------- snip ----------
The result is that it can't find any AnonHugePages from /proc/[pid]/smaps :
-------------- snip -------
7f0b38cd0000-7f0b396d0000 rw-p 00000000 00:00 0
Size: 10240 kB
Rss: 10240 kB
Pss: 10240 kB
Shared_Clean: 0 kB
Shared_Dirty: 0 kB
Private_Clean: 0 kB
Private_Dirty: 10240 kB
Referenced: 10240 kB
Anonymous: 10240 kB
AnonHugePages: 0 kB
Swap: 0 kB
KernelPageSize: 4 kB
MMUPageSize: 4 kB
Locked: 0 kB
VmFlags: rd wr mr mw me ac
----------- snip ----------
3. when I made the address aligned with HUGEPAGESIZE using 'posix_memalign()' instead of mmap(),
THP perform good, and can distinguish all anonymous huge pages.
my question is:
1. all the above behaviour is right?
2. why THP can't distinguish one naturally aligned huge page(generated by mmap())?
--
Thanks,
Zhouping
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next parent reply other threads:[~2013-04-01 8:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1207916095.642011.1364800448075.JavaMail.root@redhat.com>
2013-04-01 8:00 ` Zhouping Liu [this message]
2013-04-01 22:23 ` THP: AnonHugePages in /proc/[pid]/smaps is correct or not? David Rientjes
2013-04-02 3:09 ` Zhouping Liu
2013-04-02 3:40 ` Lin Feng
2013-04-02 3:44 ` David Rientjes
2013-04-02 3:48 ` Zhouping Liu
2013-04-02 12:23 ` Simon Jeons
2013-04-02 18:09 ` David Rientjes
2013-04-02 23:58 ` Simon Jeons
2013-04-02 12:26 ` Simon Jeons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=383590596.664138.1364803227470.JavaMail.root@redhat.com \
--to=zliu@redhat.com \
--cc=aarcange@redhat.com \
--cc=akong@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).