From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7616CF6D2D for ; Wed, 2 Oct 2024 13:46:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FE966B03B9; Wed, 2 Oct 2024 09:46:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AE726B03BA; Wed, 2 Oct 2024 09:46:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44FBE6B03BB; Wed, 2 Oct 2024 09:46:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1E6806B03B9 for ; Wed, 2 Oct 2024 09:46:48 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A6353805BA for ; Wed, 2 Oct 2024 13:46:47 +0000 (UTC) X-FDA: 82628787654.27.7AEA2FD Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf13.hostedemail.com (Postfix) with ESMTP id 92FB220016 for ; Wed, 2 Oct 2024 13:46:45 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dG1DTvUC; spf=pass (imf13.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727876740; a=rsa-sha256; cv=none; b=iSXLWMlI7sXK6rZ4BN9dpPz1WIVVY7kgBk6VeCfYjCoIdNQVfQwF4H9ZyA2wiMze74Fa5d 3kwIGCw6fYHXJ1o7AEgu7uQQRMnLy/ccx8lIGPZrpRdFFNLPZcNPDTguUKT66SOiPVhJ+4 TMFnAteK4ujbVRUAr03Fhv3in14ya0c= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dG1DTvUC; spf=pass (imf13.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727876740; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TZiKLk+pldOod8+CZW2Q8qiPBGtS4WTMmt/umDCQNt8=; b=eUWHa/f08aH4BJuNRwRDFvY8Ioia3y8x8+auoZ1h7Q+6AeU88So0jWXefBCHr3kh2UqTD1 QemfhwpDxzi6ZpIXabicIzR7L/BHUDiQjK0+0FodTM7FCliT+iaUh18Qx7ktFm+8RndorE +hSVkMMAiLwPpYzqW4Q9CfN4ZrBMxiU= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-20aff65aa37so53380115ad.1 for ; Wed, 02 Oct 2024 06:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727876804; x=1728481604; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=TZiKLk+pldOod8+CZW2Q8qiPBGtS4WTMmt/umDCQNt8=; b=dG1DTvUCa8qcPkzQszCyBZ48OiKmTdYQwzXpGBRYzOHCBwxRdI9BvopMhcRRIusC+Q rZkduylLKtJftN9Yw7JtvVIFeaXRN+IJBvaS0ngUmaFCki69Nq6qGs7LP4MSDAR9AHzd eGJxCnwP4cQEJSrSTdWa58qe/8Ut/1gM4G35awSxSvINHPdtaPrMCG48fZ/vcNdMxjBA 8Gm/AD5HhtTzDXZ/YT6Z/gFW4oIuAIJN9j+340PqX0yyKGpNPRAXKR4+5lVEouu0/GLF 5CrByvqRrO7iP0wsRfTH1QkGhtoHNmKqAZSXeP26lA/O7A4wUqMvkyIklfCh+uVlIZln VMmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727876804; x=1728481604; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TZiKLk+pldOod8+CZW2Q8qiPBGtS4WTMmt/umDCQNt8=; b=j9lPEp+d3/G0wuXNBEVq90ZlAJYsy0sXF2cB2zcZM75dHJygHIiAMCzJYwJevfpgxk M/kQk2th4lcm72IxHSbSJU2BFys36A1e8sETYZnrhbq39rkxVJJK4R+gzfxSh7AR40cn 3a8WW2sbgLzcMv8j3LVwHLcJeikk5Afag8JU+0n9YCdV7Z9NTWnhnPpegvbjrwH1DMmJ oFkJ4kbs7LTweOBH3YzCrofqiMUMIwmyxMBe3G6nPdhW7OOkampXeJ2/sgCFhJ5AzA0C X1ReENegeoYp8thFqxt4jQIZaKfuG2CKvwkKcf1btRr4CL5mJAYkcdnZYjZg1TS+MsHL +qWg== X-Forwarded-Encrypted: i=1; AJvYcCVfR/F9IySiTBPCBZfAqtqcrgVAjt2Rxtc9/nD2Mo8s8ZXSg4u46pF4osk1kyiofWUd4OmHNsIAcA==@kvack.org X-Gm-Message-State: AOJu0Yy0E/EzEuPHKafnBuuw7MBbyB3AhnGR8JCavb7TBaCLWcfizENl XAL1hKdWKj9dWCEVFbc7EMSBlF0grzHufLYYO8CREa0lYlc1SZ4x X-Google-Smtp-Source: AGHT+IGOIrt9h9YiJHWd+EI/3hVBa3Fizjqx+qD/0u9C5JJevMtgnKy+dkhUaYBKi3oSododR0ct5Q== X-Received: by 2002:a17:902:e54b:b0:206:96bf:b0cf with SMTP id d9443c01a7336-20bc54c214bmr48473555ad.0.1727876804003; Wed, 02 Oct 2024 06:46:44 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20b37e0fd99sm84517085ad.173.2024.10.02.06.46.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Oct 2024 06:46:43 -0700 (PDT) Message-ID: <386e618b-d634-42a2-a518-ce2a70a8ef3e@roeck-us.net> Date: Wed, 2 Oct 2024 06:46:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH slab hotfixes v2 2/2] slub/kunit: skip test_kfree_rcu when the slub kunit test is built-in To: Vlastimil Babka , Christoph Lameter , David Rientjes Cc: Roman Gushchin , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Paul E. McKenney" , Boqun Feng , Uladzislau Rezki , rcu@vger.kernel.org, David Gow , Rae Moar , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Brendan Higgins References: <20241001-b4-slub-kunit-fix-v2-0-2d995d3ecb49@suse.cz> <20241001-b4-slub-kunit-fix-v2-2-2d995d3ecb49@suse.cz> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20241001-b4-slub-kunit-fix-v2-2-2d995d3ecb49@suse.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: g6yr5t1ym1ibaecp1ue7cfjf6nb1zbsf X-Rspamd-Queue-Id: 92FB220016 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1727876805-271494 X-HE-Meta: U2FsdGVkX1/fDkxF6LCOaqwq4zpjPKmRviZ3mE3E2W7uucljmLSp4N3aQxLE4l5XmNF/WUo2ml1kES7PZvZA5b8JetdSC/pkneAfMDFtmlxlrG9Hn7sc+hV4ay2b3wMU/iiNJSbWbQmjs5j7C5J0bGm0TyuBEOdp63YlFWlK40pHaVLFxJ/hI+LLAmSSmCR6o5F2o3SEKo1QUVd47/grlLHOYBbqia0pfUg8aiaeG+VuX7NOrUnAhahmAWpcNEK1CSz4b8j9yZ4LlCWAlWfALvEoht8nweoUhksSnc5bWLZ1qTMbrNXbhbkCxpcAi/5s6fqjlwDt3bTIHg4yUI2visscrgBheccbaeeOO0iRMopdvp6UQQ68Sh0GQb/OAc+AI2KBp9HbHuQuefhg8VPx04bELJA0oMgiET6Dpa42HVQ9/JRdqANkNHHG+j7gtTd4XsMhSmyAvoAvB6DyiagaTl04LwJb3BAcl3iThIm2NsImZuV90Ha6wDmW4sHpdk+HqfQZXbgqsx+Br5I2+4CmEt46d00lnmLzvgmfUn7rMM6VWeTaix4rshiU+3B4MC8fA7Ul2XoEZV80+fRt4xm8JrnBEICuhq78Ez0Ttsfel2xhsue7NZUXkVB8iPHwX33JM+aIlE7odzlfVeWWBrlFqlO4pHEOAhaoykllzvt2z05S9IBcudxqsR4CsED3qhADaF36LUTjyZpIfLYeqllo5d08KY0THLYyHDNhgAOEKW0tqGZeE78Oe5mFrAiwgj8xys57/8tJBCSgYME7O7tylPTiISmtfQ+dKrkQSAUtRNxlfJtUSBqyqfYiEIQ5t/qDu9ek46hmz3zyPu3e37qUQ6v50IqEX2sW96DpqsbK1mfXYhCZ9eEgawxGI8YmpC/ukNJUJzJUKGXP9fis1sMcxjWIzfc5zyV9X3B0xn+TUDhP2iUdcom+lYSK/s/iO+vB1TSxNtRiuZmnh7bdVgp cyRrjKWL yueSeJwNEe4+ttnqrzuxsBPR4rNTbSImYa25SxJPqCwEG8o3nillT+TEDYSjl3dKAqnIXgLWpL6ArL5Qp1Hr2xiBrmeuWBlI3hn9kIsB4rvu/mVjyL/UjGfbiG5cxxfTHtZ2s1DEKhGSL0bpDR/DVR4Ka/ehMAkBY3IbbAhR8R+4gGdC3MHWl34p/PVurHse78JlgCjYLPZ4cqcWCypFo98lkzi58l7OPi4iJvKu9X76FCT24N7T0QVhih/TvVCBTWgDMghb3VTc7Iy0G2p0QmjibUmGRT8kNs8L9t5mHQZK21udnjQvK+LvCZwGhNyskSNXKxllwMkozf4n/oiiIw2IOvf1qNojLsie1iI+x1MoyEBatnniWqrHzMwQS1BwKFnmI9BvNGL1prWik47Pp+wI6ZcBMi9J6eFrmS5ybGD8/kaK9EG8Vr5ck2tZ2q68WfI25Hvtu6bpDPX4XqUntpgzRMfwE0bRkFV5yih3bKGFDpILrNHuOm9R9FmeQNla+uWgSpH3Rfs2AE86f80/o5Lhlkw9OZ5GES9iXrY2JeKFlDDgx3wVGbo2ObdXZd7ywfbhQs9UwLJtI+9ve5rk/LK8qmJpdxTGZ/+VubHYVtM9vg+3ppOkAGv44LuIaiHGQT4q2pDXTIBLcJM1CBWPb/zdt2rUAmsee23LTlYMbnytBEh0uCJaaAXv6ZgpqPvfA7DFCvJLb+33ZMIRuvtaLx3OTVfxX8muyXVYWGU6etgRK0rmobGwExr8JoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/1/24 09:20, Vlastimil Babka wrote: > Guenter Roeck reports that the new slub kunit tests added by commit > 4e1c44b3db79 ("kunit, slub: add test_kfree_rcu() and > test_leak_destroy()") cause a lockup on boot on several architectures > when the kunit tests are configured to be built-in and not modules. > > The test_kfree_rcu test invokes kfree_rcu() and boot sequence inspection > showed the runner for built-in kunit tests kunit_run_all_tests() is > called before setting system_state to SYSTEM_RUNNING and calling > rcu_end_inkernel_boot(), so this seems like a likely cause. So while I > was unable to reproduce the problem myself, skipping the test when the > slub_kunit module is built-in should avoid the issue. > > An alternative fix that was moving the call to kunit_run_all_tests() a > bit later in the boot was tried, but has broken tests with functions > marked as __init due to free_initmem() already being done. > > Fixes: 4e1c44b3db79 ("kunit, slub: add test_kfree_rcu() and test_leak_destroy()") > Reported-by: Guenter Roeck > Closes: https://lore.kernel.org/all/6fcb1252-7990-4f0d-8027-5e83f0fb9409@roeck-us.net/ > Cc: "Paul E. McKenney" > Cc: Boqun Feng > Cc: Uladzislau Rezki > Cc: rcu@vger.kernel.org > Cc: Brendan Higgins > Cc: David Gow > Cc: Rae Moar > Cc: linux-kselftest@vger.kernel.org > Cc: kunit-dev@googlegroups.com > Signed-off-by: Vlastimil Babka This results in: KTAP version 1 # Subtest: slub_test # module: slub_kunit 1..8 # test_clobber_zone: pass:1 fail:0 skip:0 total:1 ok 1 test_clobber_zone # test_next_pointer: pass:1 fail:0 skip:0 total:1 ok 2 test_next_pointer # test_first_word: pass:1 fail:0 skip:0 total:1 ok 3 test_first_word # test_clobber_50th_byte: pass:1 fail:0 skip:0 total:1 ok 4 test_clobber_50th_byte # test_clobber_redzone_free: pass:1 fail:0 skip:0 total:1 ok 5 test_clobber_redzone_free # test_kmalloc_redzone_access: pass:1 fail:0 skip:0 total:1 ok 6 test_kmalloc_redzone_access # test_kfree_rcu: pass:0 fail:0 skip:1 total:1 ok 7 test_kfree_rcu # SKIP can't do kfree_rcu() when test is built-in # test_leak_destroy: pass:1 fail:0 skip:0 total:1 ok 8 test_leak_destroy # slub_test: pass:7 fail:0 skip:1 total:8 Tested-by: Guenter Roeck Thanks, Guenter