From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11667C5321D for ; Mon, 26 Aug 2024 10:36:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B4B56B04CB; Mon, 26 Aug 2024 06:36:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 664516B04CC; Mon, 26 Aug 2024 06:36:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DDE36B04CD; Mon, 26 Aug 2024 06:36:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2EA1A6B04CB for ; Mon, 26 Aug 2024 06:36:17 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B10221A0963 for ; Mon, 26 Aug 2024 10:36:16 +0000 (UTC) X-FDA: 82494041952.06.051515F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 78AE640008 for ; Mon, 26 Aug 2024 10:36:14 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i5mn1X0A; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724668490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ws4Ux0RDExTXaNwxJi+io/M7LvnprHMIuJq+h6C45s0=; b=4wPWzG+hIZ3yn+6my0rfHFDN9w4ZcInhsvgZpRyG16jPLPGmY1Zp71cGIEfmYY+h+g3mre hnU+K0t5YqvsBVu29koS7pr2+UkyYf7kiFhU/oWuK869QuW7FRd+S3IhLhea4CQT4Za0+/ uqSFrkkdi2kNgOK7ERd4yHtrzJuzKMw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724668490; a=rsa-sha256; cv=none; b=OiZA/bSCmBLjd03dx/UNXkxvQNIaOkFHhL/1EFiqrDeU0afEtxUyglbOkq7qzzRghLSW53 xQ5/EkgaxmOKjvsUt9gwRAa/JM9ANteMDdyPHRSyBckpBiVSpRQ959/XwyN8Ud9BO/mtxo 0YfadTTRWoiiWi1qBIRsYhi/Avu3h10= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i5mn1X0A; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724668573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ws4Ux0RDExTXaNwxJi+io/M7LvnprHMIuJq+h6C45s0=; b=i5mn1X0ArzkzozypkDE76+uzgifP0UwvyHGNVnH3/IZPUVnfgiX3Budk7EGOv2DFn5ur30 SH2Irha46dxxS25eWelRI0PtuLQI/YguGB0xWeYytE0RkcpwN1Z66H7fgy+D64Y7wbItjx aeNF4gPf22TfhWYzT11jmwxk1kwvELg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-b_TfhK8qMTOOoS2Bc7T_2A-1; Mon, 26 Aug 2024 06:36:12 -0400 X-MC-Unique: b_TfhK8qMTOOoS2Bc7T_2A-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-429c224d9edso40325135e9.1 for ; Mon, 26 Aug 2024 03:36:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724668571; x=1725273371; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ws4Ux0RDExTXaNwxJi+io/M7LvnprHMIuJq+h6C45s0=; b=Qc5wQMXgWvo8bI7t+A6EgqMe+xmIIhq8RbYSfER/Q8Gnw6vUsi6QmZe4bjFTHnpvji ggnGjor+izHfBz1S9n/Pk99wNPk6Fscc6MRqDEavL07LTe/tgSn+YH4g/ZpYbzO0ey3g vJRMS13gWYo1TxYOxjYmNkUnFkgmEw7Om7wGXKkcikwIdws0hXNJS0zbBKUKCs0HbwNP LqQeh0nVST3bTR5fX9fOq/8VX7owMe5xfBn8OalCti7YuSBndfCAPaJrboaWhPQFyr44 v/wS0bVCS8FDw/gtx/LeO3Z9ghVprxSM+/HetD//tkzloo64DfkwLtC4hsdDt6YuYDMK ivLg== X-Forwarded-Encrypted: i=1; AJvYcCUtWpahJ2tjlNacrBsFn4vSLunMk632bw/uPOoNrXVDkO4M2Hw9lNsT+3gS6CA4V3fwPm1vw6537g==@kvack.org X-Gm-Message-State: AOJu0YwaPeRt5iQptFMekEYUC5O0ooh+0OW2UqqmbriwtnporSASkvgU 0N0t9J56dyEQxjFtNd7bQiOklbwKxONmj0He1B3ao/29NnLWiojwhB5kilzxXpP0j7T7wBIVFzO jzX7A0b4mZZrZOss5ZeNHOq4G7JbSoytOsZemW4VwUSqsv6jh X-Received: by 2002:a05:600c:19c7:b0:426:6320:7ddf with SMTP id 5b1f17b1804b1-42acc9fdea6mr58936895e9.35.1724668571023; Mon, 26 Aug 2024 03:36:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8aDK8eE04I/DdNKrLScX5qYY4Lbg9OOPnjRmu85lyDl14ljg3xL8KN0zu8sJEVTzbL6ZnyA== X-Received: by 2002:a05:600c:19c7:b0:426:6320:7ddf with SMTP id 5b1f17b1804b1-42acc9fdea6mr58936645e9.35.1724668570082; Mon, 26 Aug 2024 03:36:10 -0700 (PDT) Received: from ?IPV6:2003:cb:c737:1900:16b0:8dc:77e:31af? (p200300cbc737190016b008dc077e31af.dip0.t-ipconnect.de. [2003:cb:c737:1900:16b0:8dc:77e:31af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3730814602asm10422017f8f.44.2024.08.26.03.36.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2024 03:36:09 -0700 (PDT) Message-ID: <38881e37-767c-456a-8301-2a7d0371d12e@redhat.com> Date: Mon, 26 Aug 2024 12:36:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/1] mm: Skip folio with private data during isolation To: "zhaoyang.huang" , Andrew Morton , Matthew Wilcox , Yu Zhao , Baolin Wang , linux-mm@kvack.org, Zhaoyang Huang , steve.kang@unisoc.com References: <20240826085056.895865-1-zhaoyang.huang@unisoc.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240826085056.895865-1-zhaoyang.huang@unisoc.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 78AE640008 X-Stat-Signature: y371penwydjqa58pr1wtfxfeyboyeba4 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1724668574-622526 X-HE-Meta: U2FsdGVkX1++yk8Oq3M2F0Hh53qZAnxOyPlFHM6tr2M/ZUdQfd+sICD3XQ07DhAQ5G5h+b3Op3/EvbObgFHpg/8gT+KfTKvfwnQrYbzFfPjaQQrONddtKyyuS+dNMxnf2O03JDh6oojlI8Cv2RNXrHgZ6v3xx0A7yXexkdZNxru0+V8wutzLEzN58YKwXwxypMz87y9jEgj2EEEao1Bg5lhTh8V8i20zupEmQRLm0MYiyCKfs61EU68JBfYOWGHpQtFnBirY8uzOdRWAdazZ9oTT+olyE292oZ5zvsWzzT4A+W6KHXe3beHgOCdnRo0SJIk/lgO960AthI2kmW1tIqxuchLA8DWa9fwuHRHx/CJ9vtF4TtPVQSEEDyNLEPInTbUwiMVbo/5wTmAXwZWUHNik5aaJ0dMZyPSUCIgVZvmcBCk5DmjbxUcyF0xMY4zsKzZ6j5t8ldtSqHMhRc3eWoWKZ0MFmk6L7kBPPT7D9bcf8/aCeXCS8LSe/9DfheynZ+ZOhmK0NMXFpGMf8EhUugyux/HS4BehSmULnKpNMf03aItK6LyAIAhilMQP9dtJFDrgbp+vuqf2bQN0BKyJBdtisEH/kTi2qVkxcWdvZaCiWiaqPzi4qbsof8j55fQDFMlgaEDXHyG3swIjA+177CDbsTtgRJnniqwF1uGaLKDydQKZ7gtD6BDkyo7eV4pJIeMfn9QgS5tjNEp2/PZ6M3loWt5lrrSy1UVwUmZoomci7HjO6dj8iMtCgtxhwqO7Qm8WJuQR9R3T55afsmNvLqCdH4tsTTNRyQGhTmY1hG9ImbySNtojQ757G7gQyTjuDPIdmeCBkEVHG21PP2k0OWh5ypxBV/hNH3a48OBOvW63Xwb6wpoCRZm6J1poJQzSewckLaVpgvb5pejJ28PXKNv5ng3IMmQYWEcHDe1ioL3lwr+PR1wIExzM/f8yzn9vpOT9bTGNRwGnm3XZ+D1 O0V8eiG0 8d45M4KOTweTjP4YBHGag/iVelY//zAZx5hPnZCQsRg38m5RnyIPFX/ielIRNjpytTnn54zl9C9fPGsoC1TCOm+cIlz0b/A+R5k4MpcbWETtKnmGrz66cHFzXYQKcSvQP5av7Hd+iP8bzOmWfn0QTBr2sXhM/5YRBgrmupX08RxEXmCnLdNKv+ckKJM3UD+jvRPGgiu7aY1Ayvi7QfzWS7UCx2RoG99TFBRa+6U/XPk4K0RCsC2ZDqnZZNJJuy99mv/qxiVRMd4R20xMWZC/YgZGnUi54MRogV5KbaMJPGcQdIr2fM1HdkSKdoiJrYGBB3NrEJg8hAav6xqKK/B/vXJnkmottyLO6kFjiiCiVrc8GjkWbg4TEmnmhZyLnZuSMJbcA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.08.24 10:50, zhaoyang.huang wrote: > From: Zhaoyang Huang > > Since clean target folio with private data will be given up finally in > __remove_mapping as it has extra refcnt, it is better to skip it during > isolation to save the slot for more qualified folio. Current one could > be the candidate for next round of scanning after the private data gone. > > Signed-off-by: Zhaoyang Huang > --- > mm/vmscan.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index cfa839284b92..755bf3a387f3 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1685,6 +1685,8 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan, > */ > scan += nr_pages; > > + if (folio_test_private(folio) && !folio_test_dirty(folio)) > + goto move; > if (!folio_test_lru(folio)) > goto move; > if (!sc->may_unmap && folio_mapped(folio)) An earlier filemap_release_folio() would have failed if the private data (buffers) cannot get freed, and we went into the activate_locked path. if (folio_needs_release(folio)) { if (!filemap_release_folio(folio, sc->gfp_mask) goto activate_locked; ... if (folio_test_anon(folio) && !folio_test_swapbacked(folio)) { ... } else if (!mapping || !__remove_mapping(mapping, folio, true, } At least on the shrink_folio_list() path, I'm not sure the code you are adding could even trigger. We should not reach __remove_mapping() with folio_test_private(). -- Cheers, David / dhildenb