* [PATCH] mm/page_reporting: use list_entry_is_head() in page_reporting_cycle()
@ 2020-12-22 18:27 sh
2020-12-29 9:16 ` David Hildenbrand
0 siblings, 1 reply; 2+ messages in thread
From: sh @ 2020-12-22 18:27 UTC (permalink / raw)
To: akpm, linux-mm, linux-kernel; +Cc: sh_def
replace '&next->lru != list' with list_entry_is_head().
No functional change.
Signed-off-by: sh <sh_def@163.com>
---
mm/page_reporting.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_reporting.c b/mm/page_reporting.c
index cd8e13d41df4..c50d93ffa252 100644
--- a/mm/page_reporting.c
+++ b/mm/page_reporting.c
@@ -211,7 +211,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone,
}
/* Rotate any leftover pages to the head of the freelist */
- if (&next->lru != list && !list_is_first(&next->lru, list))
+ if (!list_entry_is_head(next, list, lru) && !list_is_first(&next->lru, list))
list_rotate_to_front(&next->lru, list);
spin_unlock_irq(&zone->lock);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/page_reporting: use list_entry_is_head() in page_reporting_cycle()
2020-12-22 18:27 [PATCH] mm/page_reporting: use list_entry_is_head() in page_reporting_cycle() sh
@ 2020-12-29 9:16 ` David Hildenbrand
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2020-12-29 9:16 UTC (permalink / raw)
To: sh, akpm, linux-mm, linux-kernel
On 22.12.20 19:27, sh wrote:
> replace '&next->lru != list' with list_entry_is_head().
> No functional change.
>
> Signed-off-by: sh <sh_def@163.com>
> ---
> mm/page_reporting.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_reporting.c b/mm/page_reporting.c
> index cd8e13d41df4..c50d93ffa252 100644
> --- a/mm/page_reporting.c
> +++ b/mm/page_reporting.c
> @@ -211,7 +211,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone,
> }
>
> /* Rotate any leftover pages to the head of the freelist */
> - if (&next->lru != list && !list_is_first(&next->lru, list))
> + if (!list_entry_is_head(next, list, lru) && !list_is_first(&next->lru, list))
> list_rotate_to_front(&next->lru, list);
>
> spin_unlock_irq(&zone->lock);
>
LGTM
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-29 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-22 18:27 [PATCH] mm/page_reporting: use list_entry_is_head() in page_reporting_cycle() sh
2020-12-29 9:16 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).