From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A9F2C5B543 for ; Thu, 5 Jun 2025 10:55:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A40C56B059B; Thu, 5 Jun 2025 06:55:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A18566B059C; Thu, 5 Jun 2025 06:55:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92E646B05A0; Thu, 5 Jun 2025 06:55:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 73AAD6B059B for ; Thu, 5 Jun 2025 06:55:00 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0DD1C1204DF for ; Thu, 5 Jun 2025 10:55:00 +0000 (UTC) X-FDA: 83521039560.14.D691CED Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf20.hostedemail.com (Postfix) with ESMTP id 0D3211C0002 for ; Thu, 5 Jun 2025 10:54:57 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ju1JG7jt; spf=pass (imf20.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749120898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RVFpUO0Ly3idy9LjRRbGnnclNU17iOu62Gz5GozMQoM=; b=NJa+wWyZUY50lqAnzXjkH4oQ71Pbw4Og22JtuejTKKRpakAeUlW7idSA/R4lEq3fm9M5fs IW99qu/dKP8t04Xu7StmJT3h+BsnwxFjBwFjm1ezYERGEYY9Z9XKWMXd5J94NjCN1mH168 AzCxawCL8zMWUsEpUQoOunJ28Efhuvk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ju1JG7jt; spf=pass (imf20.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749120898; a=rsa-sha256; cv=none; b=jo9n81K1IxiAf28Ntk1PzobYHVySFvjHNzCBzVH2glNYYQ3MQOVRg3KxA4qXOdqaHFE+J6 Lj83yBZjPIhhOgODsXqT9/hoZspy93X8sh+IDcN5fN8MTrciLhcRXnbj4x3HHfptOPznFg nJ7+/4/46++4MTRNKZ3faOrRaeH/Uqk= Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-ad88eb71eb5so106223866b.0 for ; Thu, 05 Jun 2025 03:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749120896; x=1749725696; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RVFpUO0Ly3idy9LjRRbGnnclNU17iOu62Gz5GozMQoM=; b=Ju1JG7jtU3+wGOJBFF3GRNgmA3he22ymduxvSSg2ndX4uZsk3lfZaL3VU+0bWhzAL5 wsz4kev8RUPHydtcj9ngZM8IagISBAqN9bcTmIj6scm4800Og2VPytiBmX4s0Kus9aJk O/YILxouzXNaaAYgZyQuN+LA5ExMUH7EXZux07LcQ4/+/6AHcp7Kfg6+uWuHAor0osiW NK4Yp/nN6FV0jtkQ6KdUxTXM3WvMYQLgnYykOAKqpht1IRfrhj2/d50PUN6xPZn5SEs7 KARCIDYqr6i0WiQ+bsuPwYF/dstMjfEqlE2WHA6kP9MEGS3NQ0yd3N1ro4E3jyV/D6R3 nvUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749120896; x=1749725696; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RVFpUO0Ly3idy9LjRRbGnnclNU17iOu62Gz5GozMQoM=; b=eSIJg4G50RrMZ+PTTu/hJ0TucBYRzzvFJHT4JmNnM9EHPpLA1z77Yucq6iz8NCOEUp 3dVjxt5N6HyYMyopJkrj6GTZcV47YnNQrk/aeRfMKyyXYpBN287Eutx2Bs+zh2FsyUiC hUSXkcQESgsjnqK8wC2oKD0iyidJHdPIIWT4EIptkaW+RYYnuzvvuybs1GauDaF4Kd1C UokzVwiSbxmFqM/TqiGZYSMmnmkRCqW7YV25AH6RkWBa4XgvZg23iBxmCIOTnXETpTVZ 5xQhoUFyAkEGzYDy/af5laoqrUx1GxbjyIxCLt7po56Pb8oq8RxCvBIk5YUsOMLx9yPQ mFAQ== X-Forwarded-Encrypted: i=1; AJvYcCXngNuF1uYfMBt78wpmyD+KTXvVzVDMQBYp7sKzMGMS4w9szGfOENT2ETduLTS//U0pHprZ8pPr9w==@kvack.org X-Gm-Message-State: AOJu0YxuerpnhygqzLtBbxrSepuOWWneqMiD/exeKR64+juExReS6vqx DEmDmVdZ8CgDjjRVFF5NDUcZCp13ll5k7hNpmgClUiA3ggCbxnFVxwWv X-Gm-Gg: ASbGncuBkemnKm15adgW9/yfXQns/+UqMeaYhbiSO87u4CrNDOgovM+QHOwVYh5kMxL zIy1BH4ASAPXaLv10FALElrvchPOJ1ErOeHQO4ixuwLobtAInu9by99d/dVVas8ut1cjQAAiKGZ gdUjJTkdcGhHHc65glEolkGrNBrj7qQGHy41EkpGgCzPZbrVxJSx4gyj3NYJNjoWxQrzD+iH6Ul XtWBqQlNqiJqMAykqXs4JImg6/oGals0gxg8Z1CrUk+Z1li2Uc6zYNxHqKtmeq4aWD4mKV3R2Mz 4AN+HQyDdMddBU8jjaiLsGgWfLzf9LJzXcBkjiTHGn3Pg4HSH9Cbh/LaqnLObagN X-Google-Smtp-Source: AGHT+IFOh3n0Lq1+0bCNr3K1c0pK3yMqrWaY4N48Q3In6bxJO12Nso8MJwVau6mL3MN8wVXf7QRWQg== X-Received: by 2002:a17:907:3f99:b0:ad2:1a63:3ba4 with SMTP id a640c23a62f3a-addf8f5270dmr588304666b.37.1749120895954; Thu, 05 Jun 2025 03:54:55 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325::22f? ([2620:10d:c092:600::1:d66f]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-adb390f09b9sm997635666b.75.2025.06.05.03.54.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 03:54:55 -0700 (PDT) Message-ID: <390073b2-cc7f-4d31-a1c8-4149e884ce95@gmail.com> Date: Thu, 5 Jun 2025 11:56:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v4 18/18] page_pool: access ->pp_magic through struct netmem_desc in page_pool_page_is_pp() To: Byungchul Park , willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com References: <20250604025246.61616-1-byungchul@sk.com> <20250604025246.61616-19-byungchul@sk.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20250604025246.61616-19-byungchul@sk.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 0D3211C0002 X-Rspamd-Server: rspam09 X-Stat-Signature: 5171h8xmpqz9imu1h31i8zdfp94zdz7u X-HE-Tag: 1749120897-764183 X-HE-Meta: U2FsdGVkX18BNvUvDKBGw/WE8/gGyLDMb8egXYnN/EkHyOYs/AlBfMKn+YcryWyLuYGPC7aBYCMvoB5Rmc24C4/a6hXjseA0PWrMSZumQSnJnjxwK7CsRvJSa/ITZ2QJUBMcQXCq8WT6nBqFTaoyIdCM9Uqoio7j9UDL333Z6PLiZ6R31wHlffTLOdjXzHnDGiObOT9iDycYBFT9483TOFEhI76STy2CFpZzZVOplKF2aSbj3rtVVYwDR4eS6+LFXO1TLiFBrf9ydW7eXedzPDxXbrlE+0yVJJIqBO9Xpl82vwBu1/rvjbKz6mPcxwbN+ZvbZVQX5e1s3dw5OTvTSLG2bjhidzwJuzcgVTOCKEkEWzlak4ckFT1KFjBpzBUF2tI+/OZPIpr/39HQ8cxBPDo51J+GHUdLw/0GRxVUH+s/k4uyURZLpt79p46S/C0+BIA0bRAsmMg659aqCParjLgAK4WhvWEzcbeA8aD9XeT1AVV8QJBvgPXZjvxMqWvyEFQ9aU5UB6P8ptGLZewG1l5UN9lgxaUChjBf+7r7K27wP/bT9n0A2VIwauf2Ewg8TKLKWS9KH0CgU4lMkz1q3YVdpHXNj3VB1VsFyC5Umvo6bazcXB+MdFFE8Uu8UEnQ6kVmcpzPuehYBjV3EMMTETqoGBJF7vjMcwOue6KnROJY507ljDX8GYfy5DWAQvXdDaRaY1oQ5ZnxPWytlI4uWwmGtMORhUnmDpaYNNxGHxk5DYrF3hOta2DUCDQEc0Ngc2/k1sk97GEvw10tLQ/S8MI1ZIPPmrKfJrHzIo06LwXGSXY3VO1gBJDp89LUzBbvWj28WT/ijgBnF6aZxjATjZDp4jKMjiECIAt1jdkruMZp2g4vQ0fcIvAvFE2S8C9iNj4tCRPWilt6zpFb5cVTMPRWrLvzJTl28r+D9zKggdb640B3QmFJzjapud8t6yItzKjm9tvvoidQHRIUkuX Z77jMOjQ 5E9zVw1OwSnYR5DIUIhqXwSG4xpLw9bowDiDtIVAwIBXWjYdUylSAk7Wq56j/EOTD1MBcRzLLNnGVHvfCboA1LIKQdpks7isfi7uykCe8wu9pYZ9WrsEbyrtN0rZnm87/s+O4wcm/B92cfYI39QziDIQKTfdsSRWRVzXUr8ejzrDxvotonWmmih8b36YPZsfUwCk8+o8O2Bvk1AYIgn9Fkg3D0PZX3AVd41i47GRozWJpgt34tiN6OLtzlZ6MDWWlFdW2674aJSUFYwav045SOkZUw5qUFkpUvMtSPY9HxwMmEArvd51zDi8YiK7yTkCWm9FYeMByKnifp1V4QglCi8gFh8InMR0xdteggasK4+NiFYUFzSdB9zNt06iVoCCcPQaboauW27xVlTdAYODpI+tslQXTDSIXahWjb4b+NLR5SQdhxACroz73WXgaqGoLESnEuMmBqBD0o4WXObjMnxeGj36b/eZ5qAVsQIhow+PTn42+Uzp+oIOOPAmfayyHiU+NCY0HHEjl+j4AT3AbMmeu9Ztz/J/2nnVtm9XBGdY104SPjlNhX72J0Qk5pIUOi+LJdVJ4NclRxjQKgwdRVMHlEzBcwe/0s2oYvvakK2kC2fl+8NvHu9QlfA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/4/25 03:52, Byungchul Park wrote: > To simplify struct page, the effort to separate its own descriptor from > struct page is required and the work for page pool is on going. > > To achieve that, all the code should avoid directly accessing page pool > members of struct page. Just to clarify, are we leaving the corresponding struct page fields for now until the final memdesc conversion is done? If so, it might be better to leave the access in page_pool_page_is_pp() to be "page->pp_magic", so that once removed the build fails until the helper is fixed up to use the page->type or so. -- Pavel Begunkov