From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A12F6C47DAF for ; Mon, 22 Jan 2024 17:22:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AB116B0085; Mon, 22 Jan 2024 12:22:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35B166B0089; Mon, 22 Jan 2024 12:22:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 222CA6B008A; Mon, 22 Jan 2024 12:22:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 126D56B0085 for ; Mon, 22 Jan 2024 12:22:42 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B53FE409B9 for ; Mon, 22 Jan 2024 17:22:41 +0000 (UTC) X-FDA: 81707616522.16.1660141 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id B08B91C0016 for ; Mon, 22 Jan 2024 17:22:39 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Elw7hBqy; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705944159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dyL8HkrfuDx15VmmUYeIG1cK/wCgWeV9TZeHPttzNv8=; b=pZXxmEA6bGJ6e4Bbk0BRx9YbQrxne754X5oPoUFGhtQnt9SH9QYAtY0vBq1ATTW6bgh+ka 4ihedEgtZFbwYK02wqXBIcyRVsviYBR7An22EoWtsLfy3QRbf+9GP8MHXvi23EllCBwscC xHX/wXYizO893wU/aSprYO1mX2LEeUg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Elw7hBqy; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705944159; a=rsa-sha256; cv=none; b=hunknbGHHmEFI3zx/kjFygMk22ualpTtkVBLvngYVE68EZ8i+MD9YbMpH4ioeBtm9HsXQe w6ydUCiRlXh3ZERhaqmNj78Yu91UO3IPyKgwdlLeGyiMQSdWOlRDlr2PIvkXuolFh5JZhM TSHhDvCr6kx+41ynGiOgHHI6QucQ+UY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705944159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dyL8HkrfuDx15VmmUYeIG1cK/wCgWeV9TZeHPttzNv8=; b=Elw7hBqygp+L/3dAmcCElBWsjPP/GyQ7+plyiK+G80DqAzMSjZsCNufhyLX4tDh2z3hYUx 6STzNJQjDULR71Jk6aa6e1x7+oKDJWwPm4Y/Wfd/Ckl0cwiY2/gSfpfv9gcaFvOtavshMs 0PkN62unhPo+IIHM9Pm6sD5VkN4QauA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-HhQdjMHnNSCeJf9HAxnqqg-1; Mon, 22 Jan 2024 12:22:35 -0500 X-MC-Unique: HhQdjMHnNSCeJf9HAxnqqg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A236285A597; Mon, 22 Jan 2024 17:22:34 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id B2C10C0FDCA; Mon, 22 Jan 2024 17:22:32 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20240122123845.3822570-1-dhowells@redhat.com> <20240122123845.3822570-2-dhowells@redhat.com> To: Jeff Layton Cc: dhowells@redhat.com, Christian Brauner , Matthew Wilcox , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cachefs@redhat.com Subject: Re: [PATCH 01/10] netfs: Don't use certain internal folio_*() functions MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3931925.1705944151.1@warthog.procyon.org.uk> Date: Mon, 22 Jan 2024 17:22:32 +0000 Message-ID: <3931926.1705944152@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Rspamd-Queue-Id: B08B91C0016 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: xyotmus5kzt3fbafa8kao4ow9oqhiogd X-HE-Tag: 1705944159-507826 X-HE-Meta: U2FsdGVkX18p5cZmMwNnHP1RQCLlEukeuV5VMusYZB8s/e3y0VEf155zobrc74+za0dwecua1R/pFNay0xOuyA7WFCbKpLHdypEVG4tBON5BKA1EaGmFK3yrsfKJ+TAQbRBHA8Nyy4O6d9bmHx82gqLPEirhM8HdybIum6RV+Sapzttt6OVFfZmQYzTUH7XIg9mBthj1MT9h4liDykfhkwhpDbNnGmhP13e2BpUM1KGmVvIR5WRh6p8vOSEhrfNG1zH5mfkwexbO8u0/gb/HyuBQHqp65HWGD8wkUDeILL9ILs4hJnCDmcsCThry9KBUi+hAgu6Z0K0aSWRP61HCKLZTCI0I3Nz5sIDRzsL87lq2YplvRyXlNoVNZgz4/OrEdV4qzvZToRX5h8G0YG7BblzrB6HSuLBECZ+JtN6I9rIDS6m+SQXTGOoNPoudkaIZnE45YQjTntxuKWbCpuIZij9ukORJF9x90wKiMsAZtmkNSirUcqapzYgJIUbjg50MCBJauRnLnoPXzyjTZHu65TERS8Z89xHXdvtxdhbiDpu0aNRJcrRFR67sgImmqDymt5YTNaVbhFvqFpxjp1/nwzmmJ/Ly4cMqx6BzErtLyM58Zrd9SPsqUuRuV0jOH+yK+FK7BqlwbH72xL46IjFQSu0v7VhhKbiTtSozEqwqnnYvmBHYFcFSo/5ss9nvlTe3VcA3mYcrRtZF3wK6/K4JBpGWgo9l9llacJixxdeJo2dwSWU40cqEVOL5/1qEwf7AqZ+k9uWm9sTx53UgvPE/c3zpZfdqOo1ao80Y3QDZ6HLmQdSoU+/CqgrjABg4M5QsOEzVUCiarJfdpJrN8ZC5gDDzCxeKN5NndG941dvGSpqSTooFPIHq6s6s1n/EiU+9qzQq997rInGDz3ZoUY2z7e5/yVXOgkZHp9q/MZrS4qe5ydXe6684h0vmUeGnF3GzX4gWv6Dm0rbDKLkoyAK Jz/YR0fQ u1F9syQjseGX0lWZse/oL3b1/SLlAxSf77KZBabyyZEVYfEW+LaHVhSeHhCdmWHe4sQi8n35AjQ4NPKagdDjtQ8Gc/yMA9CcRzA9SCVVvHcOC4oMhekbqokSbwvXurpSwzWItj3im7qrRkFqvEF2f+jaNsZgHz85z40IUmLP+/gdy2KzUqMkn5itkaoU474Cv+kaeTcvGGMuClCs4HLx8VN7tY81qIv1mEh1F7ARgz3QOVz12SGH3HABZzXDZtXurMk14SbKjI+mBD2UDJTtt4A11zckbYJ2zwf6H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Jeff Layton wrote: > > Filesystems should not be using folio->index not folio_index(folio) and > > I think you mean "should be" here. Ach. I forgot to update the patch descriptions! David