From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C886C27C4F for ; Mon, 1 Jul 2024 02:54:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6BEE6B009A; Sun, 30 Jun 2024 22:54:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1B996B009C; Sun, 30 Jun 2024 22:54:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE3816B009D; Sun, 30 Jun 2024 22:54:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9F9686B009A for ; Sun, 30 Jun 2024 22:54:32 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 413A481814 for ; Mon, 1 Jul 2024 02:54:32 +0000 (UTC) X-FDA: 82289665584.17.22B0168 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) by imf01.hostedemail.com (Postfix) with ESMTP id 069A140016 for ; Mon, 1 Jul 2024 02:54:29 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NgFimxeQ; spf=pass (imf01.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719802459; a=rsa-sha256; cv=none; b=iPt/+cNlhSWqrQGErzw3WRZ6BabhBHwHk4SnPvwfjEF44lzQMRupMzPPMPe/CNncSmc7Uf +lp3047N9FgKAtWnVjVavKNRYREZXdOsshEOmqr2M1sFdryFIoacYEIR94GKw5pqxFV4C3 hnwpNeWLFxAJS7kubXGfdIBdszDPDfU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NgFimxeQ; spf=pass (imf01.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719802459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p7Wf8ZN3ha7QhsRhHRdsI6h2cQEcejdhbJTIuhGiUPk=; b=cb1s+cK/uKb2fBl6Idz21sBvMBrdQPwoPRZ/MbNLGPvHd23gB4uxf7pvE6MZmd3cvT+tqK 1a5XVIeEAr4RcmabbwmS52iIhv5M+1XtDLH015onadno9wNOqTEbTJK01oUKnjvDY/KECf MA4MUKVueJkVapFgYc2ZD1gjSfZSDak= X-Envelope-To: 21cnbao@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1719802468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p7Wf8ZN3ha7QhsRhHRdsI6h2cQEcejdhbJTIuhGiUPk=; b=NgFimxeQPMKdwxtmOoWE9nyY2Jl8bDZxBAfHhER6hO0q2mxbzuW1QGmJjXkaKHXrfgnXFT mlEGu3PtXfQ0k/T1rRA4XqkN+PyZSwFFnTTQ13T7EEeLQuzSYQwJvx6jhRzb7DKIhiJBY1 Zdnrzr8YYCy+wt/46LJTr5fgo1DKRFk= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: v-songbaohua@oppo.com X-Envelope-To: yosryahmed@google.com X-Envelope-To: nphamcs@gmail.com X-Envelope-To: chrisl@kernel.org X-Envelope-To: david@redhat.com X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: willy@infradead.org Message-ID: <399b0eeb-e6dd-44e8-abaa-65acffa25364@linux.dev> Date: Mon, 1 Jul 2024 10:54:19 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] mm: zswap: fix zswap_never_enabled() for CONFIG_ZSWAP==N To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Barry Song , Yosry Ahmed , Nhat Pham , Chris Li , David Hildenbrand , Johannes Weiner , Matthew Wilcox References: <20240629232231.42394-1-21cnbao@gmail.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240629232231.42394-1-21cnbao@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 46zmhe3kjjnt76s154wisdk3716mddz9 X-Rspamd-Queue-Id: 069A140016 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1719802469-688456 X-HE-Meta: U2FsdGVkX183h7vRMVo/NOpgoT6pRNErsNSyrKLFW8jae7ZVN4YtQZ31H4V3WxTXdSV2HZ65bDnkpSQIWVIRis5H1wWBx2/QOHbnP4EbkqE2diuYtY09JVItdmwYK2bwEcmbHirxlbJzr0dEAa3lpQPESjXQYrEvUrMMPyLF4nj0K7is6uUTHfbXIQkC4rn8gwuRy35DrNrT1L+ULVzfDdDzou0oIP4UWsB1VWQ08KUYMmUFSZbZ3V7RRKG3O1rLdPEZ3eppXBfFXJAapvJkawAOJ6oJAZeQSMsZ7ntT/FCyN74txtjtibXWz3AWKM968SRcocR23CKK18JZJXZqjO3JpkxpVXMYCWH7r9KVBiSH8zcTjeXWzyTS22gZd4Fx7HMQboaQ/5jdu+8UvIzegUCnAZ46AxKaggCeuffOpa9Qq8DEsi7HgJ8+xi78jJoTSZv45nwOpBnPMIjhUAcZEjzr0O8G82ocbGxJig3C0V5TjyRw6YM/ZXFXmP5AjrJPR7dWCsjYqMTV/2N3skK0ATaY8qiNozFimK4hTY7DVPUOv8RtIcgMUNXno1ZL+6xIAuvB1t13+himh16QyajaciQAn1/uRc2UsnEp5tbNK1Q+J/ActkN0L+3ZLFmQN/EcZllBcXa7u77cMOzPUldmUiFVp9okWaEVZDjy8yCxcJu9XZYJxlrXVhT48uxEyKo+oHbPbIVW8p01HRaArawGF0aDlumjd+E/q7X4j0TYI9QrYVBKtYWf+XWO3dK/4N+6+o6GdKjGLkRX6obKqdZk9tvB8ndS13NRJbGgeBRU23pNzxxq8EZw7zVczQ75PlwDgEjr9tl9Ei5y3fpzH0jppFjTODJemUGIKbneB1HGXdax8p78pE40xGhItF41SpdO8N+TCoLjYIvOtKAA12FFkxMV4+1wFXyM7TivTe5EIC/JjG4tVirDxK57sdLOfrJcTaX9EZzppQVczq2n/KM pHrIzrPD c4sGF03k4T9d5I1eZ8u+s9TAgVRkpYyaZcfdG9mmJ0ev6zsXOit/Er/nqu3ZkqYuiUfoowNK6I6iYcJiLzK5JpfNyi2oYOSUmyxp1LXAzsJNYP2GLQkasNsjo9kVgYJHFRh2KxMN4FR952/NGYVCnBKWeboXdujL11Hp7aeJh31LFwQE4zm/q3L0IW5ef3K3iSY1T5v43CVUgcrS0+lZHcKnvSANBSinGYRFGZfC04ak2VfCKxniHka11doqgvto5t2dv8ylPkpQO7GKhvGm/+Ns1LZSmanK3R/2ldCJZ6tlQJm/tu0Y1MFGbXRyaevr79SZaeLOxZEBz6JuSFwrRjFeEM6oYrdRKiLUyKtwpCzrZlBU1GvBoOtobUYWjoQuqDNWOsVELI4zx8I1vwn1qmHAxJnnXV43OdIU58meYwPPN+/s9l61QiG4sSd56QQ3u5CoCOnoJnMdGQW2Gp6/qDHkWRD2OPnF6p6AQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/30 07:22, Barry Song wrote: > From: Barry Song > > If CONFIG_ZSWAP is set to N, it means zswap cannot be enabled. > zswap_never_enabled() should return true. > > Fixes: 0300e17d67c3 ("mm: zswap: add zswap_never_enabled()") > Signed-off-by: Barry Song > Cc: Yosry Ahmed > Cc: Nhat Pham > Cc: Chengming Zhou > Cc: Chris Li > Cc: David Hildenbrand > Cc: Johannes Weiner > Cc: Matthew Wilcox (Oracle) > --- Reviewed-by: Chengming Zhou > include/linux/zswap.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/zswap.h b/include/linux/zswap.h > index bf83ae5e285d..6cecb4a4f68b 100644 > --- a/include/linux/zswap.h > +++ b/include/linux/zswap.h > @@ -68,7 +68,7 @@ static inline bool zswap_is_enabled(void) > > static inline bool zswap_never_enabled(void) > { > - return false; > + return true; > } > > #endif