From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B152C04E69 for ; Wed, 2 Aug 2023 14:19:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3965280181; Wed, 2 Aug 2023 10:19:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE982280143; Wed, 2 Aug 2023 10:19:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A63FB280181; Wed, 2 Aug 2023 10:19:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 93618280143 for ; Wed, 2 Aug 2023 10:19:30 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5FF0E1A0687 for ; Wed, 2 Aug 2023 14:19:30 +0000 (UTC) X-FDA: 81079372500.01.9DA196E Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by imf12.hostedemail.com (Postfix) with ESMTP id 164CE40017 for ; Wed, 2 Aug 2023 14:19:27 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm2 header.b=mx5MMhew; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=tCqdEg34; dmarc=none; spf=pass (imf12.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.27 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690985968; a=rsa-sha256; cv=none; b=Cexo3R5ODBBh2qiFeLYpZ+huOeE2HvWXtrojiOzjObXHk4gQ73QW0P3Ad264ZZLIMGAztB 6AlsgabTGrofMFdim3SnP1upLdR/swnJ/fPkGoaFIbfndHJGHzXpw5FeOrM22YN0JSwqCh eDHjZ+lYz6XYBVmscf1xPADzg25FgEA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm2 header.b=mx5MMhew; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=tCqdEg34; dmarc=none; spf=pass (imf12.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.27 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690985968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BUdHhNhEjX4ngx2jtG/4TPbrPOMxx6nkx3T9LDhPRYo=; b=4Hm7+q7sRKsnsSvALpcGzoakcu9rxa1e4PEmz9oCEQqdEafaF0vvs9kil4xt1FbAYIaFE9 Ikn3EeVcWgWfjxJVe8kKAOEd27NTcGiCUvbIRxz2d8lZpeQMLrVxc35fj6VsxvZNwZGj2U P3A8ywQHHbCGI5LjzX+S2Q1cBvSye4s= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 09D8D5C0089; Wed, 2 Aug 2023 10:19:27 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Wed, 02 Aug 2023 10:19:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1690985967; x=1691072367; bh=BU dHhNhEjX4ngx2jtG/4TPbrPOMxx6nkx3T9LDhPRYo=; b=mx5MMhewIy2oFRXKKw wvhEueAMLBzedVFA5Hmi2B8U7uRIDJxC679m4oZbq/hdkvHaoWBFDiEIeswdPiH/ huIRfA3oKq0SZmbumzCEOJv/HiwpA7+dhvvY0SXNMRq8uHrANY7BpbMSl36yx73U cGVNQdwaqKQROZPWfqSo2LZhV/l01HV/aTuXIKsqGtMhdZVAfusTlcHiRax+TEJ9 0muhBW3pRv8x3Q8tTpDYqhYYAODnd5WGu4W0Q1+WVHYiPQAAQTMpSEVa9JPV3uZf tmMQazYaAsLtfzCWSN3hnLZ/bETPj2a6LrEjSTshUJoZ1K6nTk3x03hd3khsn8QI 9aVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1690985967; x=1691072367; bh=BUdHhNhEjX4ng x2jtG/4TPbrPOMxx6nkx3T9LDhPRYo=; b=tCqdEg34aM0lFWczPyq3c9sPPcLut VPm17vo7WVHPJjF2pkDv5z0ecScCQtyazhuKad1Bt2DfVJUYexrzgHfOBaZHZIam F++AX77tbOwojiBH3nAk9nG2kUf2mcBrPkCbgMlOtxX3TV70XY7OVJCISS9GG/dk zLV4VQMwQtBZ1yGCuJmX7Dw8rQsMl+T1WUIkI5fAqHdo+mTNGRQMut5TAd0hbvy0 AONIKCrS2hULXURdIKm41ESUE0ouNwVkMp/qPLYnQOgD8sSQ/zwrjPf5EXvrn7F8 wKtlaqtXB03TGSLe1QajXMHFyNbs/GGaP3cJpvWV8gfLNUoYmJRoJDghg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrjeekgdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 7FA53B60089; Wed, 2 Aug 2023 10:19:24 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-624-g7714e4406d-fm-20230801.001-g7714e440 Mime-Version: 1.0 Message-Id: <39c79971-12fc-41fc-8cae-b2a0089ed034@app.fastmail.com> In-Reply-To: References: <20230706154520.11257-1-bhe@redhat.com> <20230706154520.11257-12-bhe@redhat.com> <0f771b11539d5a3871691af901315ee2034b577c.camel@physik.fu-berlin.de> <09094baf-dadf-4bce-9f63-f2a1f255f9a8@app.fastmail.com> Date: Wed, 02 Aug 2023 16:19:04 +0200 From: "Arnd Bergmann" To: "John Paul Adrian Glaubitz" , "Geert Uytterhoeven" , "Baoquan He" Cc: linux-kernel@vger.kernel.org, "Andrew Morton" , linux-mm@kvack.org, "Christoph Hellwig" , "Christophe Leroy" , "Mike Rapoport" , "Matthew Wilcox" , "Alexander Gordeev" , "Kefeng Wang" , "Niklas Schnelle" , "Stafford Horne" , "David Laight" , "Helge Deller" , "Nathan Chancellor" , "Yoshinori Sato" , "Rich Felker" , linux-sh@vger.kernel.org, "Guenter Roeck" Subject: Re: [PATCH v8 11/19] sh: add including Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 164CE40017 X-Stat-Signature: 7xs4gx45mmc8r17rzp4a14tw33hu7nss X-HE-Tag: 1690985967-722555 X-HE-Meta: U2FsdGVkX18F8koidHLNS0mszEUHY5K5glaegaW55sa3ochiZoIrcH5el59i1Uc3N9yTNRRmwb8EHhi6hYEoIrwSN5PxwJ1P6K5iVzMzg2Kf8OkqoAUtZKRU6zlEoLmoYb34Gp4YQt8SPDZnP2Fr6FRchhWZZCUNt1HnyfJcLkg6fKOtmo/BEdp2xqje8qiNJzeqENM9Hx3Mrk6VX1nJk0KD99Rlee5pzf849VmIlsM+saUA5cRbkeSrjsO0xGM2063OnVmoi0DNvHWxz+85pbe2uWn2YgUG0bkW1P0gnHySyTq3QhmnVUHk/wOuuwWaDxfqaXjiqBuckaxbFpFk8BtahXOYq70h1NQzA4kNEtwsYajEja/1Oxd3HExSo9wpwYNkom+OdHLenp20vnQqVwQRmgt4W9lSxZq1/yp0mBPOFRdc/XucpHaJ14IcBRE0Ge8ro8iyFksSVW2ArqMPqnkuo5r3+acOPZMLbYMiGCFC+bcwyFl5AjEkvbMCJmu9fmIb6rYZ++A/e03656ez2CyQ3DYpJdCnRNYm0xAr8PvIo5yF/ignDgptrendy4aQnnbmNlMJziVSnsOQWJAY/K4tCo+swhfl6BdZra10Eu9W8qMDcg60TaBI4I/qsaINeeZrQWtgz2+tPBQ9Rb92/q/sqLxGCT5p7NoLorvPK9qkz+DypBBCf6lPQyoJQSIe86ATIVS/qC6SE1FwcPgE99AUq53wfg72BIK/zw1EHCsFHAS226PNa+7cUIWUh9/gr8cUA9t1N1L7wc17hMhoDBdXUW5TAlBiWyv/rgbdALETEVWflcWxPiJbTMUI9ESv5dBbQiKVAtZZQB0mz+DJvFWaBicUJtFKip/nmj23wuf4jgONBJBfPcWtG8ajSmsM8T0hqNAAqm9akDdV5hS2vTO9Cs/s2XSYKhmsBySG+3SO6vf2w3anW1Qvt0Q48c1WWes46avG2vHS9iLVrV0 EDxfKwmK MW+DeCAvt6r/E9udK+HcY3O7BynVPe8svE6nryvIhizCuYF1mPigxvrLShoKSOGnAqeE6CPTP3itbn0qZHxIfoO8QQWY6w/PF9d50YECwVnwrS/m4Wxm7sdQdI0LrzE24tc+SDrk7w8oI7mw+pfqcSzlSt0xmlsNtGQuOoWtv1isYyPA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 1, 2023, at 21:21, John Paul Adrian Glaubitz wrote: >> I think ideally all the I/O port stuff in arch/sh/ could just be >> removed after the conversion to asm-generic/io.h, but the >> microdev_ioport_map() function oddity gets in the way of that, >> unless someone wants to clean up that platform. As far as I >> can tell, the ethernet, display, USB and PCI devices on it already >> broke at some point (afbb9d8d5266b, 46bc85872040a), so it might >> be easier to remove it entirely. > > I don't have this particular hardware, so I cannot comment on this. Sure, as I explained, I'm pretty sure that nobody has tried to boot this hardware in a long time, so I did not expect you to have one. I'll try to follow up with a patch to remove the platform later on, based on the explations above. >> Having the series go into linux-next sounds appropriate like this, >> the entire purpose of that is to find such bugs and Andrew can jus >> fold the fixup into the broken patch. >> >> Let me know if you prefer the simple version with the extra >> #defines or if we should just use the generic inb/outb implementation >> immediately and drop microdev in a separate patch. > > Please go ahead with the simple version. Done, Arnd