From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A46A4C433EF for ; Tue, 22 Feb 2022 19:51:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14F328D0002; Tue, 22 Feb 2022 14:51:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FF588D0001; Tue, 22 Feb 2022 14:51:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE2FA8D0002; Tue, 22 Feb 2022 14:51:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id DCBDB8D0001 for ; Tue, 22 Feb 2022 14:51:00 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9B0CFE8C for ; Tue, 22 Feb 2022 19:51:00 +0000 (UTC) X-FDA: 79171459080.08.9BE422A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id E95EE100008 for ; Tue, 22 Feb 2022 19:50:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645559459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hs65sHGE+MAg8ru2wq4oQPdOBMOVsHF1Qt4G5niT3/0=; b=LvqwFclonVEV6neKkaMZNx9I7ZlGqyxy9nKutosQkVLp5H/AuZmlvF7iO6WXWGqFresVOk dGENZu004NBIT/dPlcUJ4bUKaTR8c3r/2ConjE4CLvd87v4VD/+hoM8CqEVZLeaVL97cft HCnI49xBB58oYbo/Tug9bDNv885Z6KQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-155-iqpsXixgOdSEDGFA9f4hjA-1; Tue, 22 Feb 2022 14:50:58 -0500 X-MC-Unique: iqpsXixgOdSEDGFA9f4hjA-1 Received: by mail-wm1-f72.google.com with SMTP id z15-20020a1c4c0f000000b00380d331325aso1018959wmf.6 for ; Tue, 22 Feb 2022 11:50:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=Hs65sHGE+MAg8ru2wq4oQPdOBMOVsHF1Qt4G5niT3/0=; b=W+ukylVw72RLzj+8X7xUhRMu0gYTysyAR/QyIf46j+p1BCu1uVZNIMSg4zGnofrBu5 CJTXMMOitSRFkUVH/LAIbEGoj6Xlk0HQKUIAP7qtD+rS/KnNd4R1O03QOALqEplQOcrG wcG5q5MOqGpnJ/ApenPrYOhvPjB45rqIzMPwsuTpZZEhBzHcw++/Muz+WJR1mICHyFui oQCZ4JfIvf/ezbpnpUaEFxmhpi1ME6MwiLeoOb9KLTsUNRWqmffgZrjWefr7RZOz64f7 kYUhE9d94HvCLm8ZWW7V8p2nbdLl/vtIAV1XNbKuWFRWM0/9dMpMKySL44w5PN8GJRd+ X1Bw== X-Gm-Message-State: AOAM531MDr5VqlY0FUetSkOLA1Ttw+glL0St1HCGVD9bLezy/nG0fj+B yoCcrFpqeCc44RHdcISWDXfmbXzr0Gshs/zJynSBUTtOvjI2WkPtgOB4qwS3KmfjBsDWr6OSUq6 kOEoNJXKK3bg= X-Received: by 2002:adf:e10a:0:b0:1e3:3188:79c7 with SMTP id t10-20020adfe10a000000b001e3318879c7mr20737610wrz.329.1645559457111; Tue, 22 Feb 2022 11:50:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7tphXEaOO1Fx4rA4sA8xDWi0f5QH4NP76Lls9shdn0Jr3YsOCHeYZIE82dpFv7tWJ4EMI6A== X-Received: by 2002:adf:e10a:0:b0:1e3:3188:79c7 with SMTP id t10-20020adfe10a000000b001e3318879c7mr20737594wrz.329.1645559456824; Tue, 22 Feb 2022 11:50:56 -0800 (PST) Received: from ?IPV6:2003:cb:c706:7d00:477e:35d5:928f:9b7f? (p200300cbc7067d00477e35d5928f9b7f.dip0.t-ipconnect.de. [2003:cb:c706:7d00:477e:35d5:928f:9b7f]) by smtp.gmail.com with ESMTPSA id 3sm54196254wrz.86.2022.02.22.11.50.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Feb 2022 11:50:56 -0800 (PST) Message-ID: <39e919dd-f73c-6698-dd4c-e42c5cbe1494@redhat.com> Date: Tue, 22 Feb 2022 20:50:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v1] drivers/base/memory: clarify adding and removing of memory blocks To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Rafael J. Wysocki" , Greg Kroah-Hartman , Michal Hocko References: <20220221154531.11382-1-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 9n7zhij5ph78fensddmxh9r1sy5ca1zd X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LvqwFclo; spf=none (imf05.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E95EE100008 X-HE-Tag: 1645559459-275770 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.02.22 06:49, Oscar Salvador wrote: > On Mon, Feb 21, 2022 at 04:45:31PM +0100, David Hildenbrand wrote: >> Let's make it clearer at which places we actually add and remove memory >> blocks -- streamlining the terminology -- and highlight which memory >> block start out online and which start out as offline. >> >> * rename add_memory_block -> add_boot_memory_block >> * rename init_memory_block -> add_memory_block >> * rename unregister_memory -> remove_memory_block >> * rename register_memory -> __add_memory_block >> * add add_hotplug_memory_block >> * mark add_boot_memory_block with __init (suggested by Oscar) >> >> __add_memory_block() is a pure helper for add_memory_block(), remove >> the somewhat obvious comment. >> >> Cc: Andrew Morton >> Cc: "Rafael J. Wysocki" >> Cc: Greg Kroah-Hartman >> Cc: Michal Hocko >> Cc: Oscar Salvador >> Signed-off-by: David Hildenbrand > > Thanks for doing this, it makes the code much more clear. > > Reviewed-by: Oscar Salvador > >> --- >> >> Based on v5.17-rc5 and: >> [PATCH v2 0/2] drivers/base/memory: determine and store zone for >> single-zone memory blocks [1] > > Maybe just my thing, but I also had to pull in [1] in order to apply > this error-free. > > [1] https://patchwork.kernel.org/project/linux-mm/patch/20220128144540.153902-1-david@redhat.com/ Ah, yes, I forgot to mention that -- also already in -mm and -next. Thanks! -- Thanks, David / dhildenb