Re: [PATCH] nru replacement for 2.5.29

Andrew Morton
2002-07-30T00:55:28Z

Rik van Riel wrote:
>
> ...
> + read_lock(&mapping->page_lock);
> + for (page_idx = offset; page_idx > lower_limit; page_idx--) {
> + page = radix_tree_lookup(&mapping->page_tree, page_idx);
> +
> + if (!page || (!PageActive(page) && !PageReferenced(page)))
> + break;
> +
> + deactivate_page(page);
> + }
> + read_unlock(&mapping->page_lock);

A lock ranking bug here, I think.

But that is OK - I'm bringing the pagevec code uptodate.
When that's up and running I can slot all the pages
into a pagevec here and do a gang deactivate outside the
page_lock.

I wonder how to test this?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/