Re: [PATCH] modified segq for 2.5

Andrew Morton
2002-09-09T19:03:37Z

Rik van Riel wrote:
>
> On Mon, 9 Sep 2002, Andrew Morton wrote:
>
> > I fiddled with it a bit: did you forget to move the write(2) pages
> > to the inactive list? I changed it to do that at IO completion.
> > It had little effect. Probably should be looking at the page state
> > before doing that.
>
> Hmmm indeed, I forgot this. Note that IO completion state is
> too late, since then you'll have already pushed other pages
> out to the inactive list...

OK. So how would you like to handle those pages?

> > The inactive list was smaller with this patch. Around 10%
> > of allocatable memory usually.
>
> It should be a bit bigger than this, I think. If it isn't
> something may be going wrong ;)

Well the working set _was_ large. Sure, we'll be running refill_inactive
a lot. But spending some CPU in there with this sort of workload is the
right thing to do, if it ends up in better replacement decisions. So
it doesn't seem to be a problem per-se?

(It's soaking CPU when the VM isn't adding value which offends me ;))

Generally, where do you want to go with this code?