From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B889C4345F for ; Tue, 16 Apr 2024 16:52:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E4386B0096; Tue, 16 Apr 2024 12:52:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 094826B0098; Tue, 16 Apr 2024 12:52:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E50186B0099; Tue, 16 Apr 2024 12:52:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C63596B0096 for ; Tue, 16 Apr 2024 12:52:48 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 651A2140A2A for ; Tue, 16 Apr 2024 16:52:48 +0000 (UTC) X-FDA: 82015989216.27.DABADD8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 27AB480005 for ; Tue, 16 Apr 2024 16:52:45 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TntBDXit; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713286366; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZaYh7W+PZzizPKq4sMptVOZC/Y/YJezfimS2uwkDH8Q=; b=xDkI9qDS4iwf7lvavYrrB/NZREiBiija1SXuhmLqQINkHPCXP2/CoSyashTVsNG1qS6EgO uHzT0HG+3/hxAZ5UvloumKB4WYmVZ++wGns6ufSHve2936WhLSDUdbukJMKU0QnYfObrfy CBXmkCeWePUtHKxoYaLEt6R5UNysWwE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TntBDXit; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713286366; a=rsa-sha256; cv=none; b=LFkprpfhVdpimqKdEbuqXOf5UgPbz8fXMDpXAg7Gd5W9LbvBsA7Uo/+/+BkzEsX/1BhDFz s8JsGgjo9olpddi1RDzPRJ/NBB+egU77+p35W8fCFnMcstpxkdqvN0U8k5U7bCHBmR3P8S StDTbBGZHDtL8pggmLjCUFx9lKbOs4k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713286365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZaYh7W+PZzizPKq4sMptVOZC/Y/YJezfimS2uwkDH8Q=; b=TntBDXitBJnl8Pgx96Lym8EKWLOrhIjyy0aUJTq95EJ049MVZHXawAyWRmKtSF9xF7ynEo BQuIYRXXAGIV4U667NZ15Tf1vMfN8MdxN9Zm8Y6Xn1tEYynFtZ+jDzGKSc/6uBO48RJH0Y rn8uGUDjIUtExGJXnZVBYhjQnutB50g= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-GzEplv6kNh6CfngPjHhDDA-1; Tue, 16 Apr 2024 12:52:44 -0400 X-MC-Unique: GzEplv6kNh6CfngPjHhDDA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2d871dab76aso41608511fa.2 for ; Tue, 16 Apr 2024 09:52:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713286362; x=1713891162; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZaYh7W+PZzizPKq4sMptVOZC/Y/YJezfimS2uwkDH8Q=; b=jrhQp7bZPDKKMpLkrW9sAzFWW0TolsKO97MPPoBBpowhN0/zFxbqh4seLTIUChKcy7 hsAMZ5/cjNQ9XChM9uyU5cQwqTnPFyyTwbyGY4GmFQLzoEf1FnDXg5f0fvPp4hwATntR 3mh5Qwb4HxDXTUILwufOObCnyLeQZrVzGs0yw7W1ceedA10SuhkX0toQqjeNWiT53/So Ysnvnxcxt6Ww3WQOst0R7FTgfCCnBVeCthQtzz4D5vZ1kb5Asz2pFldz2yo0Rgf0UZaZ FaNyKfQbx7k9rZn3+X82Il8jeuVQaFjX5IRlNeOgv3nsmmNh3t05t9qtZdl3Jlr1vLFd wWPg== X-Forwarded-Encrypted: i=1; AJvYcCWilQFkB85NNrlQq+SxK9fV1GtTy5W2OGbp6G8xDQZ7NaoZweytI97nT6UUcSyToqgL2COjq9ptD8/OyWX7F8RJptc= X-Gm-Message-State: AOJu0YxQexgBfjBZ7w9TjFMRq8WugxP2UoajtvNf1/bb3soG9fZkifCg 4VlOcZBlSNLVm2fW/EvL/+gfR85PdLYgut65PsCyzquZoEPPGX7FQOw94x7CxaZ1+FcLIJrchHo 0eMcifi7N/z3scoNPBGEV8XJwJj5LDA4TxgYTSTeE8P8kWd3I X-Received: by 2002:a2e:91cd:0:b0:2db:7b:1a7b with SMTP id u13-20020a2e91cd000000b002db007b1a7bmr653811ljg.46.1713286362635; Tue, 16 Apr 2024 09:52:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHfPvL0GTh3f7hVBIxV4NNUxpa7nI2Y0TRfQBVAejBYoRFKGtutagthTWHw9zoPg2UFWZhCFA== X-Received: by 2002:a2e:91cd:0:b0:2db:7b:1a7b with SMTP id u13-20020a2e91cd000000b002db007b1a7bmr653783ljg.46.1713286362203; Tue, 16 Apr 2024 09:52:42 -0700 (PDT) Received: from ?IPV6:2003:cb:c718:6400:7621:b88a:e99e:2fa8? (p200300cbc71864007621b88ae99e2fa8.dip0.t-ipconnect.de. [2003:cb:c718:6400:7621:b88a:e99e:2fa8]) by smtp.gmail.com with ESMTPSA id f12-20020a0560001a8c00b0034744966ff0sm10717796wry.59.2024.04.16.09.52.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Apr 2024 09:52:41 -0700 (PDT) Message-ID: <3a0d1d1c-97f4-4c9d-bc25-9de3f3659b67@redhat.com> Date: Tue, 16 Apr 2024 18:52:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 3/3] mm/madvise: optimize lazyfreeing with mTHP in madvise_free To: Ryan Roberts , Lance Yang , akpm@linux-foundation.org Cc: 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240416033457.32154-1-ioworker0@gmail.com> <20240416033457.32154-4-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 27AB480005 X-Rspam-User: X-Stat-Signature: e6ph65dqj64pcgjyj95wm3n98m1h6ua7 X-HE-Tag: 1713286365-62744 X-HE-Meta: U2FsdGVkX18XPmrRisgJaR6/rO1zanb3921G3P9vmVlYOKf99dSJ56T0ABlbEpwrZGsa4P17QfF3en+kHkBZPcEBW0Cf3r64iP8dx3QZ/34KdoEyz2r8x3IgHNPONcU5WBda8Bmo+Z6aJWKNh5bwYxNLwx+4UyMOyJC7qQfCtI3F73UqZoKEVAFsB/gpJEnUW7iRs2mnJGIOHul/BxcGtzDTfbe+hXkrexD/pYze2SuTJ9XcMr5c7SQDoMAZVJdM80La2mfIrIR6gQaDvWVf7D7MTP2wpB1Pgf0eknOuOaU7XM/yj8WXS9n2OGetCK+N8l/C9A7WXZUVvftv1ZGgVhNwsVaGZ54y3xMacK4sNCUSIPx3KKZs7NZxeQJssZWNXjKdk7ms9qhV9PAY1U7jqqlh3OgYt4Xh0Tb4EDziv/ru+jNYAcB4URt2GVJBq55a11fx6YrBVYDC/rt3VfhQR/+ocy/+0pZUaXEDtmqLWLSRePnv0dcSGJMS4cgYcZUtccCW403wogutYvgtB4C86guuouKFb8H+QcV70x4Ku+LxNWu40O5cWiLub1oPGi3+HlrWP7e+VL63vQQuF8eBfj0Z2vjCgL5QiwwzEZI6mBHtxwfkVS5P2HXQl69hRBe+jvGXzgDGiD0djy5sNiCSoXJGzfc6QjGa6aXfKrpWlddln1jWohRzVQrKzN3IFuL/rnw++cKx5fg+LkN3rSz6GGpZcGtcg1/hTCmzXlgtIqZLdtFOtbWC4nd1iA3rJyTDUKIvMZVpm6+u63M4R/7XM6eWagHgAgZG3Apn6u0c9UAnPKVYwolxQqPDd2soMbHOpXiTMHne7wqnrouxoHodVwst6oLRLOl/liahA/lrqUWUVv5bOax/0zKm4GN/hZOUSuzeh6FBz4DxxXEGgbsHLRx4YgQvHfaHTvcvkmQfU+aGU7dxyVa09DVf9puMQhF1MICUAxBSprcJjeaMd/X ht130LVc yJ1ydFghDAzckdq5HMP6SjIKGhslMAlXNkuFayLPy5DqxBSrt1XN+lyhNl9vxsPC5pvx0IqbDUIwQf73AU5+tYWMbVc2lQYLJ7yyrHGwEeuHytw6RyfM1a8xIyITMt8R/Jfsio1M8ZTEv+3z8Wqx63D9O9W5J4+JYcyzBE1/PDodGzSMUcHobtASdG5VKuMyblcMmwUr6Y2llsa33kl0neOpYZTu5krKMQDd5z/nke22k1a6Gb1SK4+MzGKNSNa7aZJxg7ew7iYVfeqxuyIWSimH1G33gMXRjXBoZDARLEQP/9PtFpWmMSqcV7GfYjQ17gmyreCKSNqj4dNLI2AHDs9c+ECfNRwQiaV8vMLTQiPwXXptwOJL2Yc1YXFNgUKu7zvOTBIlEV0TzOGjBNTSa24z1legYOT9xGZ9EE5PvJeRRFgRy7OpTTi6sGCZD9l+QxFphC2+Cz0Vk3XRBCGyyjGhpJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> + nr = madvise_folio_pte_batch(addr, end, folio, pte, >> + ptent, &any_young, &any_dirty); >> + >> + if (nr < folio_nr_pages(folio)) { >> + if (folio_likely_mapped_shared(folio)) >> + continue; >> + >> + arch_leave_lazy_mmu_mode(); >> + if (madvise_pte_split_folio(mm, pmd, addr, >> + folio, &start_pte, &ptl)) >> + nr = 0; >> + if (!start_pte) >> + break; >> + pte = start_pte; >> + arch_enter_lazy_mmu_mode(); >> + continue; >> + } >> + >> + if (any_young) >> + ptent = pte_mkyoung(ptent); >> + if (any_dirty) >> + ptent = pte_mkdirty(ptent); >> } >> >> + if (folio_mapcount(folio) != folio_nr_pages(folio)) >> + continue; > > Why is this here? I thought we had previously concluded to only do this test > inside the below if statement (where you have it duplicated). I stumbled over these same while reviewing. It's not exactly duplicate, because it's unreliable without the folio lock. It looks more like an best-effort early check. But then, we also add it to cases where we previously wouldn't check the mapcount at all: when the folio was added to the swapcache or is already dirty. In that case, we would even see a change for order-0 folios with that new check. -- Cheers, David / dhildenb