From: David Hildenbrand <david@redhat.com>
To: Liu Shixin <liushixin2@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/thp: simplify has_transparent_hugepage by using IS_BUILTIN
Date: Mon, 29 Aug 2022 11:57:49 +0200 [thread overview]
Message-ID: <3a1e31ee-d36c-7f08-03db-65d8abda3eab@redhat.com> (raw)
In-Reply-To: <20220829095709.3287462-1-liushixin2@huawei.com>
On 29.08.22 11:57, Liu Shixin wrote:
> Simplify code of has_transparent_hugepage define by using IS_BUILTIN.
>
> No functional change.
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
> include/linux/pgtable.h | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
> index 73fb1b2af795..a108b60a6962 100644
> --- a/include/linux/pgtable.h
> +++ b/include/linux/pgtable.h
> @@ -1610,11 +1610,7 @@ typedef unsigned int pgtbl_mod_mask;
> #endif
>
> #ifndef has_transparent_hugepage
> -#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> -#define has_transparent_hugepage() 1
> -#else
> -#define has_transparent_hugepage() 0
> -#endif
> +#define has_transparent_hugepage() IS_BUILTIN(CONFIG_TRANSPARENT_HUGEPAGE)
> #endif
>
> /*
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2022-08-29 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 9:57 [PATCH] mm/thp: simplify has_transparent_hugepage by using IS_BUILTIN Liu Shixin
2022-08-29 9:57 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a1e31ee-d36c-7f08-03db-65d8abda3eab@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).