From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DDF0ECAAD2 for ; Mon, 29 Aug 2022 09:58:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7EE6940008; Mon, 29 Aug 2022 05:58:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0713940007; Mon, 29 Aug 2022 05:58:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 980AC940008; Mon, 29 Aug 2022 05:58:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 84015940007 for ; Mon, 29 Aug 2022 05:58:04 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5E60FC0A7E for ; Mon, 29 Aug 2022 09:58:04 +0000 (UTC) X-FDA: 79852179288.17.7516DAC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 314BA120013 for ; Mon, 29 Aug 2022 09:58:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661767082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QMTykbwk6AZSjQjww3HImzZvto3dksoHZ/O5A3KMEas=; b=Di9K4/0zdw7K54z7dHUadzaNcZKJQZtfQx7WsDQ9Qc3xwalHhbtSFcia8h9aDCJhdR5+mV D8AOOj1eNODwKOulkPM49lHZrcB/TiuKRzYS2Q8YSXRfY5AIZcmBsQj5/42YnMGMYDygsY /rl+x5pk8i/E4MZQJxWZ5yWD3VzqJjI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-341-SCACq9IpMQ2z71m9bTIkpA-1; Mon, 29 Aug 2022 05:57:53 -0400 X-MC-Unique: SCACq9IpMQ2z71m9bTIkpA-1 Received: by mail-wr1-f70.google.com with SMTP id o3-20020adfa103000000b0022514e8e99bso987025wro.19 for ; Mon, 29 Aug 2022 02:57:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=QMTykbwk6AZSjQjww3HImzZvto3dksoHZ/O5A3KMEas=; b=rD0coU9/5VeCQI2NfXZ9xS+SbyA1oaPDnc6S9car+aQz9E9Wld04zg5a7tT2PTsCvC SiPzFRNAoY7pwO9LMcyz+K2DY6yTtoUv2K7ITtM0UuQITsWj4PKR0mcFuDdxOo+6kcJ9 6seb/a8WIvlo7pmByYMUdlz3Y8fMbOvTAX0FWi1MTeLp+xhonje4oHFQF3WnpA61y/ed PkXtTGCIuo/rkzly96/7wtq09lY35jlqzVNzWICqyUjjiFtSIc8PTEEHk062Fp5JHmUM iDnN30OBSCJFPBCKTU2mheOCyzIg2hbr1V9FfayTR/4Kb/Wpi/zlbheSHLsB2rCKghdA lp8A== X-Gm-Message-State: ACgBeo2ddilhRvV3rnCFVUICbcHYfkgeNKzcIgW1jA9+wju2ymcJjIIN dDCb2CnXBv7cA4Kng1jW4pKrN2z/AV0CCXQNXbwEOnymrns2fdsf/0YkSDgMLCgEHCGzhhkUhv5 5CiKdRY8zAvY= X-Received: by 2002:a05:600c:4e52:b0:3a6:d89:4d1b with SMTP id e18-20020a05600c4e5200b003a60d894d1bmr6563028wmq.150.1661767072726; Mon, 29 Aug 2022 02:57:52 -0700 (PDT) X-Google-Smtp-Source: AA6agR5pV92QAfBCLPVvi2BsGMldnaMsefPjmkba7aw6nv6pWQEK47OKVWgsQZ7B0jFoE7EkW4pukg== X-Received: by 2002:a05:600c:4e52:b0:3a6:d89:4d1b with SMTP id e18-20020a05600c4e5200b003a60d894d1bmr6563012wmq.150.1661767072501; Mon, 29 Aug 2022 02:57:52 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:3900:658b:bed0:4260:4c25? (p200300cbc7073900658bbed042604c25.dip0.t-ipconnect.de. [2003:cb:c707:3900:658b:bed0:4260:4c25]) by smtp.gmail.com with ESMTPSA id m3-20020a05600c4f4300b003a84375d0d1sm4810726wmq.44.2022.08.29.02.57.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Aug 2022 02:57:50 -0700 (PDT) Message-ID: <3a1e31ee-d36c-7f08-03db-65d8abda3eab@redhat.com> Date: Mon, 29 Aug 2022 11:57:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] mm/thp: simplify has_transparent_hugepage by using IS_BUILTIN To: Liu Shixin , Andrew Morton , Hugh Dickins , Kefeng Wang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20220829095709.3287462-1-liushixin2@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220829095709.3287462-1-liushixin2@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661767084; a=rsa-sha256; cv=none; b=fbIOpObtdT8L6VE1AkJFABAvcX/jITU7iIIpqtDM1nGp2pkrFIU8PM7UzPud07G19MJEwh GyEPSxT7m/8b000wcUB+mA7/KF0/6fqs4rmwTrQx+oifAG0ruWv8vbLbaz8krYNsP0hDG9 FJRSsR9sAPN3B+4Lp6jPDCnyssaokuA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Di9K4/0z"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661767084; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QMTykbwk6AZSjQjww3HImzZvto3dksoHZ/O5A3KMEas=; b=cqluHA9U0dsJet6HpCvyFV+EP70p5lXxB4aJS89Unc7DsGOJaZfShV02IzlVVKjc4i6C8s +w4q4zFl0T3P3vVxFpZ+9Rcfx1E5A75BtQ1iQqxvMF1GCSdetef1buVJ6NtZX2SEXy8COt MhLBkjQoBUyRKBqgYfrIwIj6QUjWTc4= Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Di9K4/0z"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 314BA120013 X-Stat-Signature: yqoj78hab4qfm3mgtsmmr6c14jzcypae X-HE-Tag: 1661767083-866722 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.08.22 11:57, Liu Shixin wrote: > Simplify code of has_transparent_hugepage define by using IS_BUILTIN. > > No functional change. > > Signed-off-by: Liu Shixin > --- > include/linux/pgtable.h | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index 73fb1b2af795..a108b60a6962 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -1610,11 +1610,7 @@ typedef unsigned int pgtbl_mod_mask; > #endif > > #ifndef has_transparent_hugepage > -#ifdef CONFIG_TRANSPARENT_HUGEPAGE > -#define has_transparent_hugepage() 1 > -#else > -#define has_transparent_hugepage() 0 > -#endif > +#define has_transparent_hugepage() IS_BUILTIN(CONFIG_TRANSPARENT_HUGEPAGE) > #endif > > /* Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb