From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 527A9C28D13 for ; Mon, 22 Aug 2022 15:19:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF94E8D001A; Mon, 22 Aug 2022 11:19:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA7568D0003; Mon, 22 Aug 2022 11:19:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C47728D001A; Mon, 22 Aug 2022 11:19:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B60B68D0003 for ; Mon, 22 Aug 2022 11:19:37 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1B94A1406B2 for ; Mon, 22 Aug 2022 15:19:37 +0000 (UTC) X-FDA: 79827587994.28.31D96CC Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf16.hostedemail.com (Postfix) with ESMTP id 2181F180090 for ; Mon, 22 Aug 2022 15:19:35 +0000 (UTC) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27MEsfWD028291; Mon, 22 Aug 2022 15:19:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=gjSjjeb6HXbZ4PJz0ru3MMltTzVwA8is9o8omZ87Do8=; b=cgfz4FB207JoQHHpCvK5c567vezCAu86av/Q4Yt/U8AICT30C9WGWBf82djntsUMvNnp fFhH8//fDK2GII6h1A0THt6XUSgbk7XHhBSMX4VbveeHC/r4hwsFEm1TTRBtTjsVUEdt HxchM8rhtithz/HtXwIk477lU2wVURmKCRrbU/FaJ4w8OdcyRXkrXYQJI4We53nbV+Rh FvATiZJ5mqWtZ8eWcrjM5n3marNF0BgEb2G/yvW4+7dOtJt0RJuBYGmWi7X5NYjkYOSG +xJreneM+Y8AhuphaUCrQaDCrxwhhXVn3qv/KlEvrXIr0CyK5O22oZDwReLsLPsXaZru sA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3j4byugsph-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Aug 2022 15:19:26 +0000 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 27MEuQDS001764; Mon, 22 Aug 2022 15:19:26 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3j4byugsng-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Aug 2022 15:19:26 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 27MF7Bh8014877; Mon, 22 Aug 2022 15:19:23 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma06ams.nl.ibm.com with ESMTP id 3j2pvj2m78-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Aug 2022 15:19:23 +0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27MFJKIo33882554 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Aug 2022 15:19:20 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1F2364203F; Mon, 22 Aug 2022 15:19:20 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B231842041; Mon, 22 Aug 2022 15:19:19 +0000 (GMT) Received: from oc-nschnelle.boeblingen.de.ibm.com (unknown [9.155.199.46]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 22 Aug 2022 15:19:19 +0000 (GMT) Message-ID: <3a797c5ccde91c7791b3bdd3d81391a8fb38f2c5.camel@linux.ibm.com> Subject: Re: [PATCH v2 09/11] s390: mm: Convert to GENERIC_IOREMAP From: Niklas Schnelle To: Baoquan He , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, akpm@linux-foundation.org, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, linux-arm-kernel@lists.infradead.org, Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , linux-s390@vger.kernel.org Date: Mon, 22 Aug 2022 17:19:19 +0200 In-Reply-To: <20220820003125.353570-10-bhe@redhat.com> References: <20220820003125.353570-1-bhe@redhat.com> <20220820003125.353570-10-bhe@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: GQkeq9zSrtetDjoo_C8iinzSj8IKTQy4 X-Proofpoint-GUID: kOW_YKOLgXVunL8dNIQoxyXwzpBumFlg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-22_09,2022-08-22_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 bulkscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 mlxlogscore=870 lowpriorityscore=0 adultscore=0 clxscore=1015 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208220064 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661181576; a=rsa-sha256; cv=none; b=DIHZtOapqPQa+Ukt2kncbQrXS4QdqLoIbQ3h8ZD64VRwJHrTIvTSy/ixxvvPDDZ7dpc+of wQBlEzXnM7t+jsqA5z9Aul38i7SoCCNz9UX36klh6gESWNStkDhcYjWSBdhjQ5CZYFcyJc yw5vy76mX8SYs/awaxN/9CjCMdI6fFA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=cgfz4FB2; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf16.hostedemail.com: domain of schnelle@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=schnelle@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661181576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gjSjjeb6HXbZ4PJz0ru3MMltTzVwA8is9o8omZ87Do8=; b=bykHvITyxhIoCX/2OqDZYfXWEIOuJJg1dFToVuftDH5N0YWXhemCKR53xOvu7sLvqB2eDU 4RUAi59GFntEjKJi1oIpYW9rf98ivb2b1aaH9McWllwnBxhTOgclGdPNmG97dXxPcBOOui KsdY9zTAhvOXaDB5MQz392TQA+fFZeY= X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=cgfz4FB2; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf16.hostedemail.com: domain of schnelle@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=schnelle@linux.ibm.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2181F180090 X-Stat-Signature: 6iwmatq57y3xnnsddzenawj3iq5curjw X-HE-Tag: 1661181575-303166 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 2022-08-20 at 08:31 +0800, Baoquan He wrote: > Add hooks arch_ioremap() and arch_iounmap() for s390's special > operation when ioremap() and iounmap(), then ioremap_[wc|wt]() are > converted to use ioremap_prot() from GENERIC_IOREMAP. > > Signed-off-by: Baoquan He > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Alexander Gordeev > Cc: Christian Borntraeger > Cc: Sven Schnelle > Cc: linux-s390@vger.kernel.org > --- > arch/s390/Kconfig | 1 + > arch/s390/include/asm/io.h | 26 +++++++++++------ > arch/s390/pci/pci.c | 60 +++++--------------------------------- > 3 files changed, 26 insertions(+), 61 deletions(-) Sorry I missed this mail until now and will still need a bit of time to review and test the code as this is indeed pretty special on s390. From a first glance this does look like a nice simplification. Just out of curiosity, I wonder why get_maintainers.pl didn't add me nor Gerald for direct CC despite the bulk of the changes affecting arch/s390/pci/*. > > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig ---8<---