From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52BA8C47258 for ; Tue, 23 Jan 2024 11:31:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C61EF6B0083; Tue, 23 Jan 2024 06:31:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C12446B0087; Tue, 23 Jan 2024 06:31:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB27D6B0089; Tue, 23 Jan 2024 06:31:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9C4456B0083 for ; Tue, 23 Jan 2024 06:31:51 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 68A45140AA4 for ; Tue, 23 Jan 2024 11:31:51 +0000 (UTC) X-FDA: 81710361222.02.38792C7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 0D6C840011 for ; Tue, 23 Jan 2024 11:31:48 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XlxMaVAG; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706009509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yf61M8UqrExnva1oDmd/loE0AIxUjfiEYWfUe179FRY=; b=U4uNdW2s6Z71qofLeHFofgMp02Y79YVMrODDDIrVCVmzUGH2HaqtEmvL51Xja9mx4a0yln 2XKbfDL0BtlDPVuU6/pnKf6LVqA8G8MxTOQxHmELbupABPGJKUuGVGmRhPBBU89dLirB1o 9I2MqndZtxJmj2dErEumm0Bdys1Kpgo= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XlxMaVAG; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706009509; a=rsa-sha256; cv=none; b=NE4tCdS9aO/I1IPi0MoE8To4wlJqCc2EGP9rfOqQ6nkh706oLct6kHROvB4K2rnnVfdJfr l0kV/puOsrTTir200MeBoji3qAe5afc3w654XzQpkCDL+SZkpiRlb/VLzt+VSrNiydbO6Y xObZ/XkxQARtMiOlIWKwOH49zafbAec= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706009508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Yf61M8UqrExnva1oDmd/loE0AIxUjfiEYWfUe179FRY=; b=XlxMaVAGzcpYnTE3buI0uc8CSF/fW5pxDN91eEb5xQ6Sc5hsS/eB20Crw2uFTwYZVaaoeL lHqjsO3/yCZr+pjO2zaMT8RlTAb0kpfqR8ORjPLZIl8skTJUp1mV53oSzUUB69YkcOSaMB twbL8FtfikbsQnomkzGPe6k1eVR/Tp4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-458-FCIqzfCqM2eV58ODHeOHUQ-1; Tue, 23 Jan 2024 06:31:46 -0500 X-MC-Unique: FCIqzfCqM2eV58ODHeOHUQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40e9d8e9a39so36180595e9.0 for ; Tue, 23 Jan 2024 03:31:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706009506; x=1706614306; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Yf61M8UqrExnva1oDmd/loE0AIxUjfiEYWfUe179FRY=; b=j35Pz/hbhKyoR5++ngl9jPYjDlbFYpOaNsM5aRPhKi4E6FwzNYpwEHAvUmP3iekd2n osQrZ6MV/dWKPkWquXpp/am0dYEaNNXKYkQDT3ywfCwa994SqZLFvI3TTaUKQHYO/ToT 9WwMkS5lDRyGHXS0Bqg5WKOWNoj56+N7PnwmS43WXZqB50eILN1mmJ3tY09hDeRfnH1c xLuoYdQOCAHDutC8XiaM8dcS7/wV/YyCkETU1p8Ep4CIlGFdRxNRJ4yXIcTp8bkwCJaJ wn2JiE/T8Kg0Uh2xBCk4oG8/OFM2qnG9nbqJonrdzLTvh7droGKY2E46kvbmUjTgb8n1 CMHw== X-Gm-Message-State: AOJu0YwsD/e7GS0y6VflucBGQ/dkh6lGsZh5cdBQUQxdWIHl097EC/N9 MRopmkHV70Bg9kN4UvuXo23PmPeSuFIwo1u5ZNoKOSaJE4DONQFhNZtdYOFV84U+qbdFvuVAn3Q 0zrTr5gdnaElOwy/HAYPc2wMs96UkBaHalD8gjfj5FV7kKqw2 X-Received: by 2002:a1c:7702:0:b0:40e:7677:c25b with SMTP id t2-20020a1c7702000000b0040e7677c25bmr461572wmi.126.1706009505718; Tue, 23 Jan 2024 03:31:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IETOIsx9qzxq/2tWmfpQRgqVviNsiTQTmRoU7sl76OQkf5tkaz5plMB0WrHvRb6RwgDJ4jEKA== X-Received: by 2002:a1c:7702:0:b0:40e:7677:c25b with SMTP id t2-20020a1c7702000000b0040e7677c25bmr461558wmi.126.1706009505357; Tue, 23 Jan 2024 03:31:45 -0800 (PST) Received: from ?IPV6:2003:cb:c741:de00:bf0f:cd46:dc1c:2de9? (p200300cbc741de00bf0fcd46dc1c2de9.dip0.t-ipconnect.de. [2003:cb:c741:de00:bf0f:cd46:dc1c:2de9]) by smtp.gmail.com with ESMTPSA id w15-20020adfec4f000000b00338a3325331sm11193798wrn.69.2024.01.23.03.31.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jan 2024 03:31:45 -0800 (PST) Message-ID: <3a970289-a72f-418e-b43c-89f67f0d5283@redhat.com> Date: Tue, 23 Jan 2024 12:31:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64 To: Christophe Leroy , Ryan Roberts , "linux-kernel@vger.kernel.org" Cc: "linux-mm@kvack.org" , Andrew Morton , Matthew Wilcox , Russell King , Catalin Marinas , Will Deacon , Dinh Nguyen , Michael Ellerman , Nicholas Piggin , "Aneesh Kumar K.V" , "Naveen N. Rao" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S. Miller" , "linux-arm-kernel@lists.infradead.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "sparclinux@vger.kernel.org" References: <20240122194200.381241-1-david@redhat.com> <20240122194200.381241-2-david@redhat.com> <46080ac1-7789-499b-b7f3-0231d7bd6de7@redhat.com> <6703b648-10ab-4fea-b7f1-75421319465b@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0D6C840011 X-Stat-Signature: x8p7s4k94p6s6jrkbnukuhm5e347rkfu X-Rspam-User: X-HE-Tag: 1706009508-330080 X-HE-Meta: U2FsdGVkX180MZk1C/y2fvwgvD8HAG13q1B/+44QSMLu5SY0SFTX7dLhuCXAgy8J07uThViveKSfQr6oJkMAjPS/t8pAfeNP+biyCXv5ql1f11jTohDQGBTyP6AyPBHPWdvsNcMwvuyyLTJ9yzFjOfJiQwjij3Tjjhqz9KXNFsvmiZMf5oAts6oA90v78aS5P9WrD0EhkxJSuFkEHiVu229I32ml+IV9+4+QamNx8KT04Jt2KrUcyQ0lAuFLGyAOdFffkwN8DT3UHHq65ZYBr+aAQJDH2Xy0nUHcre5WvaSc+kHIMUI+5GZ8yINm/G4GmTdhQG+bwwrvtNksRpKgxhxaOdTKyUdhvWZQvH5IpCX0x3cMvaTMZRWtqfBtgc73NPnObSQhpo8RJaNO+N4G0u27uR0ISZLSDWa5kGhUKX02Bia6t8ai+DPd3h6sss5jByl+2iZgqPVQ4rftjO4eemQNFDxbA0rSNj7ROPIptdSFr7WxULQ3tnCipAzms44EUEOtPwGFTzmXe8HdpWSg6AgArUWm7V6779cL3SG2PVhxOZcLbHl1wpOBa0QJLJgLAlrji9JyPEjrKNQsFC6nZZUX5+7tAY4Sczvdt3ulv/n4HCNtsIrsHLhKJXgQZa/qbOi0g5fr2TD9HrRpOcVIO6yDuuqnIjSnTD0GB5Wdk5boTfdoPM+XWHJxBeHAbFxZt4yshqQIeiX8rPLhYt8TgHYMTOKTEjI0Qc4XcKEJACEfJxf7qFfu6p3wsthzKZETsteXl7GK1KcRrZvhmSqRTKEA6DUzpqu2LpWMZB+IZquKbNoHZDnYmyPC7XzXbUkPimOk4f/J1wDRvysxp5IMRhV3YEBSzxje9Zq2VFiuBzRtmpJMowFepBGkwXA2mnG6EG1c63ALf4iTIbilKaHbk86wIbyDQ8fyh8axnna72NEHYN4/b7++J3HURut8bZJQU83eMaid4F0/KEU6aSA 8h6PdeIk TlxDgbLWwvj0vX+dWOb4vJlmq8dkus7L1Vl6s3G6kjGIVmv1mb71essF353DN2SAGJpKALue76+bs0nVZ7K5/3kOQ3O0lVoMtooy+o3uBSprhELbDxKJyppAE4nx+EKjKSwF1Up5E27MgEuiihi8vXFaezUDSlpoP2fHBZcyaBfngcWd9VREa3yxRIf+vR4FWIXDtdSRwJKzGpbMYX38FaP24qIczPZPVXDAykbyGOC47oLvHC2yAEETRTqidZBG2nw06UVfLLTI4Jiaoqaon4t3wXsYZxbrjD2gMRoWPrgyajbH/fcCti2T9JbkDKQluWel1r9P38ybPwAa0TDTxCr3ZPUGMF9oewdZg9T7K3Dxo9KnSjASAu9tptyu1SVQjHZRVZyMpBmga/bcfcbG/mH0VNb85mNHj6+Kze3ma8p0xsh3vhnSVR0GmKFKIFTuRYNLKHtvrrzYrMYrCZpWUdv6KAGE1lston5G8hfO69CDDcASEVyTSKOPGPUJYUaOAe1uG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> >>> If high bits are used for >>> something else, then we might produce a garbage PTE on overflow, but that >>> shouldn't really matter I concluded for folio_pte_batch() purposes, we'd not >>> detect "belongs to this folio batch" either way. >> >> Exactly. >> >>> >>> Maybe it's likely cleaner to also have a custom pte_next_pfn() on ppc, I just >>> hope that we don't lose any other arbitrary PTE bits by doing the pte_pgprot(). >> >> I don't see the need for ppc to implement pte_next_pfn(). > > Agreed. So likely we should then do on top for powerpc (whitespace damage): diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c index a04ae4449a025..549a440ed7f65 100644 --- a/arch/powerpc/mm/pgtable.c +++ b/arch/powerpc/mm/pgtable.c @@ -220,10 +220,7 @@ void set_ptes(struct mm_struct *mm, unsigned long addr, pte_t *ptep, break; ptep++; addr += PAGE_SIZE; - /* - * increment the pfn. - */ - pte = pfn_pte(pte_pfn(pte) + 1, pte_pgprot((pte))); + pte = pte_next_pfn(pte); } } -- Cheers, David / dhildenb