From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A677C48291 for ; Mon, 5 Feb 2024 08:08:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60B716B0072; Mon, 5 Feb 2024 03:08:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BA396B0074; Mon, 5 Feb 2024 03:08:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A97B6B0075; Mon, 5 Feb 2024 03:08:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3B2B76B0072 for ; Mon, 5 Feb 2024 03:08:53 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B6205A02E6 for ; Mon, 5 Feb 2024 08:08:52 +0000 (UTC) X-FDA: 81757024104.01.A82CE94 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) by imf02.hostedemail.com (Postfix) with ESMTP id C711780006 for ; Mon, 5 Feb 2024 08:08:50 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=cEccBrd9; spf=pass (imf02.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=gang.li@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707120531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qDHjczhceVjO1MtODZfTIEYCTueKSLyt0SDAh9/KabE=; b=mvNWFnK6mB3AnUejFpaaa8aNE6fEULeeATt7p/aK/1A+lBcRAg3XOYTdJ4sgRB+/E2spdZ VhCuwsW61C5DRPx6Ng4X2hU2fKzTMoFdcNH1MnYWL3LCPb9mXCD+Q+fdjDf3uONeDdUFf9 K0TDKERY3DC3lse6eHw1yxpYUT4MCT0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=cEccBrd9; spf=pass (imf02.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=gang.li@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707120531; a=rsa-sha256; cv=none; b=RIJ0snmpP6SWhC+5FwTXq9651mJ63NWG72NTqbrx0vIh04SSCluG+rmxPcS+Zgtjt0cW6M r+xbrZ/Y4Rr9zloJ4K8MIDRzBcZleEkgv+G0D+1iTQJil6qXTF8E5aWbDnZbvU6K+PM+AR 2B3d6WbbOF9oIAspo04eF3XmwBvVO4k= Message-ID: <3ab3961d-04e5-484d-bc71-2f33ebbefc67@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1707120528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qDHjczhceVjO1MtODZfTIEYCTueKSLyt0SDAh9/KabE=; b=cEccBrd9TGxJ7J54r5l06zjN1IQaCqrAVOQt0NsGOyJDsqA1JEWqA7g3oEbeErkWFy7av7 SykP+U5ITW1n4nnnLZVTx2bkpcBMTWzq2BRF34eVDHQtgpJOt4VqsCO5UIOsXli1CaslTN DMgRdV6jaBRoVGJHbut7rvylwlw9eBM= Date: Mon, 5 Feb 2024 16:08:37 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 1/1] hugetlb: fix CONFIG_PADATA dependency for non-SMP system Content-Language: en-US To: Muchun Song Cc: Gang Li , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Randy Dunlap , kernel test robot References: <20240204072525.1986626-1-gang.li@linux.dev> <828f990c-11af-42ad-a030-a66dde97a7f2@linux.dev> <7472563F-5C2D-4DCB-ACD6-F86D7A18BDF2@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Gang Li In-Reply-To: <7472563F-5C2D-4DCB-ACD6-F86D7A18BDF2@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: C711780006 X-Rspam-User: X-Stat-Signature: 9pi81zw43ftcnbjx5ms3do9ja7xcwby9 X-Rspamd-Server: rspam01 X-HE-Tag: 1707120530-722482 X-HE-Meta: U2FsdGVkX18pITJ17Gd4ezTm7Fz7z05YxMWZMUyMsu+FETmtS+KBZwmR83EqPcj82HZ+2BCgORyWcpkAbYW8W14YWQGo9eZ2aOFCIokgzLYXEedWEKYrZLImpOHMGG+LJX/j4RrUw/FaCd7aitHAgKY02LOEIOtdXA8bahV0x2x2FJOrB+HytkNyxCcpiyvoPNqStHhpQsqCrmj+iTiFrn+gNM8ygJuUJA8/khz7mnO2PBGe3kNXk4wVmZaQ7S4Eu1GVbyleCiF0ziINiIqDJPB14fT0p25ER1EN5XDjFs1H4Oheu/j8u8rYA02UEklo5Zk5W3G3GZ3IXkkTVCQg3onEcVEZbuB+y9GOkJCzD8p64PMltriH7znIG91UPGLPI7iZqDE4JW88IQCuzib/56qiL7jrgOT2Y310bt6rtUk6S0xUmKY/wUHzX9MwQCwTAdKH++M8SNAZf18K9Ekc9JoJ5AsilPUWZU+uaoERVd5G8JcaE8j2g1KqfK2wnDxGiZGOjSfZKiT3Hvsf2L2Dh1Xb+/yJxiD1ztSTbP/nNobydXxSk251JkgspkHE8WsTzxqV2awxB8/n/8buUSJiiPQxJ79GrR3BIgDQkqfK1kFknu5mUMjt4ilywxSFOAwsxjVMpgYPvd1ZJLydSEOI+2hBNPhFQxhK3sPArbao9Pqa2xDQOGZi1/E5JnDXIPsstC8rLCc9J3QoeLAwpxOw8NgQhlmZb/1Qg3YIWpWDF4zyWtVRsv6baKVZ7E/aV8f/6oNALxTpjeFRGet73X0XMakjfF+mBUfboaq9sEuyGwmAfv1nveB5+Rpo1jFTvqJxyHtBYIutFkThkJA1KGo2EatUsmC9ohewRcuXm2F0MH9Xb5WCRBbPgdtEq1JDD+dNCuylNFpstkgdXIKvi2INSrAEe4hysA2L58JPA6QfFdBofr0F6lwioxJi1q6rYTQe/+Y5RI+Vievt8mlldj/ 5zsLo6rn CUwxZtxuAEYTE+W9dPGRA4YE5/tmzCeHBMJGNvz74u9rytPEM9bbK84Ee5p2ccK1QnmvcHgIu5XW199T/6MXl2Hf8ijL8DjOs2ZXjvAiF5PI64a6l5CUE4aFqDDLA/f0rdN7v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/5 15:37, Muchun Song wrote: > Actually, I did not get it. Why the above code cannot work? The above > code already make it serialized in one call, right? What do I miss here? > > Thanks. > PADATA consists of two distinct functionality: One part is `padata_do_multithreaded`, which disregards order and simply divides tasks into several groups for parallel execution. My patch use `padata_do_multithreaded`. The other part is composed of a set of APIs that, while handling data in an out-of-order parallel manner, can eventually return the data with ordered sequence. Only `crypto/pcrypt.c` use them. I guess these APIs are designed specifically for `crypto/pcrypt.c`. ``` padata_alloc padata_alloc_shell padata_do_parallel padata_do_serial padata_free_shell padata_free ```