From: David Hildenbrand <david@redhat.com>
To: Miaohe Lin <linmiaohe@huawei.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/mprotect: fix obsolete function name in change_pte_range()
Date: Tue, 25 Jul 2023 17:54:49 +0200 [thread overview]
Message-ID: <3af0795f-2ba8-2033-8b4e-e6fa889767aa@redhat.com> (raw)
In-Reply-To: <20230723033114.3224409-1-linmiaohe@huawei.com>
On 23.07.23 05:31, Miaohe Lin wrote:
> Since commit 79a1971c5f14 ("mm: move the copy_one_pte() pte_present check
> into the caller"), the explanation of preserving soft-dirtiness is moved
> into copy_nonpresent_pte(). Update corresponding comment.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/mprotect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mprotect.c b/mm/mprotect.c
> index 5c3112d92466..3f36c88a238e 100644
> --- a/mm/mprotect.c
> +++ b/mm/mprotect.c
> @@ -213,7 +213,7 @@ static long change_pte_range(struct mmu_gather *tlb,
> } else if (is_writable_device_private_entry(entry)) {
> /*
> * We do not preserve soft-dirtiness. See
> - * copy_one_pte() for explanation.
> + * copy_nonpresent_pte() for explanation.
> */
> entry = make_readable_device_private_entry(
> swp_offset(entry));
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2023-07-25 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 3:31 [PATCH] mm/mprotect: fix obsolete function name in change_pte_range() Miaohe Lin
2023-07-25 15:54 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3af0795f-2ba8-2033-8b4e-e6fa889767aa@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).