From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F582C001DE for ; Tue, 25 Jul 2023 15:55:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 671966B0074; Tue, 25 Jul 2023 11:55:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 622088D0002; Tue, 25 Jul 2023 11:55:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C3076B0078; Tue, 25 Jul 2023 11:55:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3FCD86B0074 for ; Tue, 25 Jul 2023 11:55:01 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C1A67120E60 for ; Tue, 25 Jul 2023 15:55:00 +0000 (UTC) X-FDA: 81050582760.01.CCC27F6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 6760140002 for ; Tue, 25 Jul 2023 15:54:58 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Avqv6e4+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690300498; a=rsa-sha256; cv=none; b=tfVvoZKQMJtOPem+f1V3L0ZbXYb8PzqxjwTFxkT1jWebvqVnWFrBM1Spi2mP2Fjq7bnGo2 gKYxB80PyWs9X2bChFh8fDvGgUbe8kcD1UiZTuZEltMJNtv6K1zbn0xQakQ6vX/k1F7HLM grdciImT6Bne1WIa1W4bREcpaE/hZak= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Avqv6e4+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690300498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rv8S/zcV2N2vUpm00btAH6Fups+Kl/lJF0ckKEFzR6Q=; b=ONu8CEDsKp8pzRDM3OmejNhrlTWlgaBcpjt6tr1YCT6MFiNGwPfiKJ41GJqD4jSOIahoX7 fwkgU4PC9cFeLUlm9k0vP2WX2DqBxIp0As0/7/kDJpMKSIrN9QL13Xt90ierblKVfOvd95 KS/0gZ8+hOaaSg1IrfLnPIQtOaS86Vc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690300497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rv8S/zcV2N2vUpm00btAH6Fups+Kl/lJF0ckKEFzR6Q=; b=Avqv6e4+B3Tr5aCx/Qxw3G2W1m67i/cgFG0zvJppep7iKLywjka0UmZjh6ylRj2QdMzAaS /5xlpbWVQXBjVdNiJxUXguRNPs+tRukbE5017BPF/foW1KK//ECNqb0KPaQukMnT6B8Dr2 QiJKbwO9RVyHrGTuDnuRyskVfXwn09s= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-499-Vc-bSMNTMhK_IKz7DWAS2A-1; Tue, 25 Jul 2023 11:54:55 -0400 X-MC-Unique: Vc-bSMNTMhK_IKz7DWAS2A-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fd2e286689so15334785e9.3 for ; Tue, 25 Jul 2023 08:54:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690300491; x=1690905291; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rv8S/zcV2N2vUpm00btAH6Fups+Kl/lJF0ckKEFzR6Q=; b=Gzsb17fgAjgRFi6HW9oTAioFT/QBKEX3LV/qbqajwN4/aA6y/2HfZNpK073PGrvvFs 0lrV0d+3SOqdjvPC86e/IJ2p2X6sdLJnxnDpuuS0TOTuYXmbnbN0fH0F8LZZ9hiOyNiH fhmmQ0AsSkw7O6Ovsf0pJY1VCcqYw8WmQolQzZJuRhywT3slYqvXni9HCiJAn6eawbPI Fy9yxG0C4OqpBPH9M0hoWHMaVSada12x3axXtQzCZPJCesCNK0d3qMVCuiHCtLGTxrEQ Sne9hD29LUOImqR8RMLriotF5d+e4poVGJQ9RMRNSeH9WluA/lTTyI0rpYsutfpa06w7 lpgQ== X-Gm-Message-State: ABy/qLY6Hvd3CE4fCCXgYcNbkIHYHGIU8cmzph6U+GJH1qmnYkxtoMPH E8pPl2u+j0pe6JusdduQMZBorVy3XJcauKMdcLdpoJoNt4KsDbRZPRhyUNVwifYRksQ5IpVHcWM dxwn2og1lb28= X-Received: by 2002:a05:600c:204:b0:3fc:1f8:41f1 with SMTP id 4-20020a05600c020400b003fc01f841f1mr10441620wmi.1.1690300490881; Tue, 25 Jul 2023 08:54:50 -0700 (PDT) X-Google-Smtp-Source: APBJJlHV9+assCuUkXwLKP3VEOwgoPJMwz3cWjDuEtCd3lwJvIdKbf3yEjz1rrsAQPkcMtE1lpFUag== X-Received: by 2002:a05:600c:204:b0:3fc:1f8:41f1 with SMTP id 4-20020a05600c020400b003fc01f841f1mr10441608wmi.1.1690300490541; Tue, 25 Jul 2023 08:54:50 -0700 (PDT) Received: from ?IPV6:2003:cb:c73f:e900:3b0d:87a6:2953:20d1? (p200300cbc73fe9003b0d87a6295320d1.dip0.t-ipconnect.de. [2003:cb:c73f:e900:3b0d:87a6:2953:20d1]) by smtp.gmail.com with ESMTPSA id n19-20020a7bc5d3000000b003fc02e8ea68sm16557959wmk.13.2023.07.25.08.54.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jul 2023 08:54:50 -0700 (PDT) Message-ID: <3af0795f-2ba8-2033-8b4e-e6fa889767aa@redhat.com> Date: Tue, 25 Jul 2023 17:54:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] mm/mprotect: fix obsolete function name in change_pte_range() To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230723033114.3224409-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230723033114.3224409-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6760140002 X-Stat-Signature: zgi5qoqsg5w599ix59jk3ofpp65qk8en X-HE-Tag: 1690300498-204323 X-HE-Meta: U2FsdGVkX1+9boPX4wE4jjTq4IaOvAmw1T9Z1ObO4LFIVgWWSwympDvhPkPgLRi+6pOd+EQv3TkhoNFAyh0pxTVmJe1t0jyFI9Mt2q2YqPEDZUfquIJO9t/jZ6cPGIs/MVA1uoltHd5CRpxIkO8ervOjdJ/J7AQFo3Jpfd7uSxOh90XwCjrS77/jdbW0mNceQWtdAD3jDZvpZejGoX8sU0N9//jIFEhZMcUKF07+Ocl+z866DsBeBoMtaGEJ8x/T1lJWQGuD8bzxlhNkrsdNROOqWUpf9p9oZXBIxACHD+WZTh1/mrDI1WmzT5cysUOPwV2QlZaXm5tHBDlLVVRk6Hm4yzvceJ1q+GFIGw/NSJZUf83qpdECf+QH9Hi+3IOp/QPmYXCOIoQmejLXMGctVY8pDvo/awlb0MIKsZccZ8PsJTMu6CBfHDW3epEg5SBXPyhBBdgn/1MPkTH1nRQIyZLVJK6bhIE45bhAecvoGtIT8pYKWmhLT1zGwBWoR9MTwR9M6vdKxtb+3bp5GwtHcG2yfc76SMGL5AFC+ddfazNuvDWWkl+1RGgbF1ui6evGMgNMOTKtbr/7GY93a9c87YB70Zdy0Q1fDBfFldA9FTK0uwpgfEZWR8eHSMO5ZoGuAna77vU0FtTsWhQ1kiMTyEIRD9MVusRN36J3+0sJit7o7xKLAKkhHAybIdVA6mXxR8xFD8iez5vU2QpcIbianRk8nvFNB9fahb64pCJV7CexZr7EH0mRUz/qNrtGSecVGU596sOqKTfl/On4r1kjjORv68L3kAhx2Jw9e0tVxqlgRofUKo9ECfWGt3WjHnc1sWeFl62W5ypbe9kZNea9kzbSYx0CKQmwuAiiM49cMtUDOt0IRXBVtrDFl+RqzvDd3pY4cTSV729oMKAoeYD+gYjRJeZS+oVh8PrGiGEa7xzCpx3oQjY1kfBYwrpcuydVewnwH4fIlVH4l/vSdpy O+WcfvXE mbI+9a7551EvDu5FrUy307Og+QTalzgCaRLxSD6uLYfuMdNh7qLLubTI7q7KhEBFKmWCPHpiRnK9XemTzNhQViFpu6vkz4Z4IV416fXbjKCuIPxl0YyEIWhZ5HwchAGxxVw4+ae0UE7noiBBcOqxxDpXr3O/szHYRlVjLoDgDaLvkVRinIgg/1rDPRqg/6f2FfqHQh23Mgzm8yGw1O9sVB96kSxcO9urmn5rmuZPN/NqOC/D/FSxP3BIyrq/KxX7/9K4VCdxjQGau8jC8xMfX32OwNMrfv3dNJqJH0iqYS2YN9Tv5lhOe3svnwu6/FPQIaihroAetks+YM1cgTTAwubOyLg8gFXWKpMKvx3MCv00UbK1Ah4GS/5BW2fbPtDdFwVqSH6LGhLrTuelkO1UUsJbCNfjizYyouZRZqoJJCsYlLsAhoVg1SBg+Ys0YS3rOMQINDs60xJuzLbmXvAwETOmkDrBLshJ6Lxc/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.07.23 05:31, Miaohe Lin wrote: > Since commit 79a1971c5f14 ("mm: move the copy_one_pte() pte_present check > into the caller"), the explanation of preserving soft-dirtiness is moved > into copy_nonpresent_pte(). Update corresponding comment. > > Signed-off-by: Miaohe Lin > --- > mm/mprotect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mprotect.c b/mm/mprotect.c > index 5c3112d92466..3f36c88a238e 100644 > --- a/mm/mprotect.c > +++ b/mm/mprotect.c > @@ -213,7 +213,7 @@ static long change_pte_range(struct mmu_gather *tlb, > } else if (is_writable_device_private_entry(entry)) { > /* > * We do not preserve soft-dirtiness. See > - * copy_one_pte() for explanation. > + * copy_nonpresent_pte() for explanation. > */ > entry = make_readable_device_private_entry( > swp_offset(entry)); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb