From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE193CDB474 for ; Fri, 20 Oct 2023 07:09:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1295F8D001D; Fri, 20 Oct 2023 03:09:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DA098D0003; Fri, 20 Oct 2023 03:09:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE35C8D001D; Fri, 20 Oct 2023 03:09:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E06D18D0003 for ; Fri, 20 Oct 2023 03:09:29 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A91DA4069F for ; Fri, 20 Oct 2023 07:09:28 +0000 (UTC) X-FDA: 81364964016.15.9203084 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by imf20.hostedemail.com (Postfix) with ESMTP id CA1171C0004 for ; Fri, 20 Oct 2023 07:09:24 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=none; spf=none (imf20.hostedemail.com: domain of houtao@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=houtao@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697785766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aSN6XuGDPI8Nqmoe8ktJe/FvZhE3Wh7Z6CQsV4IgDQw=; b=tIM5ctivwgygjT2doF+SW/8xfwa6xjgfGShJT5y7RD34BkxyNoD3I02v0nEI2TftuAcIuh fnOmF3WjcSHhHtd+CuMUFvSRiXG8IqeAF6AxL5uVFEQKmyKnR80cr3D6NPQclJJv4VLshr HcZFeonB2+g5rZqync9OLwMEAY/roJk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=none; spf=none (imf20.hostedemail.com: domain of houtao@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=houtao@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697785766; a=rsa-sha256; cv=none; b=k28K4OfRw3aZYxso0547eeGnOMqesUM2e6zhvvsq84vz1t+u7/EQxiidC27Qkw0MPEeLZL FQjKt9KQysSEjTi45p8zaBw+1xEZA7hSlseBwaq/ywMSjFJwiOcPqTSRNRhOrh2Wi77XGR CURO8LLljK9l6jAWyBt3LDciORzSSb8= Received: from mail02.huawei.com (unknown [172.30.67.169]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4SBbKx02Q9z4f3s6B for ; Fri, 20 Oct 2023 15:09:09 +0800 (CST) Received: from [10.174.176.117] (unknown [10.174.176.117]) by APP1 (Coremail) with SMTP id cCh0CgC3NaaWJzJlDukWDQ--.46806S2; Fri, 20 Oct 2023 15:09:14 +0800 (CST) Subject: Re: [PATCH bpf-next v2 2/7] mm/percpu.c: introduce pcpu_alloc_size() To: Alexei Starovoitov , Dennis Zhou Cc: bpf , linux-mm , Martin KaFai Lau , Andrii Nakryiko , Song Liu , Hao Luo , Yonghong Song , Daniel Borkmann , KP Singh , Stanislav Fomichev , Jiri Olsa , John Fastabend , Hou Tao , Tejun Heo , Christoph Lameter , Andrew Morton References: <20231018113343.2446300-1-houtao@huaweicloud.com> <20231018113343.2446300-3-houtao@huaweicloud.com> From: Hou Tao Message-ID: <3b502d3e-db22-f3d8-94de-f6294afcde5c@huaweicloud.com> Date: Fri, 20 Oct 2023 15:09:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:cCh0CgC3NaaWJzJlDukWDQ--.46806S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Kr13CryUtr4UCF1UCF1kGrg_yoW8tw4fpr 40gF1FyF4kAr9rGw1Sq3Wjvw1aqw4kJF4xG347WF1UAr9Ivr92gr1qvrW5uFy5Crn29r17 tFZ0qFZakFy5J3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvIb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7Mxk0xIA0c2IE e2xFo4CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r4a 6rW5MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6x kF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE 14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf 9x07UZ18PUUUUU= X-CM-SenderInfo: xkrx3t3r6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CA1171C0004 X-Stat-Signature: damngw541gybttraex6xm3psn8g3k75r X-HE-Tag: 1697785764-762852 X-HE-Meta: U2FsdGVkX18yB7x7y4JCmH7ngjSlFWMvYvMUbW28J6xQDnD16+NC7hJ4SXvJtbF2Bww3fEz8FX9FxGUhXSt/IZhDCwICwI+KufO/vfKmSE8yvZCFK/hA69mA39jkM/jtCc1gH+QDKETPOG4gZForzePqMaSO04AI3pIOuCNrhTu5EUuPGvT8+6l8pEDEDYVDlf2ft5a30tYOVkDKvuicLtdO3vj3sxo4skVrAvZVX+jLlnkhd4gkOk9q3I7/MId3pujt9YJJlTq3G54Tou4bYd7xMVs0zBRjBi3AmHy7Vb0LywGS0+2T7G2eHM9X7U/nnuF50lnjcfmYqtwoW5GB9XQKTBeGAWgV1ca80Euad8X7p8u5aHlyXIs/f40f6yPUTSzrHVRl1/cgjGBqHQTxottUC1dantyqGxC24y9jBMeNQPnJg5hNV4SwVsPpeUuGF4448ZGGHqBe/0LOwxD6Q8GV9YmJBbOViZ9WJkbWNbAStK+vvUk/M1fFsqIhcFiiB+u8NvnS/Lgg5FyrKfGKf+lGCEr/tsefTHI4J3TOmaMgI7h199Mz5/cfKOGRkcyqKZgfcgP+kWl1GgRe/6lInXg9I+EpK0NLQc42oeXQoHASvm01QiugYcZw0Pl561eZzQo/aD+GvFt23zk/GDWvu8HglPKaoKrJ659CXywUBSKOFqaUH1lYoD1emLhH5XDfLRrBq7ElX5HwcvAEf0GROc4/jfq4ijmcxNqzLw3GA+N4ugOxBebfSwex2B/N6hMGmIceNyJg2pMXeVztRL/XQDVMoBMTRYtQvF130bzqsxqCvUe/ZqWCOhVMRAz4Wc8+W04DFxaap2NnQSxfodRL7jeiF2MUCVBXkO0V3NVpcAMAkzMQ3Gn+TYY0aQSqR8P8MF0Zx7tLti1z9wEYOUK8K4FtFuuWeow9OYdIvSR3uGEk3AwyCaucx1/KvqCTAJLs7s9wUuhPTfvlT3p7wee KgZa+xvr KO98hSzimVNNmet5wWyDdUWqpB58JyR+KRxGru2n7+3yYOOXXGl/PX2654CJp66+IohSPoVsv6clum/XLGgbRL3aJM1Gy/m/P179fdByQyWG2taPoQIGLk+GA7CfekpzcOz399ggzg5/Mf9RY6mZAGvG/HshHfPhnlf0M1vb4zRz0RwMQMPGQznnJBFwuzxf80B8VrToLHL1d/wAaTdBAvgmJgiqEjaRbGGxAFrk+yHjaxmcuQMwzoFEDQV8q5D9z+T51V0uvLUBZYPPUMySvj0ga3/q2hglIzpuqSfo9acLYrs4GOb337BBcBlBWCi80TBINq0lFNBeOwZOAYFSn1iWTdAa7Mkow1YNCTNjDkz8beun3oAExo16EKL3Ig+quV4YE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 10/20/2023 12:16 PM, Alexei Starovoitov wrote: > On Thu, Oct 19, 2023 at 9:09 PM Dennis Zhou wrote: >> On Wed, Oct 18, 2023 at 07:33:38PM +0800, Hou Tao wrote: >>> From: Hou Tao >>> >>> Introduce pcpu_alloc_size() to get the size of the dynamic per-cpu >>> area. It will be used by bpf memory allocator in the following patches. >>> BPF memory allocator maintains per-cpu area caches for multiple area >>> sizes and its free API only has the to-be-freed per-cpu pointer, so it >>> needs the size of dynamic per-cpu area to select the corresponding cache >>> when bpf program frees the dynamic per-cpu pointer. >>> >>> Signed-off-by: Hou Tao >>> --- >>> include/linux/percpu.h | 1 + >>> mm/percpu.c | 30 ++++++++++++++++++++++++++++++ >>> 2 files changed, 31 insertions(+) >>> >>> diff --git a/include/linux/percpu.h b/include/linux/percpu.h >>> index 68fac2e7cbe6..8c677f185901 100644 >>> --- a/include/linux/percpu.h >>> +++ b/include/linux/percpu.h >>> @@ -132,6 +132,7 @@ extern void __init setup_per_cpu_areas(void); >>> extern void __percpu *__alloc_percpu_gfp(size_t size, size_t align, gfp_t gfp) __alloc_size(1); >>> extern void __percpu *__alloc_percpu(size_t size, size_t align) __alloc_size(1); >>> extern void free_percpu(void __percpu *__pdata); >>> +extern size_t pcpu_alloc_size(void __percpu *__pdata); >>> >>> DEFINE_FREE(free_percpu, void __percpu *, free_percpu(_T)) >>> >>> diff --git a/mm/percpu.c b/mm/percpu.c >>> index 76b9c5e63c56..b0cea2dc16a9 100644 >>> --- a/mm/percpu.c >>> +++ b/mm/percpu.c >>> @@ -2244,6 +2244,36 @@ static void pcpu_balance_workfn(struct work_struct *work) >>> mutex_unlock(&pcpu_alloc_mutex); >>> } >>> >>> +/** >>> + * pcpu_alloc_size - the size of the dynamic percpu area >>> + * @ptr: pointer to the dynamic percpu area >>> + * >>> + * Return the size of the dynamic percpu area @ptr. >>> + * >> Alexei, can you modify the above comment to: >> >> Returns the size of the @ptr allocation. This is undefined for statically >> defined percpu variables as there is no corresponding chunk->bound_map. > Good point! Will do. I will post v3 to update the API document. > > Thanks for the quick review! > > .