From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2313BC4345F for ; Mon, 6 May 2024 01:36:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88AE56B0083; Sun, 5 May 2024 21:36:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83AF26B0085; Sun, 5 May 2024 21:36:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7028C6B0087; Sun, 5 May 2024 21:36:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 57DB56B0083 for ; Sun, 5 May 2024 21:36:25 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 175BD160719 for ; Mon, 6 May 2024 01:36:25 +0000 (UTC) X-FDA: 82086255930.20.BFC1A32 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf14.hostedemail.com (Postfix) with ESMTP id BB164100009 for ; Mon, 6 May 2024 01:36:21 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714959383; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lgN23LOJLn0QCe1IyJIZFm7i6pf+0SdeyzDqc/BV3fs=; b=MQ/nI2kUUlA6i2071nDafl+5vNTXTUUzuhgTYzEKU4it+uULNHvhT8TMUFk1fqXz8kuToF IU7d/+UXFzGucnPNVT1CgWKNfii32syJ+A0Fh01BI74A0FKSUt1Jh3lc/T0zsnQa8tXfeM Taja76QZVRR4XTzKMiH6KvnFBepnYXQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714959383; a=rsa-sha256; cv=none; b=lbijyxzU+PWykdjKKuY8vxAxHLYB/vqbfdfNuKTtOjWof1AUWbMo6UumP7M+UiUUfz7PWJ xbxrr7nVclWwGQmFdwxGdwH+/ewlpVfN4bSDSjaH10MhT+DiYCuEHCOVscmX8sZb4e7fHa 5X1W4cbQ53CeAeBq0kkjIKUOTsLazgE= Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4VXkWr0Q10z4f3n6h for ; Mon, 6 May 2024 09:36:08 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id C71F11A0F1B for ; Mon, 6 May 2024 09:36:17 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP4 (Coremail) with SMTP id gCh0CgCH_nAQNDhmVahmMA--.56236S2; Mon, 06 May 2024 09:36:17 +0800 (CST) Subject: Re: [PATCH 04/10] writeback use [global/wb]_domain_dirty_avail helper in cgwb_calc_thresh To: Tejun Heo Cc: willy@infradead.org, akpm@linux-foundation.org, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240429034738.138609-1-shikemeng@huaweicloud.com> <20240429034738.138609-5-shikemeng@huaweicloud.com> From: Kemeng Shi Message-ID: <3bbfdaa6-c212-64eb-702f-7a8e18af2c67@huaweicloud.com> Date: Mon, 6 May 2024 09:36:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:gCh0CgCH_nAQNDhmVahmMA--.56236S2 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUU5R7kC6x804xWl14x267AKxVW8JVW5JwAF c2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII 0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xv wVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4 x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG 64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r 1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vI Y487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI 0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y 0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxV W8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Zr0_Wr1UMIIF0xvEx4A2jsIE14v26r1j6r4U MIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07UGYL9UUU UU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Stat-Signature: t1jebc96oj8hsd5juww5zq8uetr4rqrm X-Rspamd-Queue-Id: BB164100009 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1714959381-290824 X-HE-Meta: U2FsdGVkX18PWUqci3dc5zVBuVCwKS/ATW2uirRtA5kLARbGfk5bKAJHS+Pq5Zg1AbcQXcZ9AWydeU2VA0S+z9bjx8UCs9KgGWS3lvJwqqZU3jP5F6eXY981P1Y4tb4zWN58YMMyHe86XcvWzPN3KRIp5m+0I52xtCYP9Q7GO71VSk4n8xLUsK7yA6Kr0B+Cp50e9vESD5LxKxiI1S1glAhEsllDwgpfKpg/jospkwjIKy8nkti4UjQJEeo1npXccfTJU7bZpN1asgROrdhhjCfK8YAAZR9k9LZfjoMj7r2alCP2BrNklVLR5aotDjrrIOU2oObZRkvoeQ1154bgjrWi8dGgJtXJiBx07b7eDz1ZtDMDtV3ly+MRgN63LCl+q/+fnceRby8JAMhlHeqEKMgD+6m46GnXtd25GvMjPmriN4o7QLs0sg3GtGfQAzQxFyOJGHM2TJXzUCZgepUmajdjbbwL/dE9zHqfQ/G4dpJUgQAGc1h6x7EEOnW56jPRW88PkDBsBD9sAB4/C5y/abhh4xs29TfS/9aeD8JVQtq4gw5V0wjKk4ayderLtmUCBzZa0ahvYOrG+orX99a8Rxy1Q7mkzb5lJ1uYyyE5Gno/JJoupQw60Qb0BV38tmWvkW0+og6uodzSYtG8v0DXFklO0dGaxUUAuW2O/1aPdSQ41YUlVQ9ZnOitZlNR6X2RtugsSWmyxN/DmVcLybznNkozQYaGKjMMnho2thCBuf+GwSMjmgQD6oQ7jDt2QeDqLA+Z0cDT9qZnxzLuZn49AzM44JeUrY1d4Z3D37xb9jdDdcA5V/ZYehLS8Jrd9w88egmNvxrmqG94geWmDB01pIsgNbz9bNT5NqBGWfjItWU2VtcLID/IsajeVEPkvYYNjtlgN0Q1p5ybwsdR6/sLmoxrXhNZ8HtyvBBtOdosDboD83kloaDWNho0luocKk1XVXR51/fjaZo0pqaOShC vIMBxaV9 30Z/PHkFS0szvn4E9pKqfVHBKuAGAZG9fuvF8Fo3yW59yi+NbWGg24KnW7fWaRAFbPCm4WT8oLnwtSsSkxxd8tXkH3CQU34AcgJM97O42pgdCt78w6SuRWXVW393alR3wOOBxpl44mm4ltzXr/T6DLPNoo6zCOOzz2VYvT4/jd/arqpRxwAqmp1zSNw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 5/2/2024 12:56 AM, Tejun Heo wrote: > Hello, > > On Mon, Apr 29, 2024 at 11:47:32AM +0800, Kemeng Shi wrote: >> Use [global/wb]_domain_dirty_avail helper in cgwb_calc_thresh to remove >> repeated code. > > Maybe fold this into the patch to factor out domain_dirty_avail()? > >> + global_domain_dirty_avail(&gdtc, false); >> + wb_domain_dirty_avail(&mdtc, false); > > I'd just use domain_dirty_avail(). The compiler should be able to figure out > the branches and eliminate them and it removes an unnecessary source of > error. Sure, will this do this in next version. Thanks. > > Thanks. >