From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CF17E82CB2 for ; Wed, 27 Sep 2023 17:11:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 847F78D0098; Wed, 27 Sep 2023 13:11:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D00E8D0093; Wed, 27 Sep 2023 13:11:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6226D8D0098; Wed, 27 Sep 2023 13:11:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4986F8D0093 for ; Wed, 27 Sep 2023 13:11:50 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1B222140D7B for ; Wed, 27 Sep 2023 17:11:50 +0000 (UTC) X-FDA: 81283019580.13.8332BD0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id E0E9A1A002D for ; Wed, 27 Sep 2023 17:11:47 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Iu0FckIu; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695834708; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=26ZECuIzAzrHSPBpB0H3QfUZnnLT0zZT0ILMAOLj/qo=; b=DNJ3AcInaPNoXI0FX9NXvJrtmOAQ4iPS6GpP8ekwccxkXkwMZbbKJabNbq3EmPA5e6wKjH lxYvxV8YqvSYS2j2HYitZtNpC1QiQCn+oXe6utvxMbnkiE0MmOsUIOgqgI5seuC1k91Z8z 0+enXV+ctfn2+8wB6cI7mGCm3CFCWuY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Iu0FckIu; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695834708; a=rsa-sha256; cv=none; b=qjYNur9i6tvjj1cqtea32udv5wD7ZROXpWQCK6cJBPJ5Ip/o8CuFKwrPTO+AP+X83hTEf2 O5fShrj9z2MIDcKHkNnlmCGQVkcR436v5N+s2C8E+Hvxc4dWkXtEhjpxYohNnVLROJddFA UMaFt3zQaaa33jUDPE3HmwWewK+kF+U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695834707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=26ZECuIzAzrHSPBpB0H3QfUZnnLT0zZT0ILMAOLj/qo=; b=Iu0FckIuHOPj6bFgDRKYn5CjZgBO7esWc0XNMxt9kr5rIPsz00b5EeXWSJKkeVyr7bT/eO bS4cPYdlLeA3VMkj3mO/fJn0stTU4Juwq80IWKgq4LemY4BW5uExVb4abnKcrgZdSLGG4h R6GlqDsD1PFUapyhvq3Z5PLvyPXx3fs= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-510-r0IbtAj1OeSvL1dDXse8rw-1; Wed, 27 Sep 2023 13:11:45 -0400 X-MC-Unique: r0IbtAj1OeSvL1dDXse8rw-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5041bea78a5so17164562e87.3 for ; Wed, 27 Sep 2023 10:11:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695834704; x=1696439504; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=26ZECuIzAzrHSPBpB0H3QfUZnnLT0zZT0ILMAOLj/qo=; b=wI1DOXXYhKqw44DFCCv0GewcZfIdpqNakKxX0vQj0Eb8J8232WMvr2EKnm7FW5JgiN w9YuLByFQk6M7LQMZVY6REJxWYac9QngR5OkZ9NbqdPiczwGWVGZJ0tQv+Khtx//5IOQ GNl831iQpmW2eoa5tyQrUEKpZBUWqtlzzWNRCk9tOLJIvrrx85lYAsm/j5/UQTFJJpQ4 E3gItAxMAxwJ40zLvcLNJhd8ggsllHzTZPaQMZxD0x0uv/qgefb5O0yS1w+qIl3LT8jb vUgd3YTv1+BZRTFnFujLtN9h+NyCQs0PlgUkoFA7WhgxBxTeJyWGtHuQv/UJ+f+eq0EH 7JLw== X-Gm-Message-State: AOJu0YyIm8MWLqCJJOKsFoigkAuc3b1uLDE55YwLC0i66JMZbSA1uZ9l cdUXaczAtI//U9aH56+GnY5hm5CV17Uv8Riml/KzZKu2f3MImaegdjPjHuiMGLHR2RdtgRQ7XKU FzycHPEXEtL8= X-Received: by 2002:a05:6512:2350:b0:502:fe11:a694 with SMTP id p16-20020a056512235000b00502fe11a694mr2554998lfu.45.1695834704177; Wed, 27 Sep 2023 10:11:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHLwBPlXrmnb4AHD26hUp4ZPo2eKW8J8eyw+zBWId4dlPqrr3HlDYhpvIRYNLY7H1Jl/xXg5g== X-Received: by 2002:a05:6512:2350:b0:502:fe11:a694 with SMTP id p16-20020a056512235000b00502fe11a694mr2554982lfu.45.1695834703656; Wed, 27 Sep 2023 10:11:43 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id ck15-20020a0564021c0f00b005342fa19070sm3665635edb.89.2023.09.27.10.11.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Sep 2023 10:11:42 -0700 (PDT) Message-ID: <3c25ec6f-cd33-9445-a76f-6ec2c30755f5@redhat.com> Date: Wed, 27 Sep 2023 19:11:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 00/10] Fix confusion around MAX_ORDER To: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , Vlastimil Babka , David Hildenbrand , quic_jhugo@quicinc.com, snitzer@kernel.org, dm , Mikulas Patocka Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> From: Paolo Bonzini In-Reply-To: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 5wwcdcgfeaohxqs96ncywoohhsa8b5s1 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E0E9A1A002D X-HE-Tag: 1695834707-274238 X-HE-Meta: U2FsdGVkX1/wYnvC6cqP3iA/BNoNtbGHlfsHM8BHXoOPXJkaHwrnfkxHbJD1I9UTAfOp1QugBzI/HaKaymkNd301Nk7Ibii5nV3G0pgc+HOXRz40eCtRuGIg+FpKVB0nfgLWcalJyB2QFJbcrvdr6XGvBIra6Q0x8J4uPsO0pzlmV1Dl/UbHE2aXMy9sbDcPT3tYXmFd3VjP1/IT7Vh0Dw/YwElpYiqHoYTdneQH7SPmlEIxfXzC3omaKmRcM+Gkl6fK9ZkiFnq84QsiYGPoRDyne9DGh+w2emhHI5kGYsoqoj3HzfKVyc3ntFXUpCG48/4+sWvpUx+A1yEmIqAa8ywwpypngrcthgIh+9JHhzokfb79ELdC8RUIM2lDvHK7cyDYABMJ570ecd55CZkBwngUg7gbl1xJo+IMuhw7SIMdi0AkiN7yyUoDnyZkVF+E6MKQXZsWq8eQ2zEF2dx7in5W5gJltgjExgcDlfbas73O2REuh9FkmiF5bHQ2gWVX42qdMhwr7PCYCsmbwSxNLa0r19bqeOXmDVXGByQ4OqN2gS/+ORoxo8P4g4TIUNwSWG7brfCrFrPyQ5Jxn8hgTP7SxGHNQoehBqCtlH8JD9aa3D2M6URNHvVnCKE+p3Zo5a9ephs4TU/VPzPPY1pRz1gQT5NEUSs3m4+t7Zvi9DsExhOdDJm5ohkjU32i5kLfUgTFNw5B0rb4ylJ0dJiBI4lZHnQ992oOpHZX6xoDps7JyPBI28sFGYCRx01HefnIFUrvIa0vlALj7RNefKfAQEH907tBlr0/UckQkJg3W3nZ4vM+XTtluatnML5Pu7BHtJKIzVZiWZ/dKufhoL3wL21aFmGGUfu8i1pKg0nbTAzBU0awBOqbzQN1TABl5CFSAJCcU8qfBJj82MXgypeUg7G/0P8phiPG4mFcS6TLgOOHTaR5Kg3YljJ57GG7BpQWRINjA82J8hzNJsOJUWW L5GcWylk FAuyX5zt/1g3uIRUvmgRjdcLkJG3Sn8jWXbGXRLHGhDOD9mwUVyLRQzp2TmJyfsG2FrURef0I9SZmDdqx6wAJxy96Lq9dews++O/RGoZG33fifUdUCWpiAb4gppM0XHDhwxKu2M+5wj55ET4m2NincL1Gn5cSYnQmMFERqjXqTQQghZM2AXhQRj4lo05Lp1kaTbPVtugeVi3P6xu52tNzU1J4/Rqy3patOAKpvQ0ftHBBB+HsF5JmC01/3Nbd6NqfOcQQDULvsL5B2QncywsSf+QfHIoT6UQlFYzRrCIPzb7f0OvSSrVeJQnr/EYuZyjMloVLEasViU42q3A9zk4HGY9ai/00WdxFtNSGgE1+tCVUQrDnP2p/XH3GxfmxVe6uU7DJBHfWt6e4ghw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/23 12:31, Kirill A. Shutemov wrote: > MAX_ORDER currently defined as number of orders page allocator supports: > user can ask buddy allocator for page order between 0 and MAX_ORDER-1. > > This definition is counter-intuitive and lead to number of bugs all over > the kernel. > > Fix the bugs and then change the definition of MAX_ORDER to be > inclusive: the range of orders user can ask from buddy allocator is > 0..MAX_ORDER now. Looks like this crossed with three changes that introduced new uses of MAX_ORDER: drivers/accel/qaic/qaic_data.c: max_order = min(MAX_ORDER - 1, get_order(size)); drivers/md/dm-crypt.c: unsigned int order = MAX_ORDER - 1; drivers/md/dm-flakey.c: order = MAX_ORDER - 1; The bugs are all benign, MAX_ORDER - 1 can simply be changed to MAX_ORDER to be consistent with the new world order. CCing relevant maintainers... Paolo > Kirill A. Shutemov (10): > sparc/mm: Fix MAX_ORDER usage in tsb_grow() > um: Fix MAX_ORDER usage in linux_main() > floppy: Fix MAX_ORDER usage > drm/i915: Fix MAX_ORDER usage in i915_gem_object_get_pages_internal() > genwqe: Fix MAX_ORDER usage > perf/core: Fix MAX_ORDER usage in rb_alloc_aux_page() > mm/page_reporting: Fix MAX_ORDER usage in page_reporting_register() > mm/slub: Fix MAX_ORDER usage in calculate_order() > iommu: Fix MAX_ORDER usage in __iommu_dma_alloc_pages() > mm, treewide: Redefine MAX_ORDER sanely > > .../admin-guide/kdump/vmcoreinfo.rst | 2 +- > .../admin-guide/kernel-parameters.txt | 2 +- > arch/arc/Kconfig | 4 +- > arch/arm/Kconfig | 9 ++--- > arch/arm/configs/imx_v6_v7_defconfig | 2 +- > arch/arm/configs/milbeaut_m10v_defconfig | 2 +- > arch/arm/configs/oxnas_v6_defconfig | 2 +- > arch/arm/configs/pxa_defconfig | 2 +- > arch/arm/configs/sama7_defconfig | 2 +- > arch/arm/configs/sp7021_defconfig | 2 +- > arch/arm64/Kconfig | 27 ++++++------- > arch/arm64/include/asm/sparsemem.h | 2 +- > arch/arm64/kvm/hyp/include/nvhe/gfp.h | 2 +- > arch/arm64/kvm/hyp/nvhe/page_alloc.c | 10 ++--- > arch/csky/Kconfig | 2 +- > arch/ia64/Kconfig | 8 ++-- > arch/ia64/include/asm/sparsemem.h | 4 +- > arch/ia64/mm/hugetlbpage.c | 2 +- > arch/loongarch/Kconfig | 15 +++----- > arch/m68k/Kconfig.cpu | 5 +-- > arch/mips/Kconfig | 19 ++++------ > arch/nios2/Kconfig | 7 +--- > arch/powerpc/Kconfig | 27 ++++++------- > arch/powerpc/configs/85xx/ge_imp3a_defconfig | 2 +- > arch/powerpc/configs/fsl-emb-nonhw.config | 2 +- > arch/powerpc/mm/book3s64/iommu_api.c | 2 +- > arch/powerpc/mm/hugetlbpage.c | 2 +- > arch/powerpc/platforms/powernv/pci-ioda.c | 2 +- > arch/sh/configs/ecovec24_defconfig | 2 +- > arch/sh/mm/Kconfig | 17 ++++----- > arch/sparc/Kconfig | 5 +-- > arch/sparc/kernel/pci_sun4v.c | 2 +- > arch/sparc/kernel/traps_64.c | 2 +- > arch/sparc/mm/tsb.c | 4 +- > arch/xtensa/Kconfig | 5 +-- > drivers/base/regmap/regmap-debugfs.c | 8 ++-- > drivers/block/floppy.c | 2 +- > drivers/crypto/ccp/sev-dev.c | 2 +- > drivers/crypto/hisilicon/sgl.c | 6 +-- > .../gpu/drm/i915/gem/selftests/huge_pages.c | 2 +- > drivers/gpu/drm/ttm/ttm_pool.c | 22 +++++------ > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 2 +- > drivers/iommu/dma-iommu.c | 4 +- > drivers/irqchip/irq-gic-v3-its.c | 4 +- > drivers/md/dm-bufio.c | 2 +- > drivers/misc/genwqe/card_utils.c | 2 +- > .../net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- > drivers/net/ethernet/ibm/ibmvnic.h | 2 +- > drivers/video/fbdev/hyperv_fb.c | 4 +- > drivers/video/fbdev/vermilion/vermilion.c | 2 +- > drivers/virtio/virtio_balloon.c | 2 +- > drivers/virtio/virtio_mem.c | 12 +++--- > fs/ramfs/file-nommu.c | 2 +- > include/drm/ttm/ttm_pool.h | 2 +- > include/linux/hugetlb.h | 2 +- > include/linux/mmzone.h | 10 ++--- > include/linux/pageblock-flags.h | 4 +- > include/linux/slab.h | 6 +-- > kernel/crash_core.c | 2 +- > kernel/dma/pool.c | 6 +-- > mm/Kconfig | 6 +-- > mm/compaction.c | 8 ++-- > mm/debug_vm_pgtable.c | 4 +- > mm/huge_memory.c | 2 +- > mm/hugetlb.c | 4 +- > mm/kmsan/init.c | 6 +-- > mm/memblock.c | 2 +- > mm/memory_hotplug.c | 4 +- > mm/page_alloc.c | 38 +++++++++---------- > mm/page_isolation.c | 12 +++--- > mm/page_owner.c | 6 +-- > mm/page_reporting.c | 4 +- > mm/shuffle.h | 2 +- > mm/slab.c | 2 +- > mm/slub.c | 4 +- > mm/vmscan.c | 2 +- > mm/vmstat.c | 14 +++---- > net/smc/smc_ib.c | 2 +- > security/integrity/ima/ima_crypto.c | 2 +- > tools/testing/memblock/linux/mmzone.h | 6 +-- > 80 files changed, 210 insertions(+), 240 deletions(-) >