Re: [PATCH v3 01/11] mm/mempolicy: implement the sysfs-based weighted_interleave interface

kernel test robot
2023-12-14T09:56:47Z

Hi Gregory,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on geert-m68k/for-next geert-m68k/for-linus deller-parisc/for-next powerpc/next powerpc/fixes s390/features jcmvbkbc-xtensa/xtensa-for-next arnd-asm-generic/master linus/master tip/x86/asm v6.7-rc5 next-20231214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Gregory-Price/mm-mempolicy-implement-the-sysfs-based-weighted_interleave-interface/20231214-064236
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20231213224118.1949-2-gregory.price%40memverge.com
patch subject: [PATCH v3 01/11] mm/mempolicy: implement the sysfs-based weighted_interleave interface
config: x86_64-randconfig-161-20231214 (https://download.01.org/0day-ci/archive/20231214/202312141733.PALHOosm-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231214/202312141733.PALHOosm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312141733.PALHOosm-lkp@intel.com/

All errors (new ones prefixed by >>):

In file included from include/linux/kobject.h:20,
from include/linux/energy_model.h:7,
from include/linux/device.h:16,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from include/linux/static_call.h:135,
from include/linux/tracepoint.h:22,
from include/trace/events/tlb.h:9,
from arch/x86/include/asm/mmu_context.h:10,
from include/linux/mmu_context.h:5,
from include/linux/cpuset.h:18,
from mm/mempolicy.c:83:
mm/mempolicy.c: In function 'add_weight_node':
>> mm/mempolicy.c:3145:28: error: 'struct iw_node_attr' has no member named 'attr'
3145 | sysfs_attr_init(&node_attr->attr);
| ^~
include/linux/sysfs.h:55:3: note: in definition of macro 'sysfs_attr_init'
55 | (attr)->key = &__key; \
| ^~~~

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for DRM_I915_DEBUG_GEM
Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && DRM_I915_WERROR [=n]
Selected by [m]:
- DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=n]

vim +3145 mm/mempolicy.c

3129
3130 static int add_weight_node(int nid, struct kobject *wi_kobj)
3131 {
3132 struct iw_node_attr *node_attr;
3133 char *name;
3134
3135 node_attr = kzalloc(sizeof(*node_attr), GFP_KERNEL);
3136 if (!node_attr)
3137 return -ENOMEM;
3138
3139 name = kasprintf(GFP_KERNEL, "node%d", nid);
3140 if (!name) {
3141 kfree(node_attr);
3142 return -ENOMEM;
3143 }
3144
> 3145 sysfs_attr_init(&node_attr->attr);
3146 node_attr->kobj_attr.attr.name = name;
3147 node_attr->kobj_attr.attr.mode = 0644;
3148 node_attr->kobj_attr.show = node_show;
3149 node_attr->kobj_attr.store = node_store;
3150 node_attr->nid = nid;
3151
3152 if (sysfs_create_file(wi_kobj, &node_attr->kobj_attr.attr)) {
3153 kfree(node_attr->kobj_attr.attr.name);
3154 kfree(node_attr);
3155 pr_err("failed to add attribute to weighted_interleave\n");
3156 return -ENOMEM;
3157 }
3158
3159 node_attrs[nid] = node_attr;
3160 return 0;
3161 }
3162

--
0-DAY CI Kernel Test Service