From: David Hildenbrand <david@redhat.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memblock: Add missing debug code to memblock_add_node()
Date: Wed, 11 Aug 2021 11:36:03 +0200 [thread overview]
Message-ID: <3d2ce3dd-5032-89fc-822d-5288a9c460b9@redhat.com> (raw)
In-Reply-To: <c45e5218b6fcf0e3aeb63d9a9d9792addae0bb7a.1628672041.git.geert+renesas@glider.be>
On 11.08.21 10:54, Geert Uytterhoeven wrote:
> All other memblock APIs built on top of memblock_add_range() contain
> debug code to print their parameters.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> mm/memblock.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index de7b553baa50004c..57a9849a5d820c34 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -665,6 +665,11 @@ static int __init_memblock memblock_add_range(struct memblock_type *type,
> int __init_memblock memblock_add_node(phys_addr_t base, phys_addr_t size,
> int nid)
> {
> + phys_addr_t end = base + size - 1;
> +
> + memblock_dbg("%s: [%pa-%pa] nid=%d %pS\n", __func__,
> + &base, &end, nid, (void *)_RET_IP_);
> +
> return memblock_add_range(&memblock.memory, base, size, nid, 0);
> }
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-08-11 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 8:54 [PATCH] memblock: Add missing debug code to memblock_add_node() Geert Uytterhoeven
2021-08-11 9:36 ` David Hildenbrand [this message]
2021-08-11 13:05 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d2ce3dd-5032-89fc-822d-5288a9c460b9@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).