From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BE81C30658 for ; Fri, 5 Jul 2024 09:41:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1927D6B009D; Fri, 5 Jul 2024 05:41:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1438E6B009E; Fri, 5 Jul 2024 05:41:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFEE96B009F; Fri, 5 Jul 2024 05:41:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D13376B009D for ; Fri, 5 Jul 2024 05:41:41 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6CFAC817D8 for ; Fri, 5 Jul 2024 09:41:41 +0000 (UTC) X-FDA: 82305206802.09.0F1603C Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf14.hostedemail.com (Postfix) with ESMTP id 6C778100017 for ; Fri, 5 Jul 2024 09:41:39 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kFwRJUPC; spf=pass (imf14.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720172473; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ibRuZtrZZMgYrymHUI421xN3Rf/Vq9uiSR3JQWnYUpE=; b=cj7kyLGAIUHFq4SpEuiRgv1VkhZFaH73GCQbxbW0W9MbydkEMLvlHYeYyzGpZbe38GpTzi cupcC3QXhnmm6RdEw0DveCNo6EGMe1ri4ZJPgW/eh+dktxcOKiWaWk7E7RLlZsYfR9ds2Q APx1QE6m6Zhuwv0u4J6VSnWxsPJOtsQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720172473; a=rsa-sha256; cv=none; b=ZXX7SU0x8Ntm4a06PHXOdEW2m+9t3QKjm+TqC37x1rvy32y0R3kwDp2EUxRh49css6ywiS 4YEKq3rgakHKRf7fZpI5rjEXghaaHmVLtOLehpTd/PF7volcfeboD+IPFDQfVvh7R0+lJU NnQonxxPGpD3EzoOY2G8aWKXQl64qDA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kFwRJUPC; spf=pass (imf14.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a728f74c23dso173064066b.1 for ; Fri, 05 Jul 2024 02:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720172498; x=1720777298; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ibRuZtrZZMgYrymHUI421xN3Rf/Vq9uiSR3JQWnYUpE=; b=kFwRJUPCgL0qm5VVu9UNbqkUwqDVkCC1Ob3B7svDcXW5h1MH+T9NtZ6VjuZmRvHTCg 6arfJFf5yVhNDhZpSUFYkldgPTIWFI4z0G+JXccBIbEmXP4oX+lQjJ4vAX/OMpBBey72 NH5ZUCNX323YLcBwKTGez1BfD1qY0ppKvLC/ldFj8s65NcHyuGRT+BkhXVSJ1qUcLVpa ljoyj5Qyqo3f7CoktAId6alHuOMkkbhgMEoD1RkCdcmlM/NPbDlRLtOe6loBKLYJh8Np zzrPOfumd+Vqq/vSn57FXxcp2eWCaK94unUjyUYdyaY6L56ssSlfd9Dd3SjJmwbRRsXY /3Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720172498; x=1720777298; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ibRuZtrZZMgYrymHUI421xN3Rf/Vq9uiSR3JQWnYUpE=; b=hIlB0UK0Orr5Y//Kziax8V/ciHcZCsksAOXVtz9T/RPgFk8ig5r6aKBCMFatRaR0Hw YS72JeroF8DJACp5Fdxh0Dd3cdYT2/ZNXN2uwK0cU3c7p25MnA7LIFyCMiJDWYVtUsch 7Yy46/Vaq08K+3aFqh17yty5YL5O4mEt1lWjpdC++GESsTRDnw45EBYD3bJRqRH2Wwgu 6P+PCq744kMLJkDWkbcRZ3k0aNMM/Szq095nM/R3jQDZ73sRW4Ys+UGu1qW3pKBdWfRH vbKiUjfi+6PKrAn5ofhGWx4Z89/IasmE8EBR2tJZK5qHNf+wjm+zDuC1YwNKWp2DkJCs CPig== X-Forwarded-Encrypted: i=1; AJvYcCWfOgzgo8MFN5I9BjA2VItbnhB80PCGm3LDur1ZRZRXKAtyauZXPx2U0jMPXJ6BH4V4cwIt4qd6yVFu+mF3EEY1suQ= X-Gm-Message-State: AOJu0Yyr9nbnOFeUla4tF1DsNAna7HD9hYm0PP90/Q8WzXbxAFjk0a4+ lO8ir3ixCpH/Qq7aD/JD3KW/lTpu+SM1OQLhVNSyddMsHoo7DMYgsYohY/7i X-Google-Smtp-Source: AGHT+IG0eaX32YQsM5Si8AqpWLnDXROtFypWQmSnHANlq0N5+MIE8QkDxw3b2jmPa/HPo+5iQU33cg== X-Received: by 2002:a17:906:6b19:b0:a77:c9cc:f96f with SMTP id a640c23a62f3a-a77c9ccfaaamr110873466b.7.1720172497452; Fri, 05 Jul 2024 02:41:37 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1126:4:eb:d0d0:c7fd:c82c? ([2620:10d:c092:500::6:f496]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77c978763bsm53234366b.109.2024.07.05.02.41.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jul 2024 02:41:37 -0700 (PDT) Message-ID: <3d56d422-8d12-4ba7-9aec-704f08ecf07d@gmail.com> Date: Fri, 5 Jul 2024 10:41:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/2] mm: store zero pages to be swapped out in a bitmap To: Andrew Morton Cc: Johannes Weiner , shakeel.butt@linux.dev, david@redhat.com, ying.huang@intel.com, hughd@google.com, willy@infradead.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, Andi Kleen References: <20240627105730.3110705-1-usamaarif642@gmail.com> <20240627105730.3110705-2-usamaarif642@gmail.com> <20240627161852.GA469122@cmpxchg.org> <44a57df4-e54c-47ee-96b8-e2361c549239@gmail.com> <5743d4e4-3e34-4ac1-b4a9-0ddc4f0e624d@gmail.com> <6f8b64f8-b7b0-42f4-a1d4-bf79624cff1e@gmail.com> <20240704162256.f64fa9b6752d0d5e003f9c18@linux-foundation.org> Content-Language: en-US From: Usama Arif In-Reply-To: <20240704162256.f64fa9b6752d0d5e003f9c18@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: myh58zrc6zpa4eu76tz5i7xihydwc91f X-Rspamd-Queue-Id: 6C778100017 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1720172499-724340 X-HE-Meta: U2FsdGVkX19h3xPV9vA5mpteJAcUB+W06Zmv3ez6/paSxi6/e2mw6uFZqkjY6FZwtZKU0Wl48OFeZG1fpdCgnwElJJJ2q+wALffEjxhrU1ERwI+1iIF7XjZRjqWwl4h/joK8Kxe2iGtEvNEyoCBZLdLY7PiaXVCSMtr+meSJlhh8AcezXFMf0vQBc5ywQHGB/wA5AAN8POwgPBkR7d2uoRu7eGUhkpEMayo/qvfQtw6EtFOY5n1NiacQjw52YdrCIS0ENSB7ay2Bx8UmsiHpoZF6ZIVnL0+FjDt78H+JodlpX9DzrApBDfS2CQJQAOn9t/Lz+exBBVoMIcAlbTxmab60ipNAJnP2iZN13Po7B62cLB3LfTiG9ZS32jnoMfJJrVA4qhLt7FtVEah/9DyFPfDL44yM5cTq1Z+sMSWf9raPNEYei42bblDnHZ2g2BkmaBoqBq4lC6idfzv25hiDCNIIqppnkEfyr1G2mRbJmUhrjc/kWa4R9jD09tSZgUVCD3+1AuCwzbIu9t0eau8I8nBhwM+kjUVBQqjz9DN0JOjVqAjK7a7Q4aEjZORPlaK91rtgAwb4qD4qsg0YLDNxldaWAyq6AbcPsihTwi5YBjwOimv8DZIh5nJgdJM3kRVXs5TkahcHFYvTkwfzaI7T6NwDPmJAB5+aJS4gLGqlj85WZ/ycImJE0o3RjQkPppYD8ix+iKBrOSEX7por5T1d4XC/SFDDSXnn+x2ng7JtALjfzNCfeHT7XpH6aEf8lqvs/awbDgoJiwIxmwpo96iVYqMV231/KD1MRbKc9iSCQJj/SxMIgt44xc9Crcq5mGufPHz61nXsHGdx4RGp+c0W5fm6fIT6YvvkKFSAKFQ9vT+eabVl4AMU0YxcC/bdbV8eXVMIa2THKlpxZoY/rYH56dqxNbgrZLq21yn2A0T7JcFAFXX1C3SC7CWf/HYnNid3lrVG2puGEPuQNG1G2y3 dTuHh/wE xvqfsIFRaU8pqMbl51nbo4c0o1hRvOPhRAsHIJaPslojb2Ov8XuLqe9+egZR906IoE8Jeo1xK369Y/6HKER/5HVZYwNhvtMHpXhcuoMkoq1nIgPbudfRhrZ8Glwlb3Y412Nd0qZY7dikC71Mbt0qCrj+ee/7ezJqIlbzqxUDgN5LidCSsibFzrJzjhdzrh/V1xImFpb1D4H6nAYc/dtDQfd6S50qoSzWQWsbuvG2vl6nhithNuTaNTOlawkMHw+UuCn6up5mE7Q+f8aPhoT/dbLtU5X2hsMwHnpnMFxjAJceJruyChg2lnjA4hZEJC31lR8KW+rv7k7j8Yd/0zfhhrm0FyuDvpPZaXqy3Uue4/05dcOGByCKp+bziZbnWHPW0n9Y4rtO77sKOcxQGvWpo6eH93qRN8rIXtgA/3AZeL8EgEcjzZ4j0g8K4UA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003619, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05/07/2024 02:22, Andrew Morton wrote: > On Mon, 1 Jul 2024 20:15:46 +0300 Usama Arif wrote: > >> Changes from v7 (Johannes): >> - Give overview and explain how locking works in zeromap in comments >> - Add comment for why last word is checked first when checking if >> folio is zero-filled >> - Merge is_folio_zero_filled and is_folio_page_zero_filled into >> 1 function. >> - Use folio_zero_range to fill a folio with zero at readtime. >> - Put swap_zeromap_folio_clear in an else branch (even if checkpatch >> gives warning) and add comment to make it explicitly clear that it >> needs to happen if folio is not zero filled. >> - add missing kvfree for zeromap incase swapon fails. > > I queued the below as a delta against what was in mm-unstable. > > Can we please get this nailed down? Thanks, yes its finished. There won't be anymore changes on this anymore.