From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65F5DC2B9F8 for ; Tue, 25 May 2021 15:19:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 07D6B61159 for ; Tue, 25 May 2021 15:19:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07D6B61159 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8E6DE6B0036; Tue, 25 May 2021 11:19:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 895B36B006E; Tue, 25 May 2021 11:19:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70F406B0070; Tue, 25 May 2021 11:19:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id 3ACC06B0036 for ; Tue, 25 May 2021 11:19:30 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BC289A772 for ; Tue, 25 May 2021 15:19:29 +0000 (UTC) X-FDA: 78180112458.09.4754FB2 Received: from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com [207.171.190.10]) by imf19.hostedemail.com (Postfix) with ESMTP id DD3CC90009DE for ; Tue, 25 May 2021 15:19:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1621955969; x=1653491969; h=to:cc:references:subject:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=CSuS1/6afomgRdSmx4v4U5egysYnZihhAd5HpYugzR4=; b=ehN5zmjVHTiMmrJcTbaUz89K6ZHlHVpHF3uSLD88y6iYs4YF/65gyOCv hfIekY2niimE/6MwGrcq7KxbgJEzro6pYeOCugNLhXy83Kuv+r0eW/O3/ jaTAn/dUSlTe6J5LWJKakuP1hyLXBzdhN1IvQn245cTzqxeMOOwQ9RmxT 0=; X-IronPort-AV: E=Sophos;i="5.82,328,1613433600"; d="scan'208";a="127569130" Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO email-inbound-relay-2a-22cc717f.us-west-2.amazon.com) ([10.25.36.214]) by smtp-border-fw-33001.sea14.amazon.com with ESMTP; 25 May 2021 15:19:21 +0000 Received: from EX13D31EUB004.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-2a-22cc717f.us-west-2.amazon.com (Postfix) with ESMTPS id D372CA190A; Tue, 25 May 2021 15:19:19 +0000 (UTC) Received: from EX13MTAUEA001.ant.amazon.com (10.43.61.82) by EX13D31EUB004.ant.amazon.com (10.43.166.164) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 25 May 2021 15:19:17 +0000 Received: from u8803c614af8f5a.ant.amazon.com (172.31.190.190) by mail-relay.amazon.com (10.43.61.243) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Tue, 25 May 2021 15:19:07 +0000 To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20210520075629.4332-6-sj38.park@gmail.com> Subject: Re: [PATCH v29 05/13] mm/damon: Implement primitives for the virtual memory address spaces From: Message-ID: <3da2bb79-4448-4857-a9d1-698a360c51a2@amazon.com> Date: Tue, 25 May 2021 17:19:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210520075629.4332-6-sj38.park@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=amazon.com header.s=amazon201209 header.b=ehN5zmjV; dmarc=pass (policy=quarantine) header.from=amazon.com; spf=pass (imf19.hostedemail.com: domain of "prvs=7725d18af=sieberf@amazon.com" designates 207.171.190.10 as permitted sender) smtp.mailfrom="prvs=7725d18af=sieberf@amazon.com" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DD3CC90009DE X-Stat-Signature: 4m6thgipcmxmbmoe5hckkkwiufy17paw X-HE-Tag: 1621955961-272285 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi SeongJae, Some questions for this patch: Why do we split the regions in 3 areas (heap, stack, mmaped)? I understand we don't want to model the whole virtual address space, but why don't we just use whatever is modeled by the VMAs to define the regions boundaries? I am not quite understanding why we both set the page idle and young (in damon_ptep_mkold). For WSS computation on our end we have used pte_clear_young_notify. Why do we touch the page idle flag at all? What flags do the reclaim logic use to track access? Kind regards, Fernand