From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76D8FC54E67 for ; Wed, 27 Mar 2024 02:44:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2F0A6B007B; Tue, 26 Mar 2024 22:44:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB7C86B0082; Tue, 26 Mar 2024 22:44:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0AB56B009A; Tue, 26 Mar 2024 22:44:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9B3156B007B for ; Tue, 26 Mar 2024 22:44:22 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7026D12027E for ; Wed, 27 Mar 2024 02:44:22 +0000 (UTC) X-FDA: 81941275164.17.91B8090 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) by imf01.hostedemail.com (Postfix) with ESMTP id A2D1640014 for ; Wed, 27 Mar 2024 02:44:19 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=cTZ+xcvy; spf=pass (imf01.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.183 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711507459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YV9H8m8+M/zUWvTG1qNucKVLnNsHNqSeiCVsLZ0jiZY=; b=p2vybv12oGHa37AxPiaB7cj6qWsPlJIdP00rCUzOXdMvi4GPXleAdP7QAUZQzNAoIblf6T tLTQz8gyqaMr6+mr8NcCIjQaRBfsWXLaClwApaS6lpAdISfEfb02sLh65rHA/9bTtFjZqG CJzOSp0nchF5AhGPNDiDWclw5UG51Ls= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=cTZ+xcvy; spf=pass (imf01.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.183 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711507459; a=rsa-sha256; cv=none; b=Yiq0hb683zDKr3OcIm6ouY/G+aVfwhsW4V/mkOUdQQDjYjoBP4K/6A7hSv85JgV+epyAZz y/2pO6HPImU9JBDljuXM6lYyoW3NCBYBPPKd3r0ln4Fbo9JnSus7pUtKZIo7K+XG5Qx7fd ROmn8q/GISpy1pjv0FZE5K8K+2jwA94= Message-ID: <3e1eedef-5e4c-448f-95ea-d50b431c4265@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1711507458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YV9H8m8+M/zUWvTG1qNucKVLnNsHNqSeiCVsLZ0jiZY=; b=cTZ+xcvyv/fKg+yi81sxZkRCkjFqaUAHzDZ1hrlBPH1XAZ/4IKg97CGVzN6PK+HSGNkiT5 U5eKUmTFF27fJfnrwHSaLXTASqRuwHd/u8yb9JHHJdBJ62RypfYOVkdK8cVNwsUwWdgfKA TBXKcFBErfo+Cz3FokjtYa0q1hfii0c= Date: Wed, 27 Mar 2024 10:44:01 +0800 MIME-Version: 1.0 Subject: Re: [RFC PATCH 5/9] mm: zswap: remove zswap_same_filled_pages_enabled Content-Language: en-US To: Yosry Ahmed , Andrew Morton Cc: Johannes Weiner , Nhat Pham , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240325235018.2028408-1-yosryahmed@google.com> <20240325235018.2028408-6-yosryahmed@google.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240325235018.2028408-6-yosryahmed@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: A2D1640014 X-Rspam-User: X-Stat-Signature: n35k1dun4t9dfbejpa33iuhngcobmr8a X-Rspamd-Server: rspam01 X-HE-Tag: 1711507459-778840 X-HE-Meta: U2FsdGVkX18rA5CIMm95a5ocVllRkeAuoYZhdC/xof2QexTcbboprZINZafy7XU0qvUteuIRBloHPs9hvxvr4CbEbcYl73c1j74L6CMZhpmJnWNsjyJiLxLCh7UHdHNymgoqKtKbt6SzHbr9fTHxTHLYyY6GxkzzhENIVrhakayZTfdwY4sdww7xW216HhUcntBkCQdpQDEbU4OqsYBS1PD4cCZBPRDu6ji4UIZxVD7S2YTg/D+G1JiJ9Cx6zn16OLzNrclsLSDaf3WpZ12plbSONQgv23HytNu8MxnVR3/H3SQDCXY9l5t5EZJ8VjsnjrJiMyOjZzseqm3+QpfbxFT+rHQvkDWLeoDsBHGc2dJZiApBY+1enVXFVd69nI9W1zH4WhNefvmW3wgwk7Z8AgCMM3nQCiKXlCIviq01wzMDJbQ/1dR89GPduIpRhmXxwDhA+5Wb8l8mAc4QKG0bLHa0iUjNyWF+F3r5uSh47bC4WSGp2Twk/HrkLmIxsqLTNullYABDJJYKVOrkoHadi6PBJNW0LSJ6qcPZIkXYZ4UetLyta7q/VK8/dZg3yleQ8aBnPSsNIkpn+Xs8D1/TnQG4Y1FMYyGlAI2JEtdG3tfZJZ2AAivAglwWnb/SNpNjbz1KCJChDB4uEdbE4AcTQ8aEbfMnzuyW+AScExKZ03Ffru+ibFxG8jvOqdJcc2bGNUmAwJj4MmgnEYDIzPyJzOfJ3W4MuoicG/mE0GUKxFNccMpNQipxpqtx9Eyt2P87Mv4l1Yd+luT3R5HStjdBDfeAaOJRE1bD/XLu8IX29OgkSujwM/67o0V94BQZRc+Rz1IERPEDmpoUYhAF89JsaM8n/jEcjxtNlqUWoXL2tG1q1gaaPdHchSwVXWQweeSUmhWBPuqc8rsW2Nkd47pHCcnMvR6VXaXADdwdkXwoBYgHTrUdnLEggoyNSSYBJAOO5IyurkRfbEStLJ9VWh5 robgA6FY 2OfsFrsbXo0J6NXXnrbXHNGkMVQeEbN06yhql+9XROxfnXKPVbHIU6qtQ2P2Hd5hye3QTBJn2kXLIw9YsmibsKxWIv7/H/tNFx+7CbJXvrdoBAhEhKqrQIQJHUvzOW2l+1GkHkbu3V6DcCkawNjHESuPgp9wQCfTsxHG5VEiLJU4C64ILRqsR8yumKaDiPiYB290i X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/26 07:50, Yosry Ahmed wrote: > There is no logical reason to refuse storing same-filled pages more > efficiently and opt for compression. Remove the userspace knob. > > Signed-off-by: Yosry Ahmed LGTM, should we also remove zswap_non_same_filled_pages_enabled? Not sure if it has real usage... Reviewed-by: Chengming Zhou > --- > mm/zswap.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 498a6c5839bef..0fc27ae950c74 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -123,14 +123,6 @@ static unsigned int zswap_accept_thr_percent = 90; /* of max pool size */ > module_param_named(accept_threshold_percent, zswap_accept_thr_percent, > uint, 0644); > > -/* > - * Enable/disable handling same-value filled pages (enabled by default). > - * If disabled every page is considered non-same-value filled. > - */ > -static bool zswap_same_filled_pages_enabled = true; > -module_param_named(same_filled_pages_enabled, zswap_same_filled_pages_enabled, > - bool, 0644); > - > /* Enable/disable handling non-same-value filled pages (enabled by default) */ > static bool zswap_non_same_filled_pages_enabled = true; > module_param_named(non_same_filled_pages_enabled, zswap_non_same_filled_pages_enabled, > @@ -1392,9 +1384,6 @@ static bool zswap_is_folio_same_filled(struct folio *folio, unsigned long *value > unsigned int pos, last_pos = PAGE_SIZE / sizeof(*page) - 1; > bool ret; > > - if (!zswap_same_filled_pages_enabled) > - return false; > - > page = kmap_local_folio(folio, 0); > val = page[0]; >