linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Rik van Riel <riel@surriel.com>
To: Chris Li <chrisl@kernel.org>, Yosry Ahmed <yosry.ahmed@linux.dev>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton	 <akpm@linux-foundation.org>,
	Kairui Song <kasong@tencent.com>,
	Kemeng Shi	 <shikemeng@huaweicloud.com>,
	Nhat Pham <nphamcs@gmail.com>, Baoquan He	 <bhe@redhat.com>,
	Barry Song <baohua@kernel.org>,
	Chengming Zhou	 <chengming.zhou@linux.dev>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
		pratmal@google.com, sweettea@google.com, gthelen@google.com,
	weixugc@google.com
Subject: Re: [PATCH RFC] mm: ghost swapfile support for zswap
Date: Wed, 26 Nov 2025 16:58:56 -0500	[thread overview]
Message-ID: <3e90ccb0a3fd20e9b2d6e2cf19db9590394f7edc.camel@surriel.com> (raw)
In-Reply-To: <CACePvbUB8wjEH1rsaRs+LwX4RKGrjLFSGzjhgrdS3e7Lcz6BeQ@mail.gmail.com>

On Tue, 2025-11-25 at 22:50 +0400, Chris Li wrote:
> 
> > - We still cannot do swapoff efficiently as we need to walk the
> > page
> >   tables (and some swap tables) to find and swapin all entries in a
> >   swapfile. Not as important as other things, but worth mentioning.
> 
> That need rmap for swap entries. It It is an independent issue.
> 

Wouldn't rmap for swap entries be more expensive than
simply always having indirection for swap entries that
are in use?

With indirection, swapoff can just move pages from
the being-swapoffed device into the swap cache, and
if needed the memory can then be moved to another
swap device, without ever needing to find the page
tables.

This sounds like an uncommon scenario, but it is
functionally identical to what is done to pages
during zswap writeback, where the page table entries
stay unchanged, and the swap page is simply moved
to another backend location.

Why implement two things, when we can have one
thing that does both, with no extra complexity
over what zswap writeback needs?

-- 
All Rights Reversed.


  reply	other threads:[~2025-11-26 21:59 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21  9:31 [PATCH RFC] mm: ghost swapfile support for zswap Chris Li
2025-11-21 10:19 ` Nhat Pham
2025-11-22  1:52   ` Chris Li
2025-11-24 14:47     ` Nhat Pham
2025-11-25 18:26       ` Chris Li
2025-11-21 11:40 ` Johannes Weiner
2025-11-22  1:52   ` Chris Li
2025-11-22 10:29     ` Kairui Song
2025-11-24 15:35     ` Nhat Pham
2025-11-24 16:14     ` Rik van Riel
2025-11-24 17:26       ` Chris Li
2025-11-24 17:42         ` Rik van Riel
2025-11-24 17:58           ` Chris Li
2025-11-24 17:27     ` Johannes Weiner
2025-11-24 18:24       ` Chris Li
2025-11-24 19:32         ` Johannes Weiner
2025-11-25 19:27           ` Chris Li
2025-11-25 21:31             ` Johannes Weiner
2025-11-26 19:22               ` Chris Li
2025-11-26 21:52                 ` Rik van Riel
2025-11-27  1:52                   ` Chris Li
2025-11-27  2:26                     ` Rik van Riel
2025-11-27 19:09                       ` Chris Li
2025-11-28 20:46                         ` Nhat Pham
2025-11-29 20:38                           ` Chris Li
2025-12-01 16:43                             ` Johannes Weiner
2025-12-01 19:49                               ` Kairui Song
2025-12-02 17:02                                 ` Johannes Weiner
2025-12-02 20:48                                   ` Chris Li
2025-12-01 20:21                               ` Barry Song
2025-12-02 19:58                               ` Chris Li
2025-12-01 23:37                             ` Nhat Pham
2025-12-02 19:18                               ` Chris Li
2025-12-02 18:18               ` Nhat Pham
2025-12-02 21:07                 ` Chris Li
2025-11-24 19:32       ` Yosry Ahmed
2025-11-24 20:24         ` Nhat Pham
2025-11-25 18:50         ` Chris Li
2025-11-26 21:58           ` Rik van Riel [this message]
2025-11-27  2:07             ` Chris Li
2025-11-27  2:34               ` Rik van Riel
2025-11-25 18:14     ` Chris Li
2025-11-25 18:55       ` Johannes Weiner
2025-11-21 15:14 ` Yosry Ahmed
2025-11-22  1:52   ` Chris Li
2025-11-24 14:57     ` Nhat Pham
2025-11-22  9:59 ` Kairui Song
2025-11-22 13:58   ` Baoquan He
2025-12-02  2:56   ` Barry Song
2025-12-02  6:31     ` Baoquan He
2025-12-02 17:53       ` Nhat Pham
2025-12-02 21:01         ` Chris Li
2025-12-03  8:37 ` Yosry Ahmed
2025-12-03 20:02   ` Chris Li
2025-12-04  6:16     ` Yosry Ahmed
2025-12-04 10:11       ` Chris Li
2025-12-04 20:55         ` Yosry Ahmed
2025-12-05  8:56           ` Kairui Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e90ccb0a3fd20e9b2d6e2cf19db9590394f7edc.camel@surriel.com \
    --to=riel@surriel.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=bhe@redhat.com \
    --cc=chengming.zhou@linux.dev \
    --cc=chrisl@kernel.org \
    --cc=gthelen@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=kasong@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=pratmal@google.com \
    --cc=shikemeng@huaweicloud.com \
    --cc=sweettea@google.com \
    --cc=weixugc@google.com \
    --cc=yosry.ahmed@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).