From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB5CDC433F5 for ; Thu, 12 May 2022 13:45:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80F466B0074; Thu, 12 May 2022 09:45:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BFB56B007B; Thu, 12 May 2022 09:45:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 639B36B007D; Thu, 12 May 2022 09:45:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 51DD26B0074 for ; Thu, 12 May 2022 09:45:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 22FEE6E3 for ; Thu, 12 May 2022 13:45:24 +0000 (UTC) X-FDA: 79457212968.30.79C825C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 55D4C120003 for ; Thu, 12 May 2022 13:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652363122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BD6+/+j7gLqdpqs370bTvBjU//A0VeuM+56oLRoJjhU=; b=XCGS9jFV1L77VESr91js4+7UPx1R0M/HWgAWfrkHgC2KkgZO9xUJJ+NIwYQgwUhu1jCaVS GWhIbGHNOjeFdiWYyfOMQSIfh3dCpWnNrf/X4WfWXaXEv1b3noed1ZNZqbF583Q6ybkVgv y2vlfP5ujrE2uzaIgY8TDVglpPW3jBk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-187-xk26mJ3WNy65bnL4LA3qqA-1; Thu, 12 May 2022 09:45:21 -0400 X-MC-Unique: xk26mJ3WNy65bnL4LA3qqA-1 Received: by mail-wm1-f69.google.com with SMTP id m186-20020a1c26c3000000b003943e12185dso1647977wmm.7 for ; Thu, 12 May 2022 06:45:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=BD6+/+j7gLqdpqs370bTvBjU//A0VeuM+56oLRoJjhU=; b=Fk49PWNEt9DQyZplXaFRVV/RLQzoKbdlqKw7wSL/GDjbjlK6TSpVEZSPA0yMChgkjR xMJzSjEhteVo6oxfF/sKSvrSi1471KFkXmj0hrMYEiPHK18sEZxD8YDkZY+F+1u9DAOK mnM9wDQVUnv5YcrURDjSTE3PpiPYajN0KhAl5xSqroq+WVI8aHnvUd4yhxhMWywQkfd8 fZ5HAyEfHOdMegFRLTIAzfgAFA7LPJqnpKHF4pvBIJvkIpHB4R7R3PvJ/7ZHugxI8VCg G7RdLc8M2qNcq+amCs/tVP3XJKnUUu1bj/62EJnnKnbNWWDC4LGKNXvH1VInQprUjFep Elzg== X-Gm-Message-State: AOAM531o2bexclE3vbyBKBQH099PPxQkg0A1uuYkHxpYpFroIBqaiszK HY6bwQMLWOrSCMWBuhakrWgHK3ksFhcZ+04QXPu61IYpbjUmrZxTCT7mKDFTg+c1ErhpD4GUigQ V/yn3ctgBeaU= X-Received: by 2002:adf:f543:0:b0:20a:e059:2f80 with SMTP id j3-20020adff543000000b0020ae0592f80mr28127618wrp.495.1652363120591; Thu, 12 May 2022 06:45:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJhV9G34rWleiSGUVhEcVRqPAvJLjDDPBAB4htT7VKWFBhCUgdTAhposrPnuRf59EN8b5sjg== X-Received: by 2002:adf:f543:0:b0:20a:e059:2f80 with SMTP id j3-20020adff543000000b0020ae0592f80mr28127600wrp.495.1652363120330; Thu, 12 May 2022 06:45:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c701:d200:ee5d:1275:f171:136d? (p200300cbc701d200ee5d1275f171136d.dip0.t-ipconnect.de. [2003:cb:c701:d200:ee5d:1275:f171:136d]) by smtp.gmail.com with ESMTPSA id t18-20020adfeb92000000b0020c5253d8fasm4477016wrn.70.2022.05.12.06.45.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 May 2022 06:45:19 -0700 (PDT) Message-ID: <3f9e663a-2045-81d1-509e-abbe0e1fa14e@redhat.com> Date: Thu, 12 May 2022 15:45:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 14/15] mm/swap: fix the comment of get_kernel_pages To: Miaohe Lin , akpm@linux-foundation.org Cc: willy@infradead.org, vbabka@suse.cz, dhowells@redhat.com, neilb@suse.de, apopple@nvidia.com, surenb@google.com, peterx@redhat.com, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220509131416.17553-1-linmiaohe@huawei.com> <20220509131416.17553-15-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220509131416.17553-15-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: dagq7b3c9aekpt1nh5yjokai9kaku8oi X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 55D4C120003 X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XCGS9jFV; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf29.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1652363116-270672 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.05.22 15:14, Miaohe Lin wrote: > If no pages were pinned, 0 is returned in fact. Fix the corresponding > comment. > > Signed-off-by: Miaohe Lin > --- > mm/swap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/swap.c b/mm/swap.c > index 6d2c37f781f8..236b37663a1a 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -168,8 +168,8 @@ EXPORT_SYMBOL(put_pages_list); > * > * Returns number of pages pinned. This may be fewer than the number > * requested. If nr_pages is 0 or negative, returns 0. If no pages Ehm, there is only "nr_segs", no "nr_pages" :/ Want to fix that up in the same patch? > - * were pinned, returns -errno. Each page returned must be released > - * with a put_page() call when it is finished with. > + * were pinned, returns 0. Each page returned must be released with > + * a put_page() call when it is finished with. > */ > int get_kernel_pages(const struct kvec *kiov, int nr_segs, int write, > struct page **pages) Apart from that Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb