From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B21CCCF2D6 for ; Mon, 19 Oct 2026 12:24:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8DA26B0203; Mon, 19 Oct 2026 08:24:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3E096B0204; Mon, 19 Oct 2026 08:24:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 954C16B0205; Mon, 19 Oct 2026 08:24:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6AA906B0203 for ; Mon, 19 Oct 2026 08:24:40 -0400 (EDT) Received: from smtpin03.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 07B3314062E for ; Mon, 19 Oct 2026 12:24:40 +0000 (UTC) X-FDA: 85339294320.03.C4AF99A Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf20.hostedemail.com (Postfix) with ESMTP id 593C21C0005 for ; Mon, 19 Oct 2026 12:24:38 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=UIclckRe; spf=pass (imf20.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1792412678; b=2OGZdwH5FZYGwYVUbi2DqKEGmD1MZdBUbeX8HHfBc9uqllUdCGTLVBw92AhriksH5StAi1 dRGmXlukv/ZvvswF3+Z+VYE3353HdG5LH9koV6Su1dAG/+VhUZFgCqqz2oQWP4c8zRilZX TBpHz1U/sC7r4XAbGBaBKaDT5J1qk14= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=UIclckRe; spf=pass (imf20.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1792412678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PjLOjJ0vU6EmifRuz9YgBL8J8WMfaEKUpeJsLHfNMeQ=; b=nrKYVfeJyycH+hgGNmlAs9gDGl5qaOKUGteUnp72e+EFbuwsheD57hNgTcN0pJbt3pgPyk xlfFannQnTc/CwXiJeLGyNDQBl1onaI5U2PhMypaEv7kwLfFvL9EL6P7KNcSUncdUmyjdF UXuhLqgPDHyJPpLwBF9zCChWUzwzcuc= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id DC0A2601DB; Mon, 19 Oct 2026 12:24:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04A4C1F000C4; Mon, 19 Oct 2026 12:24:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792412677; bh=PjLOjJ0vU6EmifRuz9YgBL8J8WMfaEKUpeJsLHfNMeQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=UIclckReVDUKs6IGU4//3urRXgq0S9ghCmLXaRsJrj6BW+j2Qwg23bgIo9fckLFqr hxuOfaIEh9VV5IZp4JGashPMUqJqF6QAgoPBJ1EJAsjR3VamkhfW0sESBzVMbvWb3S RgHzND38ypHVJ9C1DzZdfk6bTZIAZVEvLlch1vekluuGbTgyy5kPSAwE+UdWeaeCy9 UrSFJ6pTe0eq3qTnfyUdFeA/fH7+D3eufcrORD7ftW3SFiI+WUsCFhqBpl7g9fUdR9 LQDyWJwFx5X58g8cxo3R9fkIjGZkw/A4ikJtvSBVlFqS0Z5sCnPoRSqXmvzwz32plP R9bW7waE21/tA== Message-ID: <3fcce5c1-076f-44e2-b162-9adcea52f157@kernel.org> Date: Mon, 19 Oct 2026 14:24:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/10] mm/mremap: fix calling fixup_hugetlb_reservations() on the wrong VMA To: Lance Yang Cc: akpm@linux-foundation.org, liam@infradead.org, ljs@kernel.org, vbabka@kernel.org, jannh@google.com, pfalcato@suse.de, muchun.song@linux.dev, osalvador@suse.de, linmiaohe@huawei.com, nao.horiguchi@gmail.com, agl@us.ibm.com, mel@csn.ul.ie, riel@surriel.com, peterx@redhat.com, kas@kernel.org, rppt@kernel.org, josef@toxicpanda.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20261015-urgent_fixes-v1-10-42796911043b@kernel.org> <20261018083431.15699-1-lance.yang@linux.dev> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20261018083431.15699-1-lance.yang@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 593C21C0005 X-Stat-Signature: 6uq434mcthgpojzj8b3beeua41izrgzu X-Rspam-User: X-HE-Tag: 1792412678-598648 X-HE-Meta: U2FsdGVkX19bgzguj6EQpef7Ac+YFYQ+yFUT9boKXLcf6miPQG2gpwhl5MGDyyHZSyOivN+tuW9AZnyzPqemz88cNfgSxdFswraz/agMr4tek+Ra8Udby+VvHc7obs2HkOxz8Yi5tKEcOHkukFJkhEtPN2oCE2jiz+bzBET0tryax8VLSHS+tIZIJUNLb3ZtsmlsSdCH7S3/DTamcdxqsdJ5Njnao2m5+LJG6ZqBwzpPLmMX0i9D31X7if4CHMPhACHN3WzeUCsxhWQn9dmVuDmAORSN3AWa3E4bXFzyYiRGz7g8ITukH40L3OjE53C+fFXqF93bUqCzgOi8umNHHHCyqrSS5pifREHn/8d94be6m+UhrHFCDzF5fg+XkqQgybBrPedK2Vd9FdNAj6/L2UbsuREvSNYhnFpo74AUbpD7GeFAEeolcZJNG5PkQIvIPyZZnQkMyOSRMFwMpEuOOy7wdp/InKfVNyuhZGX8mlQ63WL896TUu8ztpkPr+9nEthCx9zaCoDfVGL5UEgLgE9+Pbsm2iLxPLkP9HCS6uN5woC8Yk3n52e879LxtETockS7mBS6FyrAx5lejOCSwd9ycTNtlUsz0ISUYqmV47Klx8Ex22fIs/GJR+F/9VJnEn4UI7IDsnhhcoRuwdaul7K+tpgw1BLsWUSega1DfoqTPhATF4CNdXCnpWrkaUOat7YLD4egQ1HkvPyY8VUhqd835TQcrQBM9Pe8970A7jUli5J2kj5KlpU6FnYHQzg8gkNu6QAhLKUA/8XR/EJm6d8smCERo5UvTKmvSE5EJvfGiA2q7H3yVJ6Miraapi6K/m1AbAFMhYtsKKE811Y4Td0EVK2ZaLj4Gefh6XmsVFqNxfP8LPURghl4obA07nUhxDzwg7/oqIEbs7W4OJZxyQ5xd5DD6n8FtIfw2DjUW5ddeQ6QpeYY8nd74qfCQj26EqLQTTFwoq9vMJVH/QbM 56PzASbs VWC0DNQzuJo0MCC50PaMlfar+peUnBiUPoq6dbvmRo9Qu8IBMt1qenLflTa+QL0Rlq7gscjv5mZ5BfzQKx7r1gpvrPitxbNa7nrCcN9FLS25wgCOnQVTOkN2GxzuguW1orUaU6yGn3zRVxnZMduczrA27EHiGSYThFE0gmMp4u1FzT0GpFTg6gKe+FzeBAOxj0u36dGiexwUprerE2owlJCCWMNXPTLCbpPQmB+LVsPEJtdTzm+zF+TT0GcdPL5g7ZUmgiZkcD0CulO8itur4Hjsi6YYdLTgQIN9lYt2MkkRwiTcJ9JjmPTlBD/pVvjAjPj9JTjM+ZtvNxHd7ozncdVQFDdmU5F1STOvrk8YUmVorwFcJPtV8epZpO1yFQ/EhEMmX5xlIiZYc901MwO4ftEP1bA== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/18/26 10:34, Lance Yang wrote: > > On Thu, Oct 15, 2026 at 06:07:16PM +0200, David Hildenbrand (Arm) wrote: >> In case we fail to move the page tables, for example, because we fail >> to allocate a page table, we actually keep the old VMA. >> >> Calling fixup_hugetlb_reservations() on the old VMA is wrong. Fix it >> by just calling it on the VMA that will be removed. >> >> The user-visible impact is that the VMA loses its reservations, meaning >> that the existing reservations get stranded (leaked) and new hugetlb folios >> that are getting allocated in the VMA cannot make use of the >> reservations, failing these allocations. >> >> Fixes: b714ccb02a76 ("mm/mremap: complete refactor of move_vma()") >> Cc: stable@vger.kernel.org >> Reviewed-by: Lorenzo Stoakes (ARM) >> Signed-off-by: David Hildenbrand (Arm) >> --- > > Reviewed-by: Lance Yang Thanks for all the review, Lance! -- Cheers, David