From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F2AEC433E0 for ; Fri, 3 Jul 2020 19:24:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 27701207FF for ; Fri, 3 Jul 2020 19:24:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Cn44muIG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27701207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BCC128D008A; Fri, 3 Jul 2020 15:24:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7DC58D0030; Fri, 3 Jul 2020 15:24:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A92438D008A; Fri, 3 Jul 2020 15:24:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id 946568D0030 for ; Fri, 3 Jul 2020 15:24:05 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5E553824556B for ; Fri, 3 Jul 2020 19:24:05 +0000 (UTC) X-FDA: 76997740050.26.songs15_3217dd126e94 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 402671804B66E for ; Fri, 3 Jul 2020 19:24:05 +0000 (UTC) X-HE-Tag: songs15_3217dd126e94 X-Filterd-Recvd-Size: 4835 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Jul 2020 19:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593804244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=szNrRUnXkU/wXzHhuSNno6tjLuDfKJplDbKwsteOMYc=; b=Cn44muIGd7b/9SqdrVoMXQsAvZaeUPROsL5+mJvZ3Bee1cKMxjoYMcslPg7xbKr/ypXCQT iXtG+moUHmfYcpw/N7CAhYJITcpLiRfhpqtLV9DKahrUwaS/882NbTKI6VR12/6REPTeCJ QA+uR7uTnRNcO1Y5Au+slo5/fo2/eYI= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-85-aPpHoeDNMFKRrZ0l62oNPQ-1; Fri, 03 Jul 2020 15:24:02 -0400 X-MC-Unique: aPpHoeDNMFKRrZ0l62oNPQ-1 Received: by mail-qk1-f200.google.com with SMTP id z2so6692229qkb.17 for ; Fri, 03 Jul 2020 12:24:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=szNrRUnXkU/wXzHhuSNno6tjLuDfKJplDbKwsteOMYc=; b=TbDwidNmo8DJVE4zj6S8rAdDt1qSfuDTJYBzAvERIqWunu+Vnb1WfCTEuN+YxhNNea lJWhjClz33sf/vXudnGd07L5NkShPYcaY1S4KfP/txWKXDHkUQCXuMm/n0W4FM1Ws9g2 5k6urUbMGbHL3Wq5QcdmISjgvq9FLeYDBESH37xfCzAqWj99sveRety6FUIkBjTQWQan KFOpy17JjIi+IBnrGDyAs5tnjGT84+hhBLNHdNlxOvv9nln4+8wEKSkV40UtbNsn0A2o GvkhWUPZus8v9Nob4nnWUFZorS/YkqFwbYB42HHk9AgMmJ4UgeTZz+l7/jitfIdaw79d D/sQ== X-Gm-Message-State: AOAM531ssFnNHTxWnzGuH9zNOX8djpIHLDercyhIybvHN0NGjlelZZiq z32NB0rM41VKJ3YCwByjWfX1W4iYkX3OCpeba+rUG3UiqOY+TmQz1AFIyGgR0YO45sm3PjysUbG DK8MIVAaw9Bs= X-Received: by 2002:ad4:5a46:: with SMTP id ej6mr36640571qvb.52.1593804241999; Fri, 03 Jul 2020 12:24:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycF3wW8f/a2ysnQEJ8tVL7mhIPYBL3A4AysD41s2ds0xEgv4QKsUjP796I+99lamtaNozpzA== X-Received: by 2002:ad4:5a46:: with SMTP id ej6mr36640550qvb.52.1593804241666; Fri, 03 Jul 2020 12:24:01 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id i8sm11202871qtr.90.2020.07.03.12.24.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2020 12:24:01 -0700 (PDT) Subject: Re: [PATCH v2] mm: initialize return of vm_insert_pages To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20200703155354.29132-1-trix@redhat.com> <20200703120436.4031b4ea23e28a3babca3d2d@linux-foundation.org> From: Tom Rix Message-ID: <3fdd71e8-d149-888c-b7de-99e5f68871a0@redhat.com> Date: Fri, 3 Jul 2020 12:23:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200703120436.4031b4ea23e28a3babca3d2d@linux-foundation.org> Content-Language: en-US Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 X-Rspamd-Queue-Id: 402671804B66E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/3/20 12:04 PM, Andrew Morton wrote: > On Fri, 3 Jul 2020 08:53:54 -0700 trix@redhat.com wrote: > >> From: Tom Rix >> >> clang static analysis reports a garbage return >> >> In file included from mm/memory.c:84: >> mm/memory.c:1612:2: warning: Undefined or garbage value returned to ca= ller [core.uninitialized.UndefReturn] >> return err; >> ^~~~~~~~~~ >> >> The setting of err depends on a loop executing. >> So initialize err. >> >> ... >> >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -1601,7 +1601,7 @@ int vm_insert_pages(struct vm_area_struct *vma, = unsigned long addr, >> return insert_pages(vma, addr, pages, num, vma->vm_page_prot); >> #else >> unsigned long idx =3D 0, pgcount =3D *num; >> - int err; >> + int err =3D -EINVAL; >> =20 >> for (; idx < pgcount; ++idx) { >> err =3D vm_insert_page(vma, addr + (PAGE_SIZE * idx), pages[idx]); > If a caller were to ask vm_insert_pages() to insert zero pages, I > suspect we should just return zero and set *num to zero. That would be v1 of the patch. For the loop to not execute *num/pgcount is initially 0, and *num =3D pgc= ount - idx is 0 on exit. =C2=A0 >